From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4+SSiH9dqpKoHpMggNtxXlQNKDs1JM4yWVgrPrmG0NtopVnTYO2HUuRl/hvz1p8H41aX2QU ARC-Seal: i=1; a=rsa-sha256; t=1523021222; cv=none; d=google.com; s=arc-20160816; b=trwjQpTOTND82KW4WstohNUZDtGtrkR/TJLvwj0Rc2uFPbrT5DqH/SevdM0qZVrYTo ciWjnwK4APpbKuL00DBnLtvO4k3obFSm6ApXyRiHDuVZJh1c14QFnhZhpHZvdu74Ecbk mxXYAVpjLODGZv07CiAFfztcq8CgE4EVzXv424jrjRNbEjxiWAlG/C9TxlMaHpVCdyHb nEiftZ/BHcW6iS5bkDuqdvjBYlsxl8iZO0OmIGhbLICx0Dij8WhGH/D/JOC4Tml/2E9y V+YDNxk2nMBepWq8YhbohMLLJDops1ZWelDcDqrmd71WG7SNgVjL1cmNiYRkE28IcFKL 1KOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=hXNo8Zlmh463bmRVyl1uDAcitMEm1djcqfPeF7Fd39w=; b=x/nBfEwsVxpubHIRIWSqPtI9UIN4sBS17GqSQnfqPg51/EBYJIGf6g43PccJmL2l0S doEf8rf+sAONPIDqvDkKTt+airkPQmZpDmd3WgbNwDrlQo2AhADOjNggkY+ZH2SgrIbi 9ZH8feKtLcc/TXfFi/vorjBxxVd4yOARWrydkjvHcmi03HflQhk/druOkWzRsAUOXagg PXYs5Kw/Ccb8VUtJpYcz88k9FiHdK8W3E5ciZXpNzSLUmnndbCHggE5Gv1Yxryn7ar1e xft190NJpewE3Xn7ebAjzYV1zskdAFZjER704JARjPBJDg0LneV7G5zTwKyeY4IWVLP3 4VNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Lutomirski , Paolo Bonzini , Linus Torvalds Subject: [PATCH 3.18 20/93] kvm/x86: fix icebp instruction handling Date: Fri, 6 Apr 2018 15:22:49 +0200 Message-Id: <20180406084225.856184732@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180406084224.918716300@linuxfoundation.org> References: <20180406084224.918716300@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1597003501242180790?= X-GMAIL-MSGID: =?utf-8?q?1597003501242180790?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Linus Torvalds commit 32d43cd391bacb5f0814c2624399a5dad3501d09 upstream. The undocumented 'icebp' instruction (aka 'int1') works pretty much like 'int3' in the absense of in-circuit probing equipment (except, obviously, that it raises #DB instead of raising #BP), and is used by some validation test-suites as such. But Andy Lutomirski noticed that his test suite acted differently in kvm than on bare hardware. The reason is that kvm used an inexact test for the icebp instruction: it just assumed that an all-zero VM exit qualification value meant that the VM exit was due to icebp. That is not unlike the guess that do_debug() does for the actual exception handling case, but it's purely a heuristic, not an absolute rule. do_debug() does it because it wants to ascribe _some_ reasons to the #DB that happened, and an empty %dr6 value means that 'icebp' is the most likely casue and we have no better information. But kvm can just do it right, because unlike the do_debug() case, kvm actually sees the real reason for the #DB in the VM-exit interruption information field. So instead of relying on an inexact heuristic, just use the actual VM exit information that says "it was 'icebp'". Right now the 'icebp' instruction isn't technically documented by Intel, but that will hopefully change. The special "privileged software exception" information _is_ actually mentioned in the Intel SDM, even though the cause of it isn't enumerated. Reported-by: Andy Lutomirski Tested-by: Paolo Bonzini Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/vmx.h | 1 + arch/x86/kvm/vmx.c | 9 ++++++++- 2 files changed, 9 insertions(+), 1 deletion(-) --- a/arch/x86/include/asm/vmx.h +++ b/arch/x86/include/asm/vmx.h @@ -299,6 +299,7 @@ enum vmcs_field { #define INTR_TYPE_NMI_INTR (2 << 8) /* NMI */ #define INTR_TYPE_HARD_EXCEPTION (3 << 8) /* processor exception */ #define INTR_TYPE_SOFT_INTR (4 << 8) /* software interrupt */ +#define INTR_TYPE_PRIV_SW_EXCEPTION (5 << 8) /* ICE breakpoint - undocumented */ #define INTR_TYPE_SOFT_EXCEPTION (6 << 8) /* software exception */ /* GUEST_INTERRUPTIBILITY_INFO flags. */ --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -883,6 +883,13 @@ static inline bool is_machine_check(u32 (INTR_TYPE_HARD_EXCEPTION | MC_VECTOR | INTR_INFO_VALID_MASK); } +/* Undocumented: icebp/int1 */ +static inline bool is_icebp(u32 intr_info) +{ + return (intr_info & (INTR_INFO_INTR_TYPE_MASK | INTR_INFO_VALID_MASK)) + == (INTR_TYPE_PRIV_SW_EXCEPTION | INTR_INFO_VALID_MASK); +} + static inline bool cpu_has_vmx_msr_bitmap(void) { return vmcs_config.cpu_based_exec_ctrl & CPU_BASED_USE_MSR_BITMAPS; @@ -4951,7 +4958,7 @@ static int handle_exception(struct kvm_v (KVM_GUESTDBG_SINGLESTEP | KVM_GUESTDBG_USE_HW_BP))) { vcpu->arch.dr6 &= ~15; vcpu->arch.dr6 |= dr6 | DR6_RTM; - if (!(dr6 & ~DR6_RESERVED)) /* icebp */ + if (is_icebp(intr_info)) skip_emulated_instruction(vcpu); kvm_queue_exception(vcpu, DB_VECTOR);