From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Declan Doherty <declan.doherty@intel.com>,
dev@dpdk.org, Alex Rosenbaum <alexr@mellanox.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Alejandro Lucero <alejandro.lucero@netronome.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>,
Remy Horton <remy.horton@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Rony Efraim <ronye@mellanox.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Yuanhan Liu <yliu@fridaylinux.org>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 4/4] ethdev: Add metadata flow and action items support
Date: Fri, 6 Apr 2018 14:20:12 +0200 [thread overview]
Message-ID: <20180406122012.GQ4957@6wind.com> (raw)
In-Reply-To: <2392634.y0Dprd7BRi@xps>
On Thu, Apr 05, 2018 at 06:49:32PM +0200, Thomas Monjalon wrote:
> 05/04/2018 15:51, Declan Doherty:
> > +struct rte_flow_item_metadata {
> > + uint32_t id; /**< field identifier */
> > + uint32_t size; /**< field size */
> > + uint8_t bytes[]; /**< field value */
> > +};
>
> Spotted C99 syntax of flexible array.
> Are we OK with all supported compilers?
I also thought they were a good idea at first but got rid of them in
rte_flow [1] for the following reasons:
- Not valid/standard C++.
- Can't be statically initialized.
Both can be overcome by relying on compiler extensions, however their use
should be restricted to a minimum in public APIs for portability reasons.
[1] http://dpdk.org/ml/archives/dev/2018-April/095307.html
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2018-04-06 12:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 13:51 [PATCH v2 0/4] ethdev: Additions to support vTEP encap/decap offload Declan Doherty
2018-04-05 13:51 ` [PATCH v2 1/4] ethdev: add group counter support to rte_flow Declan Doherty
2018-04-05 16:31 ` Thomas Monjalon
2018-04-06 13:31 ` Mohammad Abdul Awal
2018-04-05 13:51 ` [PATCH v2 2/4] ethdev: Add vTEP encap/decap actions Declan Doherty
2018-04-05 16:42 ` Thomas Monjalon
2018-04-06 13:44 ` Mohammad Abdul Awal
2018-04-05 13:51 ` [PATCH v2 3/4] ethdev: Add group action type to rte_flow Declan Doherty
2018-04-05 13:51 ` [PATCH v2 4/4] ethdev: Add metadata flow and action items support Declan Doherty
2018-04-05 16:49 ` Thomas Monjalon
2018-04-06 12:20 ` Adrien Mazarguil [this message]
2018-04-06 13:47 ` Mohammad Abdul Awal
2018-04-06 15:57 ` Thomas Monjalon
2018-04-06 16:58 ` Mohammad Abdul Awal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406122012.GQ4957@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=alejandro.lucero@netronome.com \
--cc=alexr@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=mohammad.abdul.awal@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=remy.horton@intel.com \
--cc=ronye@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.