From: Richard Kuo <rkuo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] hexagon: add memset_io() helper
Date: Sat, 7 Apr 2018 20:31:30 -0500 [thread overview]
Message-ID: <20180408013130.GC3036@codeaurora.org> (raw)
In-Reply-To: <20180406142832.2243021-2-arnd@arndb.de>
On Fri, Apr 06, 2018 at 04:28:22PM +0200, Arnd Bergmann wrote:
> We already have memcpy_toio(), but not memset_io(), so let's
> add the obvious version to allow building an allmodconfig kernel
> without errors like
>
> drivers/gpu/drm/ttm/ttm_bo_util.c: In function 'ttm_bo_move_memcpy':
> drivers/gpu/drm/ttm/ttm_bo_util.c:390:3: error: implicit declaration of function 'memset_io' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/hexagon/include/asm/io.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
> index 9e8621d94ee9..e17262ad125e 100644
> --- a/arch/hexagon/include/asm/io.h
> +++ b/arch/hexagon/include/asm/io.h
> @@ -216,6 +216,12 @@ static inline void memcpy_toio(volatile void __iomem *dst, const void *src,
> memcpy((void *) dst, src, count);
> }
>
> +static inline void memset_io(volatile void __iomem *addr, int value,
> + size_t size)
> +{
> + memset((void __force *)addr, value, size);
> +}
> +
> #define PCI_IO_ADDR (volatile void __iomem *)
>
> /*
Acked-by: Richard Kuo <rkuo@codeaurora.org>
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-04-08 1:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 14:28 [PATCH 1/3] hexagon: fix ffz/fls/ffs return type Arnd Bergmann
2018-04-06 14:28 ` [PATCH 2/3] hexagon: add memset_io() helper Arnd Bergmann
2018-04-08 1:31 ` Richard Kuo [this message]
2018-04-06 14:28 ` [PATCH 3/3] hexagon: export csum_partial_copy_nocheck Arnd Bergmann
2018-04-08 1:32 ` Richard Kuo
2018-04-10 6:33 ` Arnd Bergmann
2018-04-08 1:35 ` [PATCH 1/3] hexagon: fix ffz/fls/ffs return type Richard Kuo
2018-04-10 6:31 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180408013130.GC3036@codeaurora.org \
--to=rkuo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.