From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/kmod: enable compression in host variant
Date: Sun, 8 Apr 2018 13:56:02 +0200 [thread overview]
Message-ID: <20180408115602.GB2327@scaer> (raw)
In-Reply-To: <20180408132847.095b0d27@windsurf>
Thomas, All,
On 2018-04-08 13:28 +0200, Thomas Petazzoni spake thusly:
> On Sun, 8 Apr 2018 10:12:31 +0200, Yann E. MORIN wrote:
> > When the modules are compressed by the kernel at install, it needs a
> > depmod with compression support to br able to generate the modules.dep
> > and associated files.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> > package/kmod/kmod.mk | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk
> > index e1149b7b65..c6264e16ab 100644
> > --- a/package/kmod/kmod.mk
> > +++ b/package/kmod/kmod.mk
> > @@ -9,7 +9,7 @@ KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.xz
> > KMOD_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kmod
> > KMOD_INSTALL_STAGING = YES
> > KMOD_DEPENDENCIES = host-pkgconf
> > -HOST_KMOD_DEPENDENCIES = host-pkgconf
> > +HOST_KMOD_DEPENDENCIES = host-pkgconf host-xz host-zlib
>
> It is a bit annoying to add those dependencies unconditionally :-/
Yep, bt we can't automatically know whether the user will be using
compressed modules or not. And by the time we can look at the kernel's
.config file, it is too late to add those dependencies to host-kmod.
The alternative is to add new options to linux/Config.in to enable
module compression (which one, or none), and automatically derive the
extra needed dependencies.
TBH, I'm not too fond of either solution...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2018-04-08 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 8:12 [Buildroot] [PATCH] package/kmod: enable compression in host variant Yann E. MORIN
2018-04-08 11:28 ` Thomas Petazzoni
2018-04-08 11:56 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180408115602.GB2327@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.