All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
	Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Subject: [PATCH v2 7/9] powerpc/powernv: OPAL dump support standardise OPAL_BUSY delays
Date: Mon,  9 Apr 2018 15:24:29 +1000	[thread overview]
Message-ID: <20180409052431.26405-8-npiggin@gmail.com> (raw)
In-Reply-To: <20180409052431.26405-1-npiggin@gmail.com>

Convert to using the standard delay poll/delay form.

The dump code:

- Did not previously delay or sleep in the OPAL_BUSY case.
- Used a 20ms sleep.

Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/platforms/powernv/opal-dump.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c
index 0dc8fa4e0af2..4ab749ceafc2 100644
--- a/arch/powerpc/platforms/powernv/opal-dump.c
+++ b/arch/powerpc/platforms/powernv/opal-dump.c
@@ -260,12 +260,14 @@ static int64_t dump_read_data(struct dump_obj *dump)
 	addr = __pa(list);
 
 	/* Fetch data */
-	rc = OPAL_BUSY_EVENT;
+	rc = OPAL_BUSY;
 	while (rc == OPAL_BUSY || rc == OPAL_BUSY_EVENT) {
 		rc = opal_dump_read(dump->id, addr);
 		if (rc == OPAL_BUSY_EVENT) {
+			msleep(OPAL_BUSY_DELAY_MS);
 			opal_poll_events(NULL);
-			msleep(20);
+		} else if (rc == OPAL_BUSY) {
+			msleep(OPAL_BUSY_DELAY_MS);
 		}
 	}
 
-- 
2.17.0

  parent reply	other threads:[~2018-04-09  5:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09  5:24 [PATCH v2 0/9] first step of standardising OPAL_BUSY handling Nicholas Piggin
2018-04-09  5:24 ` [PATCH v2 1/9] powerpc/powernv: define a standard delay for OPAL_BUSY type retry loops Nicholas Piggin
2018-04-09  5:24 ` [PATCH v2 2/9] powerpc/powernv: OPAL RTC driver standardise OPAL_BUSY loops Nicholas Piggin
2018-04-09  5:24 ` [PATCH v2 3/9] powerpc/powernv: opal_put_chars partial write fix Nicholas Piggin
2018-04-09  5:50   ` Benjamin Herrenschmidt
2018-04-09  5:24 ` [PATCH v2 4/9] powerpc/powernv: OPAL console standardise OPAL_BUSY loops Nicholas Piggin
2018-04-09  5:53   ` Benjamin Herrenschmidt
2018-04-09  6:13     ` Nicholas Piggin
2018-04-09  8:22       ` Benjamin Herrenschmidt
2018-04-09  5:24 ` [PATCH v2 5/9] powerpc/powernv: OPAL platform " Nicholas Piggin
2018-04-09  5:24 ` [PATCH v2 6/9] powerpc/powernv: OPAL NVRAM driver standardise OPAL_BUSY delays Nicholas Piggin
2018-04-09  5:24 ` Nicholas Piggin [this message]
2018-04-09  5:24 ` [PATCH v2 8/9] powerpc/xive: " Nicholas Piggin
2018-04-09  5:24 ` [PATCH v2 9/9] powerpc/powernv: opal-kmsg standardise OPAL_BUSY handling Nicholas Piggin
2018-04-10  5:01   ` Russell Currey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180409052431.26405-8-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=hegdevasant@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.