From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, Bart.VanAssche@wdc.com,
linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request
Date: Mon, 9 Apr 2018 19:21:58 +0200 [thread overview]
Message-ID: <20180409172158.GB5697@lst.de> (raw)
In-Reply-To: <20180409165203.GE11756@bombadil.infradead.org>
On Mon, Apr 09, 2018 at 09:52:03AM -0700, Matthew Wilcox wrote:
> On Mon, Apr 09, 2018 at 05:39:16PM +0200, Christoph Hellwig wrote:
> > blk_get_request is used for pass-through style I/O and thus doesn't need
> > GFP_NOIO.
>
> Obviously GFP_KERNEL is a big improvement over GFP_NOIO! But can we take
> it all the way to GFP_USER, if this is always done in the ioctl path
> (which it seems to be, except for nfsd, which presumably won't have
> a cpuset memory allocation policy ... and if it did, the admin might
> appreciate it honouring said policy).
GFP_USER claims to be for allocations mapped into userspace, and except
for a few outliers that is how we use it. I see no reason to change
that here.
next prev parent reply other threads:[~2018-04-09 17:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 15:39 [RFC] fix confusion around GFP_* flags and blk_get_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 1/7] scsi/osd: remove the gfp argument to osd_start_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 2/7] block: fix __get_request documentation Christoph Hellwig
2018-04-09 15:39 ` [PATCH 3/7] block: sanitize blk_get_request calling conventions Christoph Hellwig
2018-04-10 6:26 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 4/7] block: pass explicit gfp_t to get_request Christoph Hellwig
2018-04-10 6:27 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 5/7] block: use GFP_NOIO instead of __GFP_DIRECT_RECLAIM Christoph Hellwig
2018-04-10 6:27 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 6/7] block: consistently use GFP_NOIO instead of __GFP_NORECLAIM Christoph Hellwig
2018-04-09 16:03 ` Matthew Wilcox
2018-04-09 17:20 ` Christoph Hellwig
2018-04-10 6:28 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request Christoph Hellwig
2018-04-09 16:52 ` Matthew Wilcox
2018-04-09 17:21 ` Christoph Hellwig [this message]
2018-04-10 6:29 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409172158.GB5697@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.