From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] download/git: more resilient in case of kill
Date: Mon, 9 Apr 2018 23:56:33 +0200 [thread overview]
Message-ID: <20180409215633.GC2312@scaer> (raw)
In-Reply-To: <20180409234524.4144b90b@windsurf>
Thomas, All,
On 2018-04-09 23:45 +0200, Thomas Petazzoni spake thusly:
> Hello,
>
> On Mon, 9 Apr 2018 23:41:55 +0200, Yann E. MORIN wrote:
>
> > +pushd "${git_cache}" >/dev/null
>
> So you're doing the pushd here now.
>
> > +
> > +# Ensure the repo has an origin (in case a previous run was killed).
> > +if git remote |grep -q -E '^origin$'
> > pushd "${git_cache}" >/dev/null
>
> And therefore I'm not sure why it's needed here...
>
> > _git remote add origin "'${uri}'"
> > popd >/dev/null
>
> ... and this popd would no longer be needed.
>
> > fi
> >
> > -pushd "${git_cache}" >/dev/null
>
> I am missing something?
Absolutely nothing.
I will respin.
Thanks.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2018-04-09 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 21:41 [Buildroot] [PATCH] download/git: more resilient in case of kill Yann E. MORIN
2018-04-09 21:45 ` Thomas Petazzoni
2018-04-09 21:56 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409215633.GC2312@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.