From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:35562 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751947AbeDJHL6 (ORCPT ); Tue, 10 Apr 2018 03:11:58 -0400 Date: Tue, 10 Apr 2018 09:11:51 +0200 From: Greg Kroah-Hartman To: Nathan Chancellor Cc: stable@vger.kernel.org, "Jason A . Donenfeld" , Sergei Shtylyov , "Michael S. Tsirkin" , Jason Wang , "David S . Miller" Subject: Re: [PATCH 4.9 3/3] virtio_net: check return value of skb_to_sgvec in one more location Message-ID: <20180410071151.GC19397@kroah.com> References: <20180410012150.6573-1-natechancellor@gmail.com> <20180410012150.6573-10-natechancellor@gmail.com> <20180410063537.GA14796@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410063537.GA14796@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Apr 10, 2018 at 08:35:37AM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 09, 2018 at 06:21:50PM -0700, Nathan Chancellor wrote: > > Kernels that do not have f6b10209b90d ("virtio-net: switch to use > > build_skb() for small buffer") will have an extra call to skb_to_sgvec > > that is not handled by e2fcad58fd23 ("virtio_net: check return value of > > skb_to_sgvec always"). Since the former does not appear to be stable > > material, just fix the call up directly. > > > > Cc: Jason A. Donenfeld > > Cc: Sergei Shtylyov > > Cc: "Michael S. Tsirkin" > > Cc: Jason Wang > > Cc: David S. Miller > > Signed-off-by: Nathan Chancellor > > --- > > > > Greg, if you feel this should be squashed into the previous commit, by > > all means, feel free. I am not entirely sure if the dev_kfree_skb is > > necessary here, I was hoping to get some review. > > You did the right thing here by "not squashing" this into the previous > patch, thanks! And all 3 of these fixed up the remaining 4.9.y build issues, many thanks for these. greg k-h