From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Sasha Levin <Alexander.Levin@microsoft.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] firmware: dmi_scan: Fix UUID length safety check
Date: Tue, 10 Apr 2018 10:19:35 +0300 [thread overview]
Message-ID: <20180410071935.GW2173@lahna.fi.intel.com> (raw)
In-Reply-To: <20180409145143.4daa1706@endymion>
On Mon, Apr 09, 2018 at 02:51:43PM +0200, Jean Delvare wrote:
> The test which ensures that the DMI type 1 structure is long enough
> to hold the UUID is off by one. It would fail if the structure is
> exactly 24 bytes long, while that's sufficient to hold the UUID.
>
> I don't expect this bug to cause problem in practice because all
> implementations I have seen had length 8, 25 or 27 bytes, in line
> with the SMBIOS specifications. But let's fix it still.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Fixes: a814c3597a6b ("firmware: dmi_scan: Check DMI structure length")
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2018-04-10 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 12:51 [PATCH] firmware: dmi_scan: Fix UUID length safety check Jean Delvare
2018-04-10 7:19 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410071935.GW2173@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Alexander.Levin@microsoft.com \
--cc=andy.shevchenko@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jdelvare@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.