All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] download/git: more resilient in case of kill
Date: Tue, 10 Apr 2018 09:36:40 +0200	[thread overview]
Message-ID: <20180410093640.0ffcaab1@windsurf> (raw)
In-Reply-To: <20180409215651.549-1-yann.morin.1998@free.fr>

Hello,

On Mon,  9 Apr 2018 23:56:51 +0200, Yann E. MORIN wrote:
> In case the git backend gets killed right in-between it finished
> initialising the repository, but before it could add the remote,
> we'd end up with a repository without the 'origin' remote, so we
> would not be able to change its URL.
> 
> Another case that may happen (like in the build failure, below),
> is that the repository was initialised with a previous version
> of Buildroot, before the commit e17719264b (download/git: don't
> require too-recent git) was applied, and that trepository was
> still lying around...
> 
> Fixes:
>     http://autobuild.buildroot.org/results/25a/25aae054634368fadb265b97ebe4dda809deff6f/
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> 
> ---
> Changes v1 -> v2:
>   - remove extraneous pushd/popd  (Thomas)
>   - fix if-block condition
> ---
>  support/download/git | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-04-10  7:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 21:56 [Buildroot] [PATCHv2] download/git: more resilient in case of kill Yann E. MORIN
2018-04-10  7:36 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180410093640.0ffcaab1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.