From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/mesa3d: add dependency on elfutils to r600 with llvm
Date: Tue, 10 Apr 2018 17:51:48 +0200 [thread overview]
Message-ID: <20180410175148.71878897@windsurf> (raw)
In-Reply-To: <20180410151959.18713-1-valentin.korenblit@smile.fr>
Hello Valentin,
On Tue, 10 Apr 2018 17:19:59 +0200, Valentin Korenblit wrote:
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index 1476b39acc..391a1cbaed 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -97,13 +97,28 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU
> config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600
> bool "Gallium Radeon R600 driver"
> depends on BR2_i386 || BR2_x86_64
> + depends on !BR2_PACKAGE_MESA3D_LLVM
Why ?
> select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
> select BR2_PACKAGE_LIBDRM_RADEON
> - select BR2_PACKAGE_LLVM_AMDGPU if BR2_PACKAGE_MESA3D_LLVM
> select BR2_PACKAGE_MESA3D_NEEDS_XA
> help
> Driver for ATI/AMD Radeon R600/R700/HD5000/HD6000 GPUs.
>
> +config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600_LLVM
> + bool "Gallium Radeon R600 driver with LLVM support"
> + depends on BR2_i386 || BR2_x86_64
> + depends on BR2_PACKAGE_MESA3D_LLVM
> + depends on BR2_TOOLCHAIN_USES_UCLIBC || \
> + BR2_TOOLCHAIN_USES_GLIBC # elfutils
> + select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
> + select BR2_PACKAGE_LIBDRM_RADEON
> + select BR2_PACKAGE_LLVM_AMDGPU
> + select BR2_PACKAGE_ELFUTILS
> + select BR2_PACKAGE_MESA3D_NEEDS_XA
> + help
> + Driver for ATI/AMD Radeon R600/R700/HD5000/HD6000 GPUs
> + with LLVM support.
I don't understand why you have two mutually exclusive options here.
Why not instead have a sub-option ?
Something like:
config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600
bool "Gallium Radeon R600 driver"
depends on BR2_i386 || BR2_x86_64
select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
select BR2_PACKAGE_LIBDRM_RADEON
select BR2_PACKAGE_MESA3D_NEEDS_XA
help
Driver for ATI/AMD Radeon R600/R700/HD5000/HD6000 GPUs.
config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600_LLVM
bool "Enable LLVM support in R600 driver"
depends on BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600
depends on BR2_PACKAGE_MESA3D_LLVM
depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC # elfutils
select BR2_PACKAGE_LLVM_AMDGPU
select BR2_PACKAGE_ELFUTILS
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-10 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 15:19 [Buildroot] [PATCH] package/mesa3d: add dependency on elfutils to r600 with llvm Valentin Korenblit
2018-04-10 15:51 ` Thomas Petazzoni [this message]
2018-04-10 16:21 ` Valentin Korenblit
2018-04-10 21:33 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410175148.71878897@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.