From: Johan Hovold <johan@kernel.org>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: samuel@sortiz.org, gregkh@linuxfoundation.org,
davem@davemloft.net, johan@kernel.org, arvind.yadav.cs@gmail.com,
netdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: irda: Replace mdelay with usleep_range in irda_usb_probe
Date: Wed, 11 Apr 2018 09:08:20 +0200 [thread overview]
Message-ID: <20180411070820.GF10795@localhost> (raw)
In-Reply-To: <1523410435-1693-1-git-send-email-baijiaju1990@gmail.com>
On Wed, Apr 11, 2018 at 09:33:55AM +0800, Jia-Ju Bai wrote:
> irda_usb_probe() is never called in atomic context.
>
> irda_usb_probe() is only set as ".probe" in struct usb_driver.
>
> Despite never getting called from atomic context, irda_usb_probe()
> calls mdelay() to busily wait.
> This is not necessary and can be replaced with usleep_range() to
> avoid busy waiting.
>
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
prev parent reply other threads:[~2018-04-11 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 1:33 [PATCH 2/2] staging: irda: Replace mdelay with usleep_range in irda_usb_probe Jia-Ju Bai
2018-04-11 1:33 ` Jia-Ju Bai
2018-04-11 7:08 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411070820.GF10795@localhost \
--to=johan@kernel.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.