From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,1/6] dt-bindings: dma: xilinx_dma: Add optional property has_axieth_connected From: Vinod Koul Message-Id: <20180411090525.GX6014@localhost> Date: Wed, 11 Apr 2018 14:35:26 +0530 To: Radhey Shyam Pandey , Rob Herring , devicetree@vger.kernel.org Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, appana.durga.rao@xilinx.com, radheys@xilinx.com, lars@metafoo.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: T24gTW9uLCBBcHIgMDIsIDIwMTggYXQgMDQ6MDk6MDFQTSArMDUzMCwgUmFkaGV5IFNoeWFtIFBh bmRleSB3cm90ZToKPiBBZGQgYW4gb3B0aW9uYWwgQVhJIERNQSBwcm9wZXJ0eSAnaGFzX2F4aWV0 aF9jb25uZWN0ZWQnLiBUaGlzIGNhbiBiZQo+IHNwZWNpZmllZCB0byBpbmRpY2F0ZSB0aGF0IEFY SSBETUEgaXMgY29ubmVjdGVkIHRvIEFYSSBFdGhlcm5ldCBpbgo+IGhhcmR3YXJlIGRlc2lnbiBh bmQgZG1hIGRyaXZlciBuZWVkcyB0byBkbyBzb21lIGFkZGl0aW9uYWwgaGFuZGxpbmcuCgoxLiB3 aHkgYXJlIERUIHBlb3BsZSBhbmQgbGlzdCBub3QgYWRkZWQgdG8gdGhpcz8gSSBoYXZlIGFkZGVk IHRoYXQKMi4gc2hvdWxkIHdlIGhhdmUgYSBwcm9wZXJ0eSBmb3IgYSBzcGVjaWZpYyBwZXJpcGhl cmFsPyBXb3VsZG4ndCBpdCBoZWxwIHRvIGhhdmUKYSBnZW5lcmljIHByb3BlcnR5IGZvciBwZXJp cGhlcmFsIGNvbm5lY3RlZCB3aGljaCBjYW4gYmUgc2NhbGVkIHRvIG1vcmUgSVBzCmJlaW5nIGNv bm5lY3RlZCBpbiBmdXR1cmU/CjMuIFBsZWFzZSB1c2UgcmlnaHQgc3Vic3lzdGVtIG5hbWUsIGl0 IGRhbWVuZ2luZTogbm90IGRtYToKCj4gCj4gU2lnbmVkLW9mZi1ieTogUmFkaGV5IFNoeWFtIFBh bmRleSA8cmFkaGV5c0B4aWxpbnguY29tPgo+IC0tLQo+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5n cy9kbWEveGlsaW54L3hpbGlueF9kbWEudHh0ICB8ICAgIDEgKwo+ICAxIGZpbGVzIGNoYW5nZWQs IDEgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS94aWxpbngveGlsaW54X2RtYS50eHQgYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZG1hL3hpbGlueC94aWxpbnhfZG1hLnR4 dAo+IGluZGV4IGEyYjhiZmEuLjVkNTkyZTMgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS94aWxpbngveGlsaW54X2RtYS50eHQKPiArKysgYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZG1hL3hpbGlueC94aWxpbnhfZG1hLnR4dAo+ IEBAIC00Miw2ICs0Miw3IEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6Cj4gIAl0aGUgaGFyZHdhcmUu Cj4gIE9wdGlvbmFsIHByb3BlcnRpZXMgZm9yIEFYSSBETUE6Cj4gIC0geGxueCxtY2RtYTogVGVs bHMgd2hldGhlciBjb25maWd1cmVkIGZvciBtdWx0aS1jaGFubmVsIG1vZGUgaW4gdGhlIGhhcmR3 YXJlLgo+ICstIHhsbngsYXhpZXRoLWNvbm5lY3RlZDogVGVsbHMgd2hldGhlciBBWEkgRE1BIGlz IGNvbm5lY3RlZCB0byBBWEkgRXRoZXJuZXQuCj4gIE9wdGlvbmFsIHByb3BlcnRpZXMgZm9yIFZE TUE6Cj4gIC0geGxueCxmbHVzaC1mc3luYzogVGVsbHMgd2hpY2ggY2hhbm5lbCB0byBGbHVzaCBv biBGcmFtZSBzeW5jLgo+ICAJSXQgdGFrZXMgZm9sbG93aW5nIHZhbHVlczoKPiAtLSAKPiAxLjcu MQo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Wed, 11 Apr 2018 14:35:26 +0530 Subject: [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property has_axieth_connected In-Reply-To: <1522665546-10035-2-git-send-email-radheys@xilinx.com> References: <1522665546-10035-1-git-send-email-radheys@xilinx.com> <1522665546-10035-2-git-send-email-radheys@xilinx.com> Message-ID: <20180411090525.GX6014@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 02, 2018 at 04:09:01PM +0530, Radhey Shyam Pandey wrote: > Add an optional AXI DMA property 'has_axieth_connected'. This can be > specified to indicate that AXI DMA is connected to AXI Ethernet in > hardware design and dma driver needs to do some additional handling. 1. why are DT people and list not added to this? I have added that 2. should we have a property for a specific peripheral? Wouldn't it help to have a generic property for peripheral connected which can be scaled to more IPs being connected in future? 3. Please use right subsystem name, it damengine: not dma: > > Signed-off-by: Radhey Shyam Pandey > --- > .../devicetree/bindings/dma/xilinx/xilinx_dma.txt | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > index a2b8bfa..5d592e3 100644 > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > @@ -42,6 +42,7 @@ Optional properties: > the hardware. > Optional properties for AXI DMA: > - xlnx,mcdma: Tells whether configured for multi-channel mode in the hardware. > +- xlnx,axieth-connected: Tells whether AXI DMA is connected to AXI Ethernet. > Optional properties for VDMA: > - xlnx,flush-fsync: Tells which channel to Flush on Frame sync. > It takes following values: > -- > 1.7.1 > -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property has_axieth_connected Date: Wed, 11 Apr 2018 14:35:26 +0530 Message-ID: <20180411090525.GX6014@localhost> References: <1522665546-10035-1-git-send-email-radheys@xilinx.com> <1522665546-10035-2-git-send-email-radheys@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1522665546-10035-2-git-send-email-radheys@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org To: Radhey Shyam Pandey , Rob Herring , devicetree@vger.kernel.org Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, appana.durga.rao@xilinx.com, radheys@xilinx.com, lars@metafoo.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Mon, Apr 02, 2018 at 04:09:01PM +0530, Radhey Shyam Pandey wrote: > Add an optional AXI DMA property 'has_axieth_connected'. This can be > specified to indicate that AXI DMA is connected to AXI Ethernet in > hardware design and dma driver needs to do some additional handling. 1. why are DT people and list not added to this? I have added that 2. should we have a property for a specific peripheral? Wouldn't it help to have a generic property for peripheral connected which can be scaled to more IPs being connected in future? 3. Please use right subsystem name, it damengine: not dma: > > Signed-off-by: Radhey Shyam Pandey > --- > .../devicetree/bindings/dma/xilinx/xilinx_dma.txt | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > index a2b8bfa..5d592e3 100644 > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > @@ -42,6 +42,7 @@ Optional properties: > the hardware. > Optional properties for AXI DMA: > - xlnx,mcdma: Tells whether configured for multi-channel mode in the hardware. > +- xlnx,axieth-connected: Tells whether AXI DMA is connected to AXI Ethernet. > Optional properties for VDMA: > - xlnx,flush-fsync: Tells which channel to Flush on Frame sync. > It takes following values: > -- > 1.7.1 > -- ~Vinod