From: David Sterba <dsterba@suse.cz>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: davem@davemloft.net, johannes.berg@intel.com, jikos@kernel.org,
gregkh@linuxfoundation.org, stephen@networkplumber.org,
Jiri Slaby <JSlaby@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: ipwireless: Replace GFP_ATOMIC with GFP_KERNEL in ipwireless_network_create
Date: Wed, 11 Apr 2018 13:09:45 +0200 [thread overview]
Message-ID: <20180411110945.GA21272@suse.cz> (raw)
In-Reply-To: <1523349106-29584-1-git-send-email-baijiaju1990@gmail.com>
On Tue, Apr 10, 2018 at 04:31:46PM +0800, Jia-Ju Bai wrote:
> ipwireless_network_create() is never called in atomic context.
>
> The call chain ending up at ipwireless_network_create() is:
> [1] ipwireless_network_create() <- config_ipwireless() <-
> ipwireless_attach()
> ipwireless_attach() is only set as ".probe" in struct pcmcia_driver.
>
> Despite never getting called from atomic context,
> ipwireless_network_create() calls kzalloc() with GFP_ATOMIC,
> which does not sleep for allocation.
> GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
> which can sleep and improve the possibility of sucessful allocation.
>
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
We don't have any other patches queued for this driver so it would be
best if this patch goes via net or Greg's tree.
next prev parent reply other threads:[~2018-04-11 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 8:31 [PATCH] tty: ipwireless: Replace GFP_ATOMIC with GFP_KERNEL in ipwireless_network_create Jia-Ju Bai
2018-04-11 11:09 ` David Sterba [this message]
2018-04-11 12:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411110945.GA21272@suse.cz \
--to=dsterba@suse.cz \
--cc=JSlaby@suse.com \
--cc=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.