From: Tejun Heo <tj@kernel.org>
To: Alexandru Moise <00moses.alexander00@gmail.com>
Cc: axboe@kernel.dk, shli@fb.com, nborisov@suse.com, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release
Date: Wed, 11 Apr 2018 07:20:19 -0700 [thread overview]
Message-ID: <20180411142019.GG793541@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180411101242.GA2322@gmail.com>
Hello,
On Wed, Apr 11, 2018 at 12:12:56PM +0200, Alexandru Moise wrote:
> > But we already do this through calling blkcg_exit_queue() from
> > __blk_release_queue(). What's missing?
>
> Hi,
>
> It might be the jetlag but I can't see how you end up calling
> blkcg_exit_queue() from __blk_release_queue().
>
> As I see it the only way to reach blkcg_exit_queue() is from
> blk_cleanup_queue(), which I don't see anywhere in __blk_release_queue().
>
> I suspect that I'm just fixing a corner case though and
> the general case is what you describe or similar.
Ah, that changed recently. Can you please check out the current
upstream git master?
Thanks.
--
tejun
next prev parent reply other threads:[~2018-04-11 14:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 10:21 [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release Alexandru Moise
2018-04-09 22:09 ` Tejun Heo
2018-04-11 10:12 ` Alexandru Moise
2018-04-11 14:20 ` Tejun Heo [this message]
2018-04-11 14:28 ` Alexandru Moise
2018-04-11 14:46 ` Tejun Heo
2018-04-11 14:51 ` Tejun Heo
2018-04-11 14:56 ` Tejun Heo
2018-04-11 16:42 ` Bart Van Assche
2018-04-11 16:42 ` Bart Van Assche
2018-04-11 17:00 ` tj
2018-04-11 17:06 ` Bart Van Assche
2018-04-11 17:06 ` Bart Van Assche
2018-04-11 17:15 ` tj
2018-04-11 17:26 ` Bart Van Assche
2018-04-11 17:26 ` Bart Van Assche
2018-04-11 17:30 ` tj
2018-04-11 15:54 ` Bart Van Assche
2018-04-11 15:54 ` Bart Van Assche
2018-04-11 19:00 ` Alexandru Moise
2018-04-11 19:55 ` Bart Van Assche
2018-04-11 19:57 ` tj
2018-04-11 20:00 ` Bart Van Assche
2018-04-11 20:00 ` Bart Van Assche
2018-04-11 20:02 ` tj
2018-04-11 20:23 ` Bart Van Assche
2018-04-11 20:23 ` Bart Van Assche
2018-04-11 21:23 ` Alexandru Moise
2018-04-11 21:28 ` Bart Van Assche
2018-04-11 21:28 ` Bart Van Assche
2018-04-11 22:58 ` Alexandru Moise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411142019.GG793541@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=00moses.alexander00@gmail.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.