From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3374234-1523482025-2-8026042689860928770 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523482025; b=kJlXwydEkB+EOWt7i4X2k93EXp9zLcradczQIxEOIEFEQGs0TH glxIaH8U5tmA54iL27s2ZmDpGOL0hNDzjlMOlUgyuAd1jGByHcIdG7GFpBT6p9lg D9tUW1kbx52zTGos8dinspYVCPeAOsD97wb/ETJyVQ0IZd4kl9cOg8TfT4T6X8tl 5OMvP/r9+m3QSsSNG4HARXhaMsNJoauYmQLqtQNV+8hEmvL6h6/34rk/DhGSXmuf gYyS/FUHozj6wvVDJKUfFHGJ9xbzz2X2QhYdNgUBBAHS2W0iCz4mx6my7L73ZLxg uHUlkFZ7sMeu471lQZP+d+SE0n53l1SOGNTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=fm2; t=1523482025; bh=JtLXvGAPD5lONzeP0j3VWmWNdEFuSA Z7mYlja9X/UqE=; b=RroAmDKgUTmIr0MYj0qXa3CKePdAkU/3Egd1wH2r3KRDQF XEayS1QTKwu6qdMyWJpdWXiG0YTBfo5ot5Wjw1M6XPO1oP6joZrZfLLHybTw67Gl JP49GUdj6XPbKqLAut2IyU1uyAV4UMZQOmdFKjly0V2nuCTdw7HuP9ndIBjdFJZS nxhBrK8Ja9gJhY6GsoxYJe66CCXiNXHaxLx9Iz/KcNwXlmPaUhyq6mcyddNLkWVh 4CmquJSbyEBlu8tKurmx5H2UDLsW3qG3Uk42LzUVIeEOAspd+axuaacivKKNaeNM 3wvhdi3BhRA0PhH25yGzc7SsigTdDCK9kuVV63dg== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfJikVUslbrmsQ8sd3SNhj+9eTMDydDRkYKSfOmBTIGS1hC69gXIq49xgxZdUqAlvEZk+Ere4bMGhmj3ocu3r+LZU3EAUjpuYtOMwY/IC5v4HiIsWIJc5 Ec5NZMcJ/F72AVdGZjugrWcF8Nt4IHxob1TN+6zANHN4bjSELV95rEtJzmeBlzLokCJ389/mwyY7QTEF/55juJMAAljyVGDtU5cDIWP5Ckx11ChkBmJRHzM7 X-CM-Analysis: v=2.3 cv=WaUilXpX c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=cm27Pg_UAAAA:8 a=pGLkceISAAAA:8 a=J1Y8HTJGAAAA:8 a=yMhMjlubAAAA:8 a=ag1SF4gXAAAA:8 a=Bz2UWhLJlFZaMJpv9z8A:9 a=QEXdDO2ut3YA:10 a=xmb-EsYY8bH0VWELuYED:22 a=y1Q9-5lHfBjTkpIzbSAN:22 a=Yupwre4RP9_Eg_Bd0iYG:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753932AbeDKSiK (ORCPT ); Wed, 11 Apr 2018 14:38:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55250 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbeDKSiI (ORCPT ); Wed, 11 Apr 2018 14:38:08 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Micay , Kees Cook , "David S. Miller" , Sasha Levin Subject: [PATCH 3.18 005/121] bna: Avoid reading past end of buffer Date: Wed, 11 Apr 2018 20:35:08 +0200 Message-Id: <20180411183456.553047660@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183456.195010921@linuxfoundation.org> References: <20180411183456.195010921@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kees Cook [ Upstream commit 9e4eb1ce472fbf7b007f23c88ec11c37265e401c ] Using memcpy() from a string that is shorter than the length copied means the destination buffer is being filled with arbitrary data from the kernel rodata segment. Instead, use strncpy() which will fill the trailing bytes with zeros. This was found with the future CONFIG_FORTIFY_SOURCE feature. Cc: Daniel Micay Signed-off-by: Kees Cook Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c @@ -2856,7 +2856,7 @@ bfa_ioc_get_adapter_optrom_ver(struct bf static void bfa_ioc_get_adapter_manufacturer(struct bfa_ioc *ioc, char *manufacturer) { - memcpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN); + strncpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN); } static void