From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3374234-1523481748-2-1658607552714814396 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523481747; b=YMhx8fAa92aGI9kkaUodGkh9Infr0PXaY5qjx5svHRIL0vG0zp 5ZmYNWDPNk+Q3SFr4R2TGPlBbIXCwh37M2qyqNUHeB2L9cSn38aJmVp8Wo1qoMtO NUbSpHRfoXzh98/4pIJz41FmjD9p8NV6usyxMxBEVJhHL9rN4mOofV/cV0Gw7a6c 0a4ZDRkGUZqkXvYfIO94t/hi+Tq4btbCZJFKTNvtSoNHExqe/1/zJ5f9sin4Okn8 AGRCw7jmeY0G+kLXHQH49C0mxRtfZgWHo69VUpseDRpYQbyEOrqT1P27gm8UWt6L TUSDSVkT/HMSj8m9+SDqMOxivJoRSb9JwKBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=fm2; t=1523481747; bh=RlBaWcGWKPXALgtEuogo70MnFy3ErI Dg6DiRxKqbVVU=; b=PXmSecAJr/wl9Pgd59kgEIMSjiU2qefGvHqK6YRUs1aKrF KgF9Czg8h34CX3MXPJNBCKayOgG4y+HXAZGIzY5Xvo515lYs4HYVq9PdR8zY2C12 44g66YdaEinNX4wogEJoz9kI+aerwnUjnK8yfV422AJvs6jDR29ACSQHClCR1Nek iIVsMCzizGFb63CrbVLOHw5jxwHmzSdVegW/RiXdNPV3gaOBVCy5whiZTJNN8NUk lEEcb/NZBBtTPaanXYpNTQNcvTIXL9UyE6U47Zzx7sOcwrqWfkgsReWLeDEja5lM v/ykinwLehCeUW05glBMo4KOiyBIoBqTceMiPFyw== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfBNmg3gGDcRZbha9bUiQuq1WKtfGTe11WEgF2ShSiRrC2nMI1WaL4bhNTdMX2ESJo/tpsdIFm0y7ES/bFgnvT2YC7sv8Em5q6qaqnOoLwWcubktmB7jq T1guIuJiXzwNm8kpLaN6nybkenkKLaQsZWzXclsm1AuKyeM0xGEOpN6kb7lq9xQrO4AXIY+jj8Oxxtwa7z7jQGTn59XwbNZVhd688cn8mFodqhnwWFS7eYVo X-CM-Analysis: v=2.3 cv=JLoVTfCb c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=P1BnusSwAAAA:8 a=J1Y8HTJGAAAA:8 a=yMhMjlubAAAA:8 a=ag1SF4gXAAAA:8 a=UsjPlrKyebQagM4GtYIA:9 a=QEXdDO2ut3YA:10 a=D0XLA9XvdZm18NrgonBM:22 a=y1Q9-5lHfBjTkpIzbSAN:22 a=Yupwre4RP9_Eg_Bd0iYG:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754278AbeDKSjF (ORCPT ); Wed, 11 Apr 2018 14:39:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55604 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251AbeDKSjD (ORCPT ); Wed, 11 Apr 2018 14:39:03 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart , "David S. Miller" , Sasha Levin Subject: [PATCH 3.18 032/121] sh_eth: Use platform device for printing before register_netdev() Date: Wed, 11 Apr 2018 20:35:35 +0200 Message-Id: <20180411183458.034766543@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183456.195010921@linuxfoundation.org> References: <20180411183456.195010921@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Geert Uytterhoeven [ Upstream commit 5f5c5449acad0cd3322e53e1ac68c044483b0aa5 ] The MDIO initialization failure message is printed using the network device, before it has been registered, leading to: (null): failed to initialise MDIO Use the platform device instead to fix this: sh-eth ee700000.ethernet: failed to initialise MDIO Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the network device") Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2933,7 +2933,7 @@ static int sh_eth_drv_probe(struct platf /* MDIO bus init */ ret = sh_mdio_init(mdp, pd); if (ret) { - dev_err(&ndev->dev, "failed to initialise MDIO\n"); + dev_err(&pdev->dev, "failed to initialise MDIO\n"); goto out_release; }