From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3308147-1523480070-2-3333377950456156207 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523480070; b=eI7yscNdfXFZFqGs/NfCTSsUnHTBjB4LPpN9t3BAlGThXhaWpH F1tOUoKJ9Pq+JnPbviejoaoEzcqc3WDDzVZN50V3WUl/u9IARkmVn6tztvevazto G+4t7+SkwM/K04kpdcgfbhIpkxlB6QecfyKTblpx5F25CaDh8Afl57sjAEn1+3cz uikKC7RQ66oVxUIlc/PfdVqtMpOY5PZZY4JkuJht+ukpxitXN/eid4oVkJQHhy6G ZgYo31ZIkEwFALCBKrcma38DVV0zqFGM6B8YsyadpVPo1SIEHVvpjEOfwOyBeSM1 5ezL/BzZVXEvOuB+Yl4ugumJDb52Nc2ynIdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=fm2; t=1523480070; bh=JCZuCRjclBTbSTntGtZTnCVdegYWhA kzenoNoQyxVQk=; b=M/1t4HKJGAn7CCMigu1L+MKuVIsh9d4RqFM+Z1PGMJCt34 phDTD5z0tbx362LtW1T4pzTuVg+paPFMrJS7slP7fwvkRjmPLkUotxNXB3O/HHU4 bg5/Bqa7M7uj7wADuiTYE7++5OmcydqP1rzBnwrsc0BY37c4d1XYPeHlqO+wKr2G oYNLMzvioATpmDkgxkr0Koy1JUVlcoHtLywPyZ86kcPLLMbqvQV9SFSclnrKukXC OJoIXBgecx8lBAWB28Mxn6OT8NtN6BDd/imokIquoM8xZCbst7eXXRvlqKQGfw+S IIpTDV/c8M0kYHZKMSspvPqk947LYBJ/YWq7vD0w== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfA51gIt1nkGAGtLJKClnV3csL/wll1rsEb5XVq6Az70wfeSO+E2Z/PVY8ho2zc9hxjbWXMtsQVOovF3gubBa6efFGCW6Cso9S4xwuoJbAb6oC2peP+HK r27r3P7ySSbDQJE5y1K6pvlGFIwBkUERMfGw91mkAaQ/PTmaUHS6OUzXDGFwHoPmBTf7MrdBWBWFIJGI2wKYHfUat/G00VhAInG0O0SnUD7QLB2V59IAlLQo X-CM-Analysis: v=2.3 cv=JLoVTfCb c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=Byx-y9mGAAAA:8 a=QyXUC8HyAAAA:8 a=yMhMjlubAAAA:8 a=ag1SF4gXAAAA:8 a=MK96HyGrqPNBv2a_Q8EA:9 a=QEXdDO2ut3YA:10 a=Yupwre4RP9_Eg_Bd0iYG:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932288AbeDKSpE (ORCPT ); Wed, 11 Apr 2018 14:45:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58456 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932269AbeDKSpB (ORCPT ); Wed, 11 Apr 2018 14:45:01 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Felipe Balbi , Sasha Levin Subject: [PATCH 4.4 038/190] usb: dwc3: keystone: check return value Date: Wed, 11 Apr 2018 20:34:44 +0200 Message-Id: <20180411183552.386387381@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183550.114495991@linuxfoundation.org> References: <20180411183550.114495991@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pan Bian [ Upstream commit 018047a1dba7636e1f7fdae2cc290a528991d648 ] Function devm_clk_get() returns an ERR_PTR when it fails. However, in function kdwc3_probe(), its return value is not checked, which may result in a bad memory access bug. This patch fixes the bug. Signed-off-by: Pan Bian Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/dwc3-keystone.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/dwc3/dwc3-keystone.c +++ b/drivers/usb/dwc3/dwc3-keystone.c @@ -112,6 +112,10 @@ static int kdwc3_probe(struct platform_d dev->dma_mask = &kdwc3_dma_mask; kdwc->clk = devm_clk_get(kdwc->dev, "usb"); + if (IS_ERR(kdwc->clk)) { + dev_err(kdwc->dev, "unable to get usb clock\n"); + return PTR_ERR(kdwc->clk); + } error = clk_prepare_enable(kdwc->clk); if (error < 0) {