From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3303684-1523479950-2-2214614817039452980 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523479949; b=cZWvipqYbhIxjbYMztneBI4zCTt4j8gHq9rxGhd27dbEBs9smZ 9KVkL+sqvg9HZ1lIvFo9AzlAIDgGotOWEF1GqyzsHp9Z1H+eB0J+/Rp9897YIHvJ zSpWdxDxzYA0K+8l0fv5RfLWiPWcP5NosR3i6KxvSIXKh2bDbgX5Q4qZy5hm2q7P nCGGEwK4r8K1BNIxw82ABNggPTJ57H5KK60SnjOCc5ivso2urAJyzLADc0xO8utG 3vB4MufoxTR4EkjcEI11VK44+riXH2Ci4FEgvXNrqCKBtPxD4PuEFIC+wFWc8DDs Amjdyf6hq6rNnaI8Ig4L6npLCZF4YUOKuLYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=fm2; t=1523479949; bh=ATL+wgK2OPVaDRbJAY5fiXWgjpSrm5 5qOE6yVU54ooU=; b=lTNI4c+mLWdgcsB0GLu34nrbcrvIJUP0KbcSqkk+AmA80r PzSDjyQJN7eZ6bDTEuJ8vTp6Ddl58QwdRx1nYsbfQSqXJYttBslsy0N9cjs/O304 UVZ/6VR+6KMhJXsI5PIa+J3ReDlUoA34tRuzObWf+yuTvUCPCPqkOiYYOe5mkL8E 6abftJm3UD+G6oKn3RxiZJ680TWQ0OgGZhgL+ej2SMILMhGyqXiYfZy3LnqhmsKY DuWDAJckNr+aXAaWXdXFjzFQxqzeKso9+LOuvEh94SIRWjWZy6vSguwOJMcTTcVd /qqIckIzm6if66AxIz07Rud69F+57Q2aDVbFBStw== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfOn5kOH7nRDsLMGhzCj7rxGjKuMibEsV3XHFIdITQ54u5ao+GStIjmYFhKIifDKgi39EnKxhLsP+54T5JT7ZJz6R3hYyz/BGny5DzFHbf7U0xoOZfqLz s+x+4zmfLoz1B+mRP2iOqYlnSq3Ffwkk+CP7mvkUFa1EpokRLht6N/t1CQhNCA5dyEs7nxknm1i8rUjFGJlR9QY/YNezl56cxYxZnX5ULmChC+uchAVsWaLv X-CM-Analysis: v=2.3 cv=FKU1Odgs c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=ag1SF4gXAAAA:8 a=yMhMjlubAAAA:8 a=Y-UeaLEg1Km7jvj322IA:9 a=QEXdDO2ut3YA:10 a=Yupwre4RP9_Eg_Bd0iYG:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754102AbeDKSp1 (ORCPT ); Wed, 11 Apr 2018 14:45:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58594 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755500AbeDKSp0 (ORCPT ); Wed, 11 Apr 2018 14:45:26 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alan Stern , Sasha Levin Subject: [PATCH 4.4 046/190] USB: ene_usb6250: fix SCSI residue overwriting Date: Wed, 11 Apr 2018 20:34:52 +0200 Message-Id: <20180411183552.878367495@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183550.114495991@linuxfoundation.org> References: <20180411183550.114495991@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alan Stern [ Upstream commit aa18c4b6e0e39bfb00af48734ec24bc189ac9909 ] In the ene_usb6250 sub-driver for usb-storage, the SCSI residue is not reported correctly. The residue is initialized to 0, but this value is overwritten whenever the driver sends firmware to the card reader before performing the current command. As a result, a valid READ or WRITE operation appears to have failed, causing the SCSI core to retry the command multiple times and eventually fail. This patch fixes the problem by resetting the SCSI residue to 0 after sending firmware to the device. Signed-off-by: Alan Stern Reported-and-tested-by: Andreas Hartmann Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/ene_ub6250.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/usb/storage/ene_ub6250.c +++ b/drivers/usb/storage/ene_ub6250.c @@ -1953,6 +1953,8 @@ static int ene_load_bincode(struct us_da bcb->CDB[0] = 0xEF; result = ene_send_scsi_cmd(us, FDIR_WRITE, buf, 0); + if (us->srb != NULL) + scsi_set_resid(us->srb, 0); info->BIN_FLAG = flag; kfree(buf);