From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3303684-1523479124-2-12019101218417006475 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523479124; b=kCCmrF9jPFqLsEB73ZeqZvHXe8mPLKddPO8Jy08bSWinTl8Lxd S43n4AsMm+gm8xQrHJfwiyjnx6uCYP1BNMEHS84/f//AGTeMYoXyMEJWcZAst/Y8 elwF9Fj6nERN22AzBTQLCVTrlyQFym2Tg8CZoHMLLgAFZG0MTJTKvJesOZOQm7Bv Ba41tM4v9TqBXj8UHoL5hw6yxmFlmmwh6R6CsPwhEL4VQ9I7f+yn8U9JriI98In2 yMWQUo//YvhX2KO2EjWCVNWbfieI6S7Ze3+fjnKnGixz9QSJPgT5uluZIgu7PRgY fVa9wCHXfD/ItmUuKAYII+o3z1Lg/uwBlqiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=fm2; t=1523479124; bh=jM9GmGUHa3PVGJL64E/FUi48G4WXyq eU3vYzckC+TEs=; b=k98gI2z8TIqd8tiVtEwNZZ9BHgYIZmoBFRD6UtQwT/jSc5 JWlFzy/aqyJSkL1pwcwBzo7hnXFJSTmaGKLNfBl1248Ntf0TMuCc0+QCxgka+yZx M2J5ZlvAXj0Ou51VkEgIe35EeK+PhsbaPYSUrtiWL9Hi/oJlg7HS0Gp9ue0idubt 2wfsA0q5o0gEoLUgMFfR9mc7tB/ar3ePIfA+upiG4iypyEybr1LJ21apkR3sVjsr QkZyuoEw1kEJOPA1OreYCk3PWVOdm39oVRy4ZKGoRH9LuM2zHf9dQHR1G2dOU4oQ 8CEq2eArHzP1qGE+foM1tLvlRB0bGMqAEJbRYGnQ== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfA/JJwj+CIBYUJjLpr6GjNdz6/hC76w1Y+MvN84gPDmVOenSkQ3CA4slXiw3LmO6mlJn6R+gihbB3CymcQvLuKuShj2vocW8B/0v19VWF3q5hE/PhT82 /kV9bF43el3vZiC/ShrcXwIxhsKDoP6x9r9jC2MhPIe65zQeUdolep3JqASf/M4Y+pFjV6VKv01ULkWrSuJNKKOmfm4AgyAlGmtC+7XaY4UPA+J4LZWT3S5p X-CM-Analysis: v=2.3 cv=FKU1Odgs c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=voM4FWlXAAAA:8 a=yMhMjlubAAAA:8 a=ag1SF4gXAAAA:8 a=Ofto3bmoRzo_owYi2x0A:9 a=QEXdDO2ut3YA:10 a=IC2XNlieTeVoXbcui8wp:22 a=Yupwre4RP9_Eg_Bd0iYG:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932398AbeDKSsQ (ORCPT ); Wed, 11 Apr 2018 14:48:16 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59608 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932379AbeDKSsP (ORCPT ); Wed, 11 Apr 2018 14:48:15 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Ellerman , Jeremy Kerr , Sasha Levin Subject: [PATCH 4.4 109/190] powerpc/spufs: Fix coredump of SPU contexts Date: Wed, 11 Apr 2018 20:35:55 +0200 Message-Id: <20180411183557.042470380@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183550.114495991@linuxfoundation.org> References: <20180411183550.114495991@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michael Ellerman [ Upstream commit 99acc9bede06bbb2662aafff51f5b9e529fa845e ] If a process dumps core while it has SPU contexts active then we have code to also dump information about the SPU contexts. Unfortunately it's been broken for 3 1/2 years, and we didn't notice. In commit 7b1f4020d0d1 ("spufs: get rid of dump_emit() wrappers") the nread variable was removed and rc used instead. That means when the loop exits successfully, rc has the number of bytes read, but it's then used as the return value for the function, which should return 0 on success. So fix it by setting rc = 0 before returning in the success case. Fixes: 7b1f4020d0d1 ("spufs: get rid of dump_emit() wrappers") Signed-off-by: Michael Ellerman Acked-by: Jeremy Kerr Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/platforms/cell/spufs/coredump.c | 2 ++ 1 file changed, 2 insertions(+) --- a/arch/powerpc/platforms/cell/spufs/coredump.c +++ b/arch/powerpc/platforms/cell/spufs/coredump.c @@ -174,6 +174,8 @@ static int spufs_arch_write_note(struct if (!dump_skip(cprm, roundup(cprm->written - total + sz, 4) - cprm->written)) goto Eio; + + rc = 0; out: free_page((unsigned long)buf); return rc;