From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3308147-1523479081-2-1522816587810557555 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523479080; b=to9WxjcIiiwPQ4G+fJFTdLm/52Th4QREAmQhew/5XuqtFChXQP VbcbAtYk5M75BW1jxqvoP5IHz95wRiWVaPxyBoy0d9jTp30jVBJbLpg/Z3naChGI 7Ob10CXByhFjtjBykbPEXZl3uJVMfzfJzJ5DjxQinzHGBSusq/i9khcpWRxKzjcl bLP/gFr+GHS57KtrUU5v2rLC6TwVbvK+kziUJ5wb+Pul4RPSwvR12fUcPFnoQNLW 7Ahh7jKR9CWl5zvEVra6g+Ay0IRytmfeWeR2rc14LOX+pbvX5I8g8L1t323uQdZl kINcnBdTdQVV39gRSt4D+mEwdcSBGTWXzvCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=fm2; t=1523479080; bh=kR/iJr5KbHbcxMdYeq2xtw2pgkCdCe pGQbeoUhWPEpg=; b=MTsZbXPIhs3r1cLCy4gKK5W+5u3G5UOsaFUAXtHLyb1KPV RA+/3mP09tPMvGeSkH9uquiCSjBvBWrERfzKb/Mmh64BwZqmXCILf6RDEmHXfkCq MCRVJU+ndN44Ubk52vtzKa4OFvw+9MmEAHEMFg+tNJ+nZFvsqEJpO0cG7WUSMTYh t3WJrcqCSOLLr46q7ZHnwR/B0khVHNEuT8pJKXQ5sJbSTEjPjFNvNgpFYOLEHgRk qgmEhKQQzWDIGbKGQV9yz9fVV3tE1cZ5r1GBntjGvAlivZ4AmkJgKHbQU3TDcyCM gpcPAtlppuUnJzqzwMUPQhmWwiZYh8iyhz0x2Asg== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfKChaR9yYyOrjGGMzjK/u3fJqRZa8xH+TWgfmwQ9r/LRRl0icrEwpshVNqQ4gBkIwKSLTHkjRK1NJXKdfCVHDzaCexD++4XszF1T1H4fQEbiBiMiXvEL a3qOmhbv7lN19zyJJIgN/mkt9VXAXfMXCjZa39CPaQCT6WJQJJMyty6SoTbU+I/EeNvjb3xf9mNydU062IpIvYhtB+GDN9s/MnaDwsa6BurZN0cfhd80uhge X-CM-Analysis: v=2.3 cv=JLoVTfCb c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=Byx-y9mGAAAA:8 a=J1Y8HTJGAAAA:8 a=yMhMjlubAAAA:8 a=ag1SF4gXAAAA:8 a=isfTqjNbOI2PD3KCteAA:9 a=QEXdDO2ut3YA:10 a=y1Q9-5lHfBjTkpIzbSAN:22 a=Yupwre4RP9_Eg_Bd0iYG:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756016AbeDKSsZ (ORCPT ); Wed, 11 Apr 2018 14:48:25 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59638 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756067AbeDKSsX (ORCPT ); Wed, 11 Apr 2018 14:48:23 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jia-Ju Bai , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 112/190] mISDN: Fix a sleep-in-atomic bug Date: Wed, 11 Apr 2018 20:35:58 +0200 Message-Id: <20180411183557.570399140@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183550.114495991@linuxfoundation.org> References: <20180411183550.114495991@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jia-Ju Bai [ Upstream commit 93818da5eed63fbc17b64080406ea53b86b23309 ] The driver may sleep under a read spin lock, and the function call path is: send_socklist (acquire the lock by read_lock) skb_copy(GFP_KERNEL) --> may sleep To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC". Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/isdn/mISDN/stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/isdn/mISDN/stack.c +++ b/drivers/isdn/mISDN/stack.c @@ -72,7 +72,7 @@ send_socklist(struct mISDN_sock_list *sl if (sk->sk_state != MISDN_BOUND) continue; if (!cskb) - cskb = skb_copy(skb, GFP_KERNEL); + cskb = skb_copy(skb, GFP_ATOMIC); if (!cskb) { printk(KERN_WARNING "%s no skb\n", __func__); break;