Re: [PATCH] image_types: use pigz to create .gz files

From: Denys Dmytriyenko <denis@denix.org>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] image_types: use pigz to create .gz files
Date: Wed, 11 Apr 2018 21:19:02 -0400	[thread overview]
Message-ID: <20180412011902.GG3228@denix.org> (raw)
In-Reply-To: <CAJTo0Lbon36HCngX2DFNtfrtZQP-nn2t=hp=_mAeHK-bYBpF6w@mail.gmail.com>

On Wed, Apr 11, 2018 at 05:07:38PM +0100, Burton, Ross wrote:
> Woud be interesting to see a benchmark of a full build from scratch
> with host gzip vs host pigz...

Is pigz so widely used now to be available in every Linux distro like gzip?

> On 11 April 2018 at 17:03, Khem Raj <raj.khem@gmail.com> wrote:
> > On Wed, Apr 11, 2018 at 6:36 AM, Burton, Ross <ross.burton@intel.com> wrote:
> >> Wouldn't that introduce a fun circular dependency if pigz-native needs
> >> to be built?
> >>
> >
> > interesting idea certainly, if it ends up with improvements in build
> > time, we could
> > add pigz to host dependencies.
> >
> >> Ross
> >>
> >> On 11 April 2018 at 11:53, Martin Jansa <martin.jansa@gmail.com> wrote:
> >>> What about using pigz for sstate-cache archives?
> >>>
> >>> On Tue, Apr 10, 2018 at 4:35 PM, Ross Burton <ross.burton@intel.com> wrote:
> >>>>
> >>>> Since pigz is no longer a drop-in replacement for gzip (oe-core 1624b7b)
> >>>> the
> >>>> image creation has been using gzip instead of pigz, despite still
> >>>> depending on
> >>>> pigz-native.  Fix this by invoking pigz explicitly.
> >>>>
> >>>> Signed-off-by: Ross Burton <ross.burton@intel.com>
> >>>> ---
> >>>>  meta/classes/image_types.bbclass | 2 +-
> >>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/meta/classes/image_types.bbclass
> >>>> b/meta/classes/image_types.bbclass
> >>>> index e872ae20982..00a00d318f4 100644
> >>>> --- a/meta/classes/image_types.bbclass
> >>>> +++ b/meta/classes/image_types.bbclass
> >>>> @@ -281,7 +281,7 @@ COMPRESSIONTYPES ?= ""
> >>>>
> >>>>  CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip sum md5sum sha1sum
> >>>> sha224sum sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2
> >>>> ${COMPRESSIONTYPES}"
> >>>>  CONVERSION_CMD_lzma = "lzma -k -f -7
> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
> >>>> -CONVERSION_CMD_gz = "gzip -f -9 -n -c
> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} >
> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz"
> >>>> +CONVERSION_CMD_gz = "pigz -f -9 -n -c
> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} >
> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz"
> >>>>  CONVERSION_CMD_bz2 = "pbzip2 -f -k
> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
> >>>>  CONVERSION_CMD_xz = "xz -f -k -c ${XZ_COMPRESSION_LEVEL} ${XZ_THREADS}
> >>>> --check=${XZ_INTEGRITY_CHECK} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} >
> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz"
> >>>>  CONVERSION_CMD_lz4 = "lz4 -9 -z -l
> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}
> >>>> ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.lz4"
> >>>> --
> >>>> 2.11.0
> >>>>
> >>>> --
> >>>> _______________________________________________
> >>>> Openembedded-core mailing list
> >>>> Openembedded-core@lists.openembedded.org
> >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >>>
> >>>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core