From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon. Date: Thu, 12 Apr 2018 11:14:46 +0200 Message-ID: <20180412111446.742450f0@bbrezillon> References: <20180409205813.7077-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id F088B6E4B9 for ; Thu, 12 Apr 2018 09:15:19 +0000 (UTC) In-Reply-To: <20180409205813.7077-1-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAgOSBBcHIgMjAxOCAxMzo1ODoxMyAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gU2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0 Lm5ldD4KPiBGaXhlczogNjUxMDFkOGM5MTA4ICgiZHJtL3ZjNDogRXhwb3NlIHBlcmZvcm1hbmNl IGNvdW50ZXJzIHRvIHVzZXJzcGFjZSIpCgpSZXZpZXdlZC1ieTogQm9yaXMgQnJlemlsbG9uIDxi b3Jpcy5icmV6aWxsb25AYm9vdGxpbi5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdmM0 L3ZjNF9kcnYuYyB8IDEgKwo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZHJ2LmMgYi9kcml2ZXJzL2dwdS9k cm0vdmM0L3ZjNF9kcnYuYwo+IGluZGV4IDk0Yjk5YzkwNDI1YS4uN2M5NWVkNWM1Y2FjIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3ZjNC92YzRfZHJ2LmMKPiBAQCAtMTMwLDYgKzEzMCw3IEBAIHN0YXRpYyB2b2lkIHZj NF9jbG9zZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4g IAlzdHJ1Y3QgdmM0X2ZpbGUgKnZjNGZpbGUgPSBmaWxlLT5kcml2ZXJfcHJpdjsKPiAgCj4gIAl2 YzRfcGVyZm1vbl9jbG9zZV9maWxlKHZjNGZpbGUpOwo+ICsJa2ZyZWUodmM0ZmlsZSk7Cj4gIH0K PiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgdm1fb3BlcmF0aW9uc19zdHJ1Y3QgdmM0X3ZtX29w cyA9IHsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbeDLJPV (ORCPT ); Thu, 12 Apr 2018 05:15:21 -0400 Received: from mail.bootlin.com ([62.4.15.54]:47620 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbeDLJPT (ORCPT ); Thu, 12 Apr 2018 05:15:19 -0400 Date: Thu, 12 Apr 2018 11:14:46 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon. Message-ID: <20180412111446.742450f0@bbrezillon> In-Reply-To: <20180409205813.7077-1-eric@anholt.net> References: <20180409205813.7077-1-eric@anholt.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Apr 2018 13:58:13 -0700 Eric Anholt wrote: > Signed-off-by: Eric Anholt > Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace") Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c > index 94b99c90425a..7c95ed5c5cac 100644 > --- a/drivers/gpu/drm/vc4/vc4_drv.c > +++ b/drivers/gpu/drm/vc4/vc4_drv.c > @@ -130,6 +130,7 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file) > struct vc4_file *vc4file = file->driver_priv; > > vc4_perfmon_close_file(vc4file); > + kfree(vc4file); > } > > static const struct vm_operations_struct vc4_vm_ops = {