All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tj@kernel.org" <tj@kernel.org>
To: "hch@lst.de" <hch@lst.de>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"00moses.alexander00@gmail.com" <00moses.alexander00@gmail.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH] block: Ensure that a request queue is dissociated from the cgroup controller
Date: Thu, 12 Apr 2018 07:07:15 -0700	[thread overview]
Message-ID: <20180412140715.GA793541@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180412135821.GZ793541@devbig577.frc2.facebook.com>

On Thu, Apr 12, 2018 at 06:58:21AM -0700, tj@kernel.org wrote:
> Cool, can we just factor out the queue lock from those drivers?  It's
> just really messy to be switching locks like we do in the cleanup
> path.

So, looking at a couple drivers, it looks like all we'd need is a
struct which contains a spinlock and a refcnt.  Switching the drivers
to use that is a bit tedious but straight-forward and the block layer
can simply put that struct on queue release.

Thanks.

-- 
tejun

  reply	other threads:[~2018-04-12 14:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12  1:58 [PATCH] block: Ensure that a request queue is dissociated from the cgroup controller Bart Van Assche
2018-04-12  4:20 ` Alexandru Moise
2018-04-12  4:32   ` Alexandru Moise
2018-04-12  4:22 ` Alexandru Moise
2018-04-12  5:34 ` Christoph Hellwig
2018-04-12 11:52   ` Bart Van Assche
2018-04-12 13:14     ` hch
2018-04-12 13:48       ` tj
2018-04-12 13:56         ` hch
2018-04-12 13:58           ` tj
2018-04-12 14:07             ` tj [this message]
2018-04-12 13:51 ` Tejun Heo
2018-04-12 14:09   ` Bart Van Assche
2018-04-12 15:37     ` Tejun Heo
2018-04-12 16:03       ` Bart Van Assche
2018-04-12 16:12         ` tj
2018-04-12 16:29           ` Bart Van Assche
2018-04-12 18:11             ` tj
2018-04-12 18:56               ` Bart Van Assche
2018-04-12 19:09                 ` tj
2018-04-12 22:40                   ` Bart Van Assche
2018-04-13 15:18                     ` tj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180412140715.GA793541@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=00moses.alexander00@gmail.com \
    --cc=Bart.VanAssche@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.