From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: [RFC 1/2] nfp: unlink the appropriate lock file
Date: Thu, 12 Apr 2018 18:22:07 -0400 [thread overview]
Message-ID: <20180412222208.11770-2-aconole@redhat.com> (raw)
In-Reply-To: <20180412222208.11770-1-aconole@redhat.com>
The nfpu_close needs to unlink the lock file associated with the
nfp descriptor, not lock file 0.
Fixes: d12206e00590 ("net/nfp: add NSP user space interface")
Cc: stable@dpdk.org
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
drivers/net/nfp/nfp_nfpu.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
index f11afef35..2ed985ff4 100644
--- a/drivers/net/nfp/nfp_nfpu.c
+++ b/drivers/net/nfp/nfp_nfpu.c
@@ -101,8 +101,12 @@ nfpu_open(struct rte_pci_device *pci_dev, nfpu_desc_t *desc, int nfp)
int
nfpu_close(nfpu_desc_t *desc)
{
+ char lockname[30];
+
rte_free(desc->nspu);
close(desc->lock);
- unlink("/var/lock/nfp0");
+
+ snprintf(lockname, sizeof(lockname), "/var/lock/nfp%d", desc->nfp);
+ unlink(lockname);
return 0;
}
--
2.14.3
next prev parent reply other threads:[~2018-04-12 22:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 22:22 [RFC 0/2] nfp driver fixes Aaron Conole
2018-04-12 22:22 ` Aaron Conole [this message]
2018-04-13 7:31 ` [RFC 1/2] nfp: unlink the appropriate lock file Alejandro Lucero
2018-04-13 13:24 ` Aaron Conole
2018-04-12 22:22 ` [RFC 2/2] nfp: allow for non-root user Aaron Conole
2018-04-13 7:37 ` Alejandro Lucero
2018-04-13 13:31 ` Aaron Conole
2018-04-13 15:31 ` Alejandro Lucero
2018-04-17 15:44 ` Alejandro Lucero
2018-04-17 15:54 ` Alejandro Lucero
2018-04-17 19:19 ` Aaron Conole
2018-04-18 10:53 ` Alejandro Lucero
2018-04-18 12:32 ` Aaron Conole
2018-04-19 6:05 ` Alejandro Lucero
2018-04-20 14:12 ` [dpdk-stable] " Ferruh Yigit
2018-04-20 14:56 ` Aaron Conole
2018-04-17 15:54 ` Thomas Monjalon
2018-04-17 16:24 ` Alejandro Lucero
2018-04-17 19:06 ` Thomas Monjalon
2018-04-13 7:26 ` [RFC 0/2] nfp driver fixes Alejandro Lucero
2018-04-13 13:23 ` Aaron Conole
2018-04-13 15:36 ` Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412222208.11770-2-aconole@redhat.com \
--to=aconole@redhat.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.