From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] pixiewps: new package
Date: Thu, 12 Apr 2018 23:42:22 +0200 [thread overview]
Message-ID: <20180412234222.1f239e48@windsurf> (raw)
In-Reply-To: <1523539131-9053-1-git-send-email-guillaume.bressaix@gmail.com>
Hello,
Thanks for this new version. I applied it, but after doing a number of
changes.
On Thu, 12 Apr 2018 15:18:51 +0200, Guillaume W. Bres wrote:
> Pixie WPS is a C based tool to audit networks
> against so called "Pixie Dust" attacks.
>
> Generic C package, easy to cross-compile,
> build tests passed for the 7 default toolchains.
>
> Sorry my previous submission was somehow corrupted.
> Tested on RPI1 & RPI3.
Changelog information should not go in the commit log, but...
> Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
> ---
... here.
> diff --git a/package/pixiewps/pixiewps.mk b/package/pixiewps/pixiewps.mk
> new file mode 100644
> index 0000000..746fa71
> --- /dev/null
> +++ b/package/pixiewps/pixiewps.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# pixiewps
> +#
> +################################################################################
> +
> +PIXIEWPS_VERSION = 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59
> +PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,$(PIXIEWPS_VERSION))
> +PIXIEWPS_LICENSE = GPL-2.0+
This was not correct, the license is GPL-3.0+
> +PIXIEWPS_LICENSE_FILES = LICENSE.md
> +
> +define PIXIEWPS_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) CC=$(TARGET_CC) -C $(@D)
> +endef
> +
> +define PIXIEWPS_INSTALL_TARGET_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) \
> + prefix=/usr -C $(@D)/$(PIXIEWPS_SUBDIR) install
prefix= doesn't have any effect, and the binary was installed in
usr/local/bin because of this. You should have used PREFIX= instead.
PIXIEWPS_SUBDIR was never defined anywhere, and in fact was not needed
at all.
I've fixed those issues and applied to master. Thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-12 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 13:18 [Buildroot] [PATCH 1/1] pixiewps: new package Guillaume W. Bres
2018-04-12 14:42 ` Baruch Siach
2018-04-12 21:42 ` Thomas Petazzoni [this message]
2018-04-13 8:00 ` Guillaume W. Bres
-- strict thread matches above, loose matches on Subject: below --
2018-04-12 9:42 Guillaume W. Bres
2018-04-12 11:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412234222.1f239e48@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.