From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator From: Vinod Koul Message-Id: <20180413040233.GJ6014@localhost> Date: Fri, 13 Apr 2018 09:32:33 +0530 To: Pierre-Yves MORDRET Cc: Maxime Coquelin , Alexandre Torgue , Dan Williams , M'boumba Cedric Madianga , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBBcHIgMTEsIDIwMTggYXQgMDQ6NDQ6MzlQTSArMDIwMCwgUGllcnJlLVl2ZXMgTU9S RFJFVCB3cm90ZToKCj4gIHN0cnVjdCBzdG0zMl9tZG1hX2Rlc2Mgewo+ICAJc3RydWN0IHZpcnRf ZG1hX2Rlc2MgdmRlc2M7Cj4gIAl1MzIgY2NyOwo+IC0Jc3RydWN0IHN0bTMyX21kbWFfaHdkZXNj ICpod2Rlc2M7Cj4gLQlkbWFfYWRkcl90IGh3ZGVzY19waHlzOwo+ICAJYm9vbCBjeWNsaWM7Cj4g IAl1MzIgY291bnQ7Cj4gKwlzdHJ1Y3Qgc3RtMzJfbWRtYV9kZXNjX25vZGUgbm9kZVtdOwoKc29t ZSBwcGwgdXNlIG5vZGVbMF0gZm9yIHRoaXMgYnV0IGkgdGhpbmsgZWl0aGVyIGlzIGZpbmUuLgoK PiAgc3RhdGljIHZvaWQgc3RtMzJfbWRtYV9kdW1wX2h3ZGVzYyhzdHJ1Y3Qgc3RtMzJfbWRtYV9j aGFuICpjaGFuLAo+IC0JCQkJICAgc3RydWN0IHN0bTMyX21kbWFfaHdkZXNjICpod2Rlc2MpCj4g KwkJCQkgICBzdHJ1Y3Qgc3RtMzJfbWRtYV9kZXNjX25vZGUgKm5vZGUpCj4gIHsKPiAtCWRldl9k YmcoY2hhbjJkZXYoY2hhbiksICJDVENSOiAgICAweCUwOHhcbiIsIGh3ZGVzYy0+Y3Rjcik7Cgo+ ICsJZGV2X2RiZyhjaGFuMmRldihjaGFuKSwgIkNUQ1I6ICAgIDB4JTA4eFxuIiwgbm9kZS0+aHdk ZXNjLT5jdGNyKTsKCnRoaXMgaXMgbm9pc2UgZm9yIHRoaXMgcGF0Y2ggYW5kIElJVUMgeW91IHNo b3VsZCBiZSBhYmxlIHRvIHBhc3MKbm9kZS0+aHdkZXNjIGFuZCBrZWVwIGZuIHNhbWU/Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Fri, 13 Apr 2018 09:32:33 +0530 Subject: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator In-Reply-To: <1523457879-9869-3-git-send-email-pierre-yves.mordret@st.com> References: <1523457879-9869-1-git-send-email-pierre-yves.mordret@st.com> <1523457879-9869-3-git-send-email-pierre-yves.mordret@st.com> Message-ID: <20180413040233.GJ6014@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote: > struct stm32_mdma_desc { > struct virt_dma_desc vdesc; > u32 ccr; > - struct stm32_mdma_hwdesc *hwdesc; > - dma_addr_t hwdesc_phys; > bool cyclic; > u32 count; > + struct stm32_mdma_desc_node node[]; some ppl use node[0] for this but i think either is fine.. > static void stm32_mdma_dump_hwdesc(struct stm32_mdma_chan *chan, > - struct stm32_mdma_hwdesc *hwdesc) > + struct stm32_mdma_desc_node *node) > { > - dev_dbg(chan2dev(chan), "CTCR: 0x%08x\n", hwdesc->ctcr); > + dev_dbg(chan2dev(chan), "CTCR: 0x%08x\n", node->hwdesc->ctcr); this is noise for this patch and IIUC you should be able to pass node->hwdesc and keep fn same? -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753244AbeDMD6H (ORCPT ); Thu, 12 Apr 2018 23:58:07 -0400 Received: from mga04.intel.com ([192.55.52.120]:1746 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbeDMD6F (ORCPT ); Thu, 12 Apr 2018 23:58:05 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,444,1517904000"; d="scan'208";a="220061837" Date: Fri, 13 Apr 2018 09:32:33 +0530 From: Vinod Koul To: Pierre-Yves MORDRET Cc: Maxime Coquelin , Alexandre Torgue , Dan Williams , "M'boumba Cedric Madianga" , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator Message-ID: <20180413040233.GJ6014@localhost> References: <1523457879-9869-1-git-send-email-pierre-yves.mordret@st.com> <1523457879-9869-3-git-send-email-pierre-yves.mordret@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1523457879-9869-3-git-send-email-pierre-yves.mordret@st.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote: > struct stm32_mdma_desc { > struct virt_dma_desc vdesc; > u32 ccr; > - struct stm32_mdma_hwdesc *hwdesc; > - dma_addr_t hwdesc_phys; > bool cyclic; > u32 count; > + struct stm32_mdma_desc_node node[]; some ppl use node[0] for this but i think either is fine.. > static void stm32_mdma_dump_hwdesc(struct stm32_mdma_chan *chan, > - struct stm32_mdma_hwdesc *hwdesc) > + struct stm32_mdma_desc_node *node) > { > - dev_dbg(chan2dev(chan), "CTCR: 0x%08x\n", hwdesc->ctcr); > + dev_dbg(chan2dev(chan), "CTCR: 0x%08x\n", node->hwdesc->ctcr); this is noise for this patch and IIUC you should be able to pass node->hwdesc and keep fn same? -- ~Vinod