From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Revert "xhci: plat: Register shutdown for xhci_plat" From: Greg Kroah-Hartman Message-Id: <20180413062128.GA22147@kroah.com> Date: Fri, 13 Apr 2018 08:21:28 +0200 To: Harsh Shandilya Cc: Greg Hackmann , Adam Wallis , Mathias Nyman , Badhri Jagan Sridharan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-ID: T24gRnJpLCBBcHIgMTMsIDIwMTggYXQgMDg6MTI6MzFBTSArMDUzMCwgSGFyc2ggU2hhbmRpbHlh IHdyb3RlOgo+IE9uIDEzIEFwcmlsIDIwMTggNTo1OTo1MSBBTSBJU1QsIEdyZWcgSGFja21hbm4g PGdoYWNrbWFubkBnb29nbGUuY29tPiB3cm90ZToKPiA+UGl4ZWwgMiBmaWVsZCB0ZXN0ZXJzIHJl cG9ydGVkIHRoYXQgd2hlbiB0aGV5IHRyaWVkIHRvIHJlYm9vdCB0aGVpcgo+ID5waG9uZXMgd2l0 aCBzb21lIFVTQiBkZXZpY2VzIHBsdWdnZWQgaW4sIHRoZSByZWJvb3Qgd291bGQgZ2V0IHdlZGdl ZAo+ID5hbmQKPiA+ZXZlbnR1YWxseSB0cmlnZ2VyIHdhdGNoZG9nIHJlc2V0LiAgT25jZSB0aGUg UGl4ZWwga2VybmVsIHRlYW0gZm91bmQgYQo+ID5yZWxpYWJsZSByZXBybyBjYXNlLCB0aGV5IG5h cnJvd2VkIGl0IGRvd24gdG8gdGhpcyBjb21taXQncyA0LjQueQo+ID5iYWNrcG9ydC4gIFJldmVy dGluZyB0aGUgY2hhbmdlIG1hZGUgdGhlIGlzc3VlIGdvIGF3YXkuCj4gCj4gQXJlIHlvdSBhbGxv d2VkIHRvIG1ha2UgdGhlIHJlcHJvIHN0ZXBzIHB1YmxpYz8gSSdtIHdyaXRpbmcgdGhpcyBmcm9t Cj4gYSB3YWxsZXllIGFuZCB3b3VsZCBiZSBncmF0ZWZ1bCBpZiBJIGNvdWxkIHRlc3QgZm9yIHRo aXMgaW4gdGhlCj4gbW9kaWZlZCB0cmVlIEknbSBydW5uaW5nIGF0bS4gIC0tIAoKSSB3YXMgdG9s ZCB0aGUgc3RlcHMgYXJlIHByZXR0eSBzaW1wbGU6CgktIHJlYm9vdCB0aGUgcGhvbmUgYSBsb3QK ZXZlbnR1YWxseSBpdCB3aWxsIGhhbmcuICBUaGVyZSdzIGEgZml4IGluIHRoZSBjb2RlIGF1cm9y YSBrZXJuZWwgdHJlZQpmb3IgdGhpcyB0aGF0IHRoZXkgbmV2ZXIgc2VudCB1cHN0cmVhbSBmb3Ig c29tZSBvZGQgcmVhc29uICh0aGV5IHNlbnQKdGhlIGZpcnN0IHBhdGNoLCB3aHkgbm90IHRoZSBz ZWNvbmQ/KQoKSSdsbCBnbyByZXZlcnQgdGhpcyBmb3Igbm93LCB0aGFua3MgZm9yIHRoZSBwYXRj aCEKCmdyZWcgay1oCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUg bGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8g bWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8v dmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 13 Apr 2018 08:21:28 +0200 From: Greg Kroah-Hartman To: Harsh Shandilya Cc: Greg Hackmann , Adam Wallis , Mathias Nyman , Badhri Jagan Sridharan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Revert "xhci: plat: Register shutdown for xhci_plat" Message-ID: <20180413062128.GA22147@kroah.com> References: <20180413002951.155762-1-ghackmann@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Apr 13, 2018 at 08:12:31AM +0530, Harsh Shandilya wrote: > On 13 April 2018 5:59:51 AM IST, Greg Hackmann wrote: > >Pixel 2 field testers reported that when they tried to reboot their > >phones with some USB devices plugged in, the reboot would get wedged > >and > >eventually trigger watchdog reset. Once the Pixel kernel team found a > >reliable repro case, they narrowed it down to this commit's 4.4.y > >backport. Reverting the change made the issue go away. > > Are you allowed to make the repro steps public? I'm writing this from > a walleye and would be grateful if I could test for this in the > modifed tree I'm running atm. -- I was told the steps are pretty simple: - reboot the phone a lot eventually it will hang. There's a fix in the code aurora kernel tree for this that they never sent upstream for some odd reason (they sent the first patch, why not the second?) I'll go revert this for now, thanks for the patch! greg k-h