From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator From: Vinod Koul Message-Id: <20180413100921.GM6014@localhost> Date: Fri, 13 Apr 2018 15:39:22 +0530 To: Geert Uytterhoeven Cc: Pierre-Yves MORDRET , Alexandre Torgue , Linux Kernel Mailing List , dmaengine@vger.kernel.org, Maxime Coquelin , M'boumba Cedric Madianga , Dan Williams , Linux ARM List-ID: T24gRnJpLCBBcHIgMTMsIDIwMTggYXQgMTA6Mzk6NDhBTSArMDIwMCwgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+IEhpIFZpbm9kLAo+IAo+IE9uIEZyaSwgQXByIDEzLCAyMDE4IGF0IDY6MDIg QU0sIFZpbm9kIEtvdWwgPHZpbm9kLmtvdWxAaW50ZWwuY29tPiB3cm90ZToKPiA+IE9uIFdlZCwg QXByIDExLCAyMDE4IGF0IDA0OjQ0OjM5UE0gKzAyMDAsIFBpZXJyZS1ZdmVzIE1PUkRSRVQgd3Jv dGU6Cj4gPgo+ID4+ICBzdHJ1Y3Qgc3RtMzJfbWRtYV9kZXNjIHsKPiA+PiAgICAgICBzdHJ1Y3Qg dmlydF9kbWFfZGVzYyB2ZGVzYzsKPiA+PiAgICAgICB1MzIgY2NyOwo+ID4+IC0gICAgIHN0cnVj dCBzdG0zMl9tZG1hX2h3ZGVzYyAqaHdkZXNjOwo+ID4+IC0gICAgIGRtYV9hZGRyX3QgaHdkZXNj X3BoeXM7Cj4gPj4gICAgICAgYm9vbCBjeWNsaWM7Cj4gPj4gICAgICAgdTMyIGNvdW50Owo+ID4+ ICsgICAgIHN0cnVjdCBzdG0zMl9tZG1hX2Rlc2Nfbm9kZSBub2RlW107Cj4gPgo+ID4gc29tZSBw cGwgdXNlIG5vZGVbMF0gZm9yIHRoaXMgYnV0IGkgdGhpbmsgZWl0aGVyIGlzIGZpbmUuLgo+IAo+ IG5vZGVbXSBpcyB0aGUgY29ycmVjdCBvbmUsIG5vZGVbMF0gbWF5IGhpZGUgZnV0dXJlIGJ1Z3Ms IGNmci4gY29tbWl0Cj4gYTE1ODUzMWYzYzkyNDY3ZCAoImdwaW86IDc0eDE2NDogRml4IGNyYXNo IGR1cmluZyAucmVtb3ZlKCkiKQoKWWVhaCBidXQgaXQgdGhpcyBjYXNlIGl0IGlzIHRoZSBsYXN0 IGVsZW1lbnQuIEJ1dCB5ZXMgaXQgaGVscHMgdG8gYXZvaWQgc3VjaAptaXN0YWtlcyBpbiBmdXR1 cmUuLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Fri, 13 Apr 2018 15:39:22 +0530 Subject: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator In-Reply-To: References: <1523457879-9869-1-git-send-email-pierre-yves.mordret@st.com> <1523457879-9869-3-git-send-email-pierre-yves.mordret@st.com> <20180413040233.GJ6014@localhost> Message-ID: <20180413100921.GM6014@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Apr 13, 2018 at 10:39:48AM +0200, Geert Uytterhoeven wrote: > Hi Vinod, > > On Fri, Apr 13, 2018 at 6:02 AM, Vinod Koul wrote: > > On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote: > > > >> struct stm32_mdma_desc { > >> struct virt_dma_desc vdesc; > >> u32 ccr; > >> - struct stm32_mdma_hwdesc *hwdesc; > >> - dma_addr_t hwdesc_phys; > >> bool cyclic; > >> u32 count; > >> + struct stm32_mdma_desc_node node[]; > > > > some ppl use node[0] for this but i think either is fine.. > > node[] is the correct one, node[0] may hide future bugs, cfr. commit > a158531f3c92467d ("gpio: 74x164: Fix crash during .remove()") Yeah but it this case it is the last element. But yes it helps to avoid such mistakes in future.. -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754147AbeDMKE4 (ORCPT ); Fri, 13 Apr 2018 06:04:56 -0400 Received: from mga02.intel.com ([134.134.136.20]:29491 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754118AbeDMKEz (ORCPT ); Fri, 13 Apr 2018 06:04:55 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,444,1517904000"; d="scan'208";a="46625565" Date: Fri, 13 Apr 2018 15:39:22 +0530 From: Vinod Koul To: Geert Uytterhoeven Cc: Pierre-Yves MORDRET , Alexandre Torgue , Linux Kernel Mailing List , dmaengine@vger.kernel.org, Maxime Coquelin , "M'boumba Cedric Madianga" , Dan Williams , Linux ARM Subject: Re: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator Message-ID: <20180413100921.GM6014@localhost> References: <1523457879-9869-1-git-send-email-pierre-yves.mordret@st.com> <1523457879-9869-3-git-send-email-pierre-yves.mordret@st.com> <20180413040233.GJ6014@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 13, 2018 at 10:39:48AM +0200, Geert Uytterhoeven wrote: > Hi Vinod, > > On Fri, Apr 13, 2018 at 6:02 AM, Vinod Koul wrote: > > On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote: > > > >> struct stm32_mdma_desc { > >> struct virt_dma_desc vdesc; > >> u32 ccr; > >> - struct stm32_mdma_hwdesc *hwdesc; > >> - dma_addr_t hwdesc_phys; > >> bool cyclic; > >> u32 count; > >> + struct stm32_mdma_desc_node node[]; > > > > some ppl use node[0] for this but i think either is fine.. > > node[] is the correct one, node[0] may hide future bugs, cfr. commit > a158531f3c92467d ("gpio: 74x164: Fix crash during .remove()") Yeah but it this case it is the last element. But yes it helps to avoid such mistakes in future.. -- ~Vinod