From: Steffen Maier <maier@linux.ibm.com>
To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Li Zefan <lizf@cn.fujitsu.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steffen Maier <maier@linux.ibm.com>
Subject: [PATCH 1/2] tracing/events: block: track and print if unplug was explicit or schedule
Date: Fri, 13 Apr 2018 15:07:17 +0200 [thread overview]
Message-ID: <20180413130719.22921-2-maier@linux.ibm.com> (raw)
In-Reply-To: <20180413130719.22921-1-maier@linux.ibm.com>
Just like blktrace distinguishes explicit and schedule by means of
BLK_TA_UNPLUG_IO and BLK_TA_UNPLUG_TIMER, actually make use of the
existing argument "explicit" to distinguish the two cases in the one
common tracepoint block_unplug.
Complements v2.6.39 commit 49cac01e1fa7 ("block: make unplug timer trace
event correspond to the schedule() unplug") and commit d9c978331790
("block: remove block_unplug_timer() trace point").
Signed-off-by: Steffen Maier <maier@linux.ibm.com>
---
include/trace/events/block.h | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/block.h b/include/trace/events/block.h
index 81b43f5bdf23..a13613d27cee 100644
--- a/include/trace/events/block.h
+++ b/include/trace/events/block.h
@@ -470,6 +470,11 @@ TRACE_EVENT(block_plug,
TP_printk("[%s]", __entry->comm)
);
+#define show_block_unplug_explicit(val) \
+ __print_symbolic(val, \
+ {false, "schedule"}, \
+ {true, "explicit"})
+
DECLARE_EVENT_CLASS(block_unplug,
TP_PROTO(struct request_queue *q, unsigned int depth, bool explicit),
@@ -478,15 +483,18 @@ DECLARE_EVENT_CLASS(block_unplug,
TP_STRUCT__entry(
__field( int, nr_rq )
+ __field( bool, explicit )
__array( char, comm, TASK_COMM_LEN )
),
TP_fast_assign(
__entry->nr_rq = depth;
+ __entry->explicit = explicit;
memcpy(__entry->comm, current->comm, TASK_COMM_LEN);
),
- TP_printk("[%s] %d", __entry->comm, __entry->nr_rq)
+ TP_printk("[%s] %d %s", __entry->comm, __entry->nr_rq,
+ show_block_unplug_explicit(__entry->explicit))
);
/**
--
2.13.5
next prev parent reply other threads:[~2018-04-13 13:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 13:07 [PATCH 0/2] tracing/events: block: bring more on a par with blktrace Steffen Maier
2018-04-13 13:07 ` Steffen Maier [this message]
2018-04-13 14:16 ` [PATCH 1/2] tracing/events: block: track and print if unplug was explicit or schedule Steven Rostedt
2018-04-13 13:07 ` [PATCH 2/2] tracing/events: block: dev_t via driver core for plug and unplug events Steffen Maier
2018-04-15 8:31 ` Greg Kroah-Hartman
2018-04-16 16:33 ` Steffen Maier
2018-04-16 16:33 ` Steffen Maier
2018-04-19 19:24 ` Omar Sandoval
2018-04-19 19:24 ` Omar Sandoval
2018-04-19 20:56 ` Bart Van Assche
2018-04-19 20:56 ` Bart Van Assche
2018-04-24 14:49 ` Steffen Maier
2018-04-24 14:49 ` Steffen Maier
2018-04-27 16:38 ` Bart Van Assche
2018-04-27 16:38 ` Bart Van Assche
2018-04-13 13:07 ` [RFC] tracing/events: block: also try to get dev_t via driver core for some events Steffen Maier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413130719.22921-2-maier@linux.ibm.com \
--to=maier@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.