From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Fri, 13 Apr 2018 17:52:08 +0200 Subject: DRM_UDL and GPU under Xserver In-Reply-To: <1523267150.5268.18.camel@synopsys.com> References: <1522924162.3779.16.camel@pengutronix.de> <1522926602.4587.10.camel@synopsys.com> <20180405134421.GV3881@phenom.ffwll.local> <1522953580.3977.10.camel@synopsys.com> <20180409083127.GL31310@phenom.ffwll.local> <1523264135.5268.14.camel@synopsys.com> <20180409091706.GU31310@phenom.ffwll.local> <1523267150.5268.18.camel@synopsys.com> List-ID: Message-ID: <20180413155208.GA31310@phenom.ffwll.local> To: linux-snps-arc@lists.infradead.org On Mon, Apr 09, 2018@09:45:51AM +0000, Alexey Brodkin wrote: > Hi Daniel, > > On Mon, 2018-04-09@11:17 +0200, Daniel Vetter wrote: > > On Mon, Apr 09, 2018@08:55:36AM +0000, Alexey Brodkin wrote: > > > Hi Daniel, > > > > > > On Mon, 2018-04-09@10:31 +0200, Daniel Vetter wrote: > > > > On Thu, Apr 05, 2018@06:39:41PM +0000, Alexey Brodkin wrote: > > > > > Hi Daniel, all, > > > > > > [snip] > > > > > > > > Ok it was quite some time ago so I forgot about that completely. > > > > > I really made one trivial change in xf86-video-armada: > > > > > ------------------------>8-------------------------- > > > > > --- a/src/armada_module.c > > > > > +++ b/src/armada_module.c > > > > > @@ -26,7 +26,7 @@ > > > > > #define ARMADA_NAME "armada" > > > > > #define ARMADA_DRIVER_NAME "armada" > > > > > > > > > > -#define DRM_MODULE_NAMES "armada-drm", "imx-drm" > > > > > +#define DRM_MODULE_NAMES "armada-drm", "imx-drm", "udl" > > > > > #define DRM_DEFAULT_BUS_ID NULL > > > > > ------------------------>8-------------------------- > > > > > > > > > > Otherwise Xserver fails on start which is expected given "imx-drm" is intentionally removed. > > > > > > Here I meant I explicitly disabled DRM_IMX in the kernel configuraion > > > so that it is not used in run-time. > > > > > > > You need to keep imx-drm around. And then light up the udl display using > > > > prime. Afaiui it should all just work (but with maybe a few disconnected > > > > outputs from imx-drm around that you don't need, but that's not a > > > > problem). > > > > > > And given my comment above I don't really see any difference between > > > DRM_IMX and DRM_UDL (except their HW implmentation which I guess should > > > not bother upper layers) so why do wee need to treat them differently? > > > > > > Most probably I'm missing something but my thought was if we have > > > 2 equally well supported KMS devices we may easily swap them and still > > > have resulting setup functional. > > > > armada is not a generic drm driver, but can only be used for armada-drm > > and imx-drm. You can't just use it with any drm device, for that you need > > a generic driver like -modesetting. > > But "armada" is the name of xf86 "driver" only which then uses true DRM_ETNAVIV > kernel driver. That's why I'm a bit confused. > > And from what I see DRM_ETNAVIV happily works with either DRM_xxx frame-buffer > device be it DRM_IMX or DRM_UDL. Names are irrelevant and often just historical accidents. Armada was origianlly only for armada, but then extended to support etnaviv 2d core, then extended to IMX. That the kernel properly share buffers between all of them is kinda orthogonal to what armada-the-X11-driver supports. Yes graphics is complicated, that's why touching and changing random stuff you don't fully understand is not a good idea :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: DRM_UDL and GPU under Xserver Date: Fri, 13 Apr 2018 17:52:08 +0200 Message-ID: <20180413155208.GA31310@phenom.ffwll.local> References: <1522924162.3779.16.camel@pengutronix.de> <1522926602.4587.10.camel@synopsys.com> <20180405134421.GV3881@phenom.ffwll.local> <1522953580.3977.10.camel@synopsys.com> <20180409083127.GL31310@phenom.ffwll.local> <1523264135.5268.14.camel@synopsys.com> <20180409091706.GU31310@phenom.ffwll.local> <1523267150.5268.18.camel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x234.google.com (mail-wr0-x234.google.com [IPv6:2a00:1450:400c:c0c::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34B2E6EB17 for ; Fri, 13 Apr 2018 15:52:13 +0000 (UTC) Received: by mail-wr0-x234.google.com with SMTP id q13so5903492wre.3 for ; Fri, 13 Apr 2018 08:52:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1523267150.5268.18.camel@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexey Brodkin Cc: "Jose.Abreu@synopsys.com" , "airlied@linux.ie" , "daniel.vetter@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "airlied@redhat.com" , "alexander.deucher@amd.com" , "daniel.vetter@intel.com" , "linux-snps-arc@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBcHIgMDksIDIwMTggYXQgMDk6NDU6NTFBTSArMDAwMCwgQWxleGV5IEJyb2RraW4g d3JvdGU6Cj4gSGkgRGFuaWVsLAo+IAo+IE9uIE1vbiwgMjAxOC0wNC0wOSBhdCAxMToxNyArMDIw MCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+IE9uIE1vbiwgQXByIDA5LCAyMDE4IGF0IDA4OjU1 OjM2QU0gKzAwMDAsIEFsZXhleSBCcm9ka2luIHdyb3RlOgo+ID4gPiBIaSBEYW5pZWwsCj4gPiA+ IAo+ID4gPiBPbiBNb24sIDIwMTgtMDQtMDkgYXQgMTA6MzEgKzAyMDAsIERhbmllbCBWZXR0ZXIg d3JvdGU6Cj4gPiA+ID4gT24gVGh1LCBBcHIgMDUsIDIwMTggYXQgMDY6Mzk6NDFQTSArMDAwMCwg QWxleGV5IEJyb2RraW4gd3JvdGU6Cj4gPiA+ID4gPiBIaSBEYW5pZWwsIGFsbCwKPiA+ID4gCj4g PiA+IFtzbmlwXQo+ID4gPiAKPiA+ID4gPiA+IE9rIGl0IHdhcyBxdWl0ZSBzb21lIHRpbWUgYWdv IHNvIEkgZm9yZ290IGFib3V0IHRoYXQgY29tcGxldGVseS4KPiA+ID4gPiA+IEkgcmVhbGx5IG1h ZGUgb25lIHRyaXZpYWwgY2hhbmdlIGluIHhmODYtdmlkZW8tYXJtYWRhOgo+ID4gPiA+ID4gLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tPjgtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiA+ ID4gLS0tIGEvc3JjL2FybWFkYV9tb2R1bGUuYwo+ID4gPiA+ID4gKysrIGIvc3JjL2FybWFkYV9t b2R1bGUuYwo+ID4gPiA+ID4gQEAgLTI2LDcgKzI2LDcgQEAKPiA+ID4gPiA+ICAjZGVmaW5lIEFS TUFEQV9OQU1FICAgICAgICAgICAgImFybWFkYSIKPiA+ID4gPiA+ICAjZGVmaW5lIEFSTUFEQV9E UklWRVJfTkFNRSAgICAgImFybWFkYSIKPiA+ID4gPiA+ICAKPiA+ID4gPiA+IC0jZGVmaW5lIERS TV9NT0RVTEVfTkFNRVMgICAgICAgImFybWFkYS1kcm0iLCAiaW14LWRybSIKPiA+ID4gPiA+ICsj ZGVmaW5lIERSTV9NT0RVTEVfTkFNRVMgICAgICAgImFybWFkYS1kcm0iLCAiaW14LWRybSIsICJ1 ZGwiCj4gPiA+ID4gPiAgI2RlZmluZSBEUk1fREVGQVVMVF9CVVNfSUQgICAgIE5VTEwKPiA+ID4g PiA+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLT44LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K PiA+ID4gPiA+IAo+ID4gPiA+ID4gT3RoZXJ3aXNlIFhzZXJ2ZXIgZmFpbHMgb24gc3RhcnQgd2hp Y2ggaXMgZXhwZWN0ZWQgZ2l2ZW4gImlteC1kcm0iIGlzIGludGVudGlvbmFsbHkgcmVtb3ZlZC4K PiA+ID4gCj4gPiA+IEhlcmUgSSBtZWFudCBJIGV4cGxpY2l0bHkgZGlzYWJsZWQgRFJNX0lNWCBp biB0aGUga2VybmVsIGNvbmZpZ3VyYWlvbgo+ID4gPiBzbyB0aGF0IGl0IGlzIG5vdCB1c2VkIGlu IHJ1bi10aW1lLgo+ID4gPiAKPiA+ID4gPiBZb3UgbmVlZCB0byBrZWVwIGlteC1kcm0gYXJvdW5k LiBBbmQgdGhlbiBsaWdodCB1cCB0aGUgdWRsIGRpc3BsYXkgdXNpbmcKPiA+ID4gPiBwcmltZS4g QWZhaXVpIGl0IHNob3VsZCBhbGwganVzdCB3b3JrIChidXQgd2l0aCBtYXliZSBhIGZldyBkaXNj b25uZWN0ZWQKPiA+ID4gPiBvdXRwdXRzIGZyb20gaW14LWRybSBhcm91bmQgdGhhdCB5b3UgZG9u J3QgbmVlZCwgYnV0IHRoYXQncyBub3QgYQo+ID4gPiA+IHByb2JsZW0pLgo+ID4gPiAKPiA+ID4g QW5kIGdpdmVuIG15IGNvbW1lbnQgYWJvdmUgSSBkb24ndCByZWFsbHkgc2VlIGFueSBkaWZmZXJl bmNlIGJldHdlZW4KPiA+ID4gRFJNX0lNWCBhbmQgRFJNX1VETCAoZXhjZXB0IHRoZWlyIEhXIGlt cGxtZW50YXRpb24gd2hpY2ggSSBndWVzcyBzaG91bGQKPiA+ID4gbm90IGJvdGhlciB1cHBlciBs YXllcnMpIHNvIHdoeSBkbyB3ZWUgbmVlZCB0byB0cmVhdCB0aGVtIGRpZmZlcmVudGx5Pwo+ID4g PiAKPiA+ID4gTW9zdCBwcm9iYWJseSBJJ20gbWlzc2luZyBzb21ldGhpbmcgYnV0IG15IHRob3Vn aHQgd2FzIGlmIHdlIGhhdmUKPiA+ID4gMiBlcXVhbGx5IHdlbGwgc3VwcG9ydGVkIEtNUyBkZXZp Y2VzIHdlIG1heSBlYXNpbHkgc3dhcCB0aGVtIGFuZCBzdGlsbAo+ID4gPiBoYXZlIHJlc3VsdGlu ZyBzZXR1cCBmdW5jdGlvbmFsLgo+ID4gCj4gPiBhcm1hZGEgaXMgbm90IGEgZ2VuZXJpYyBkcm0g ZHJpdmVyLCBidXQgY2FuIG9ubHkgYmUgdXNlZCBmb3IgYXJtYWRhLWRybQo+ID4gYW5kIGlteC1k cm0uIFlvdSBjYW4ndCBqdXN0IHVzZSBpdCB3aXRoIGFueSBkcm0gZGV2aWNlLCBmb3IgdGhhdCB5 b3UgbmVlZAo+ID4gYSBnZW5lcmljIGRyaXZlciBsaWtlIC1tb2Rlc2V0dGluZy4KPiAKPiBCdXQg ImFybWFkYSIgaXMgdGhlIG5hbWUgb2YgeGY4NiAiZHJpdmVyIiBvbmx5IHdoaWNoIHRoZW4gdXNl cyB0cnVlIERSTV9FVE5BVklWCj4ga2VybmVsIGRyaXZlci4gVGhhdCdzIHdoeSBJJ20gYSBiaXQg Y29uZnVzZWQuCj4gCj4gQW5kIGZyb20gd2hhdCBJIHNlZSBEUk1fRVROQVZJViBoYXBwaWx5IHdv cmtzIHdpdGggZWl0aGVyIERSTV94eHggZnJhbWUtYnVmZmVyCj4gZGV2aWNlIGJlIGl0IERSTV9J TVggb3IgRFJNX1VETC4KCk5hbWVzIGFyZSBpcnJlbGV2YW50IGFuZCBvZnRlbiBqdXN0IGhpc3Rv cmljYWwgYWNjaWRlbnRzLiBBcm1hZGEgd2FzCm9yaWdpYW5sbHkgb25seSBmb3IgYXJtYWRhLCBi dXQgdGhlbiBleHRlbmRlZCB0byBzdXBwb3J0IGV0bmF2aXYgMmQgY29yZSwKdGhlbiBleHRlbmRl ZCB0byBJTVguCgpUaGF0IHRoZSBrZXJuZWwgcHJvcGVybHkgc2hhcmUgYnVmZmVycyBiZXR3ZWVu IGFsbCBvZiB0aGVtIGlzIGtpbmRhCm9ydGhvZ29uYWwgdG8gd2hhdCBhcm1hZGEtdGhlLVgxMS1k cml2ZXIgc3VwcG9ydHMuCgpZZXMgZ3JhcGhpY3MgaXMgY29tcGxpY2F0ZWQsIHRoYXQncyB3aHkg dG91Y2hpbmcgYW5kIGNoYW5naW5nIHJhbmRvbSBzdHVmZgp5b3UgZG9uJ3QgZnVsbHkgdW5kZXJz dGFuZCBpcyBub3QgYSBnb29kIGlkZWEgOi0pCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=