From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v1 2/5] nvme: remove association between ctrl and keep-alive
Date: Fri, 13 Apr 2018 19:01:37 +0200 [thread overview]
Message-ID: <20180413170137.GB23178@lst.de> (raw)
In-Reply-To: <1523380689-17151-3-git-send-email-maxg@mellanox.com>
On Tue, Apr 10, 2018@08:18:06PM +0300, Max Gurtovoy wrote:
> Keep-alive mechanism is an admin queue property and
> should be activated/deactivated during admin queue
> creation/destruction.
On its own this patch looks bogus. You later fix this up but the move
really needs to be in one patch instead of splitting it in parts that
make things unusable inbetween.
Also please use your 74 or whatever chars available for the commit log,
please.
next prev parent reply other threads:[~2018-04-13 17:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 17:18 [PATCH v1 0/5] Fix keep-alive mechanism for fabrics Max Gurtovoy
2018-04-10 17:18 ` [PATCH v1 1/5] Revert "nvme: unexport nvme_start_keep_alive" Max Gurtovoy
2018-04-10 17:18 ` [PATCH v1 2/5] nvme: remove association between ctrl and keep-alive Max Gurtovoy
2018-04-13 17:01 ` Christoph Hellwig [this message]
2018-04-10 17:18 ` [PATCH v1 3/5] nvme-rdma: add keep-alive mechanism as admin_q property Max Gurtovoy
2018-04-10 17:18 ` [PATCH v1 4/5] nvme-fc: " Max Gurtovoy
2018-04-10 17:18 ` [PATCH 5/5] nvme-loop: " Max Gurtovoy
2018-04-11 13:04 ` [PATCH v1 0/5] Fix keep-alive mechanism for fabrics Sagi Grimberg
2018-04-11 13:38 ` Max Gurtovoy
2018-04-11 14:07 ` Sagi Grimberg
2018-04-11 14:40 ` Max Gurtovoy
2018-04-11 16:48 ` James Smart
2018-04-12 8:49 ` Max Gurtovoy
2018-04-12 12:34 ` Sagi Grimberg
2018-04-12 17:28 ` James Smart
2018-04-12 12:29 ` Sagi Grimberg
2018-04-12 13:32 ` Max Gurtovoy
2018-04-12 15:17 ` Sagi Grimberg
2018-04-12 16:43 ` Max Gurtovoy
2018-04-12 12:14 ` Sagi Grimberg
2018-04-12 12:18 ` Max Gurtovoy
2018-04-12 12:31 ` Sagi Grimberg
2018-04-13 17:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413170137.GB23178@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.