From: hch@lst.de (Christoph Hellwig)
Subject: [RFC PATCH 8/8] nvmet: add configfs interface for target passthru
Date: Fri, 13 Apr 2018 19:30:04 +0200 [thread overview]
Message-ID: <20180413173004.GC23674@lst.de> (raw)
In-Reply-To: <be832a05-3906-7087-30ed-f20784128272@deltatee.com>
On Fri, Mar 30, 2018@12:13:28PM -0600, Logan Gunthorpe wrote:
> I *really* dislike this interface. Not only is the "pt" directory
> confusing to the user, it's nearly identical to what a subsystem is. So
> as developers, if we want to add a config option to a subsystem we also
> have to add it to the equivalent pt. I've already seen one patch set
> that would be mutually exclusive to this only because of the
> configuration mess.
>
> I'd much rather see either a couple new attributes in the existing
> subsystem
Maybe. But how would you design it? Have a passthrough filed under
the subsystem that you can echo a controller name to? And then make
the exclusive vs creating namespaces?
> or some mechanism such that if you create a namespace that
> points to a controller (eg /dev/nvme1) it takes it as though you're
> trying to pass through the whole NVMe device. (The code would need to
> ensure that a passthrough subsystem configured this way could only have
> exactly one namespace.)
Ugg. Hell no! Way too much magic.
next prev parent reply other threads:[~2018-04-13 17:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 6:57 [RFC PATCH 0/8] nvmet: implement target passthru commands support Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 1/8] nvme-core: add new interfaces Chaitanya Kulkarni
2018-03-30 17:48 ` Logan Gunthorpe
2018-04-02 23:25 ` Chaitanya Kulkarni
2018-04-04 11:52 ` Sagi Grimberg
2018-04-13 17:27 ` Christoph Hellwig
2018-03-30 6:57 ` [RFC PATCH 2/8] nvme-core: export existing ctrl and ns interfaces Chaitanya Kulkarni
2018-04-04 11:59 ` Sagi Grimberg
2018-03-30 6:57 ` [RFC PATCH 3/8] nvmet: add passthru members in target subsys Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 4/8] nvmet: use const values for id-ctrl Chaitanya Kulkarni
2018-03-30 18:50 ` Logan Gunthorpe
2018-04-02 23:27 ` Chaitanya Kulkarni
2018-04-13 17:28 ` Christoph Hellwig
2018-03-30 6:57 ` [RFC PATCH 5/8] nvmet: export nvmet_add_async_event api Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 6/8] nvmet: add target passthru command support Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 7/8] nvmet: integrate passthru code with target core Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 8/8] nvmet: add configfs interface for target passthru Chaitanya Kulkarni
2018-03-30 18:13 ` Logan Gunthorpe
2018-04-03 0:13 ` Chaitanya Kulkarni
2018-04-03 3:21 ` Logan Gunthorpe
2018-04-13 17:30 ` Christoph Hellwig [this message]
2018-04-13 17:37 ` Logan Gunthorpe
2018-04-13 21:50 ` Stephen Bates
2018-03-30 17:46 ` [RFC PATCH 0/8] nvmet: implement target passthru commands support Logan Gunthorpe
2018-04-02 23:23 ` Chaitanya Kulkarni
2018-04-04 11:44 ` Sagi Grimberg
2018-04-13 17:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413173004.GC23674@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.