From: Laura Abbott <labbott@redhat.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>
Cc: Laura Abbott <labbott@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: [PATCH] x86/xen: Remove use of VLAs
Date: Fri, 13 Apr 2018 15:11:46 -0700 [thread overview]
Message-ID: <20180413221146.28476-1-labbott@redhat.com> (raw)
There's an ongoing effort to remove VLAs[1] from the kernel to eventually
turn on -Wvla. The few VLAs in use have an upper bound based on a size
of 64K. This doesn't produce an excessively large stack so just switch
the upper bound.
[1] https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
arch/x86/xen/enlighten_pv.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index c36d23aa6c35..d96a5a535cbb 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -421,8 +421,7 @@ static void xen_load_gdt(const struct desc_ptr *dtr)
{
unsigned long va = dtr->address;
unsigned int size = dtr->size + 1;
- unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE);
- unsigned long frames[pages];
+ unsigned long frames[DIV_ROUND_UP(SZ_64K, PAGE_SIZE)];
int f;
/*
@@ -470,8 +469,7 @@ static void __init xen_load_gdt_boot(const struct desc_ptr *dtr)
{
unsigned long va = dtr->address;
unsigned int size = dtr->size + 1;
- unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE);
- unsigned long frames[pages];
+ unsigned long frames[DIV_ROUND_UP(SZ_64K, PAGE_SIZE)];
int f;
/*
--
2.14.3
next reply other threads:[~2018-04-13 22:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 22:11 Laura Abbott [this message]
2018-04-14 2:55 ` [PATCH] x86/xen: Remove use of VLAs David Brown
2018-04-14 3:43 ` Laura Abbott
2018-04-14 3:43 ` Laura Abbott
2018-04-14 2:55 ` David Brown
2018-04-16 8:11 ` Juergen Gross
2018-04-16 8:11 ` Juergen Gross
2018-04-16 9:40 ` Ingo Molnar
2018-04-16 9:40 ` Ingo Molnar
2018-04-16 13:27 ` Boris Ostrovsky
2018-04-17 7:16 ` Juergen Gross
2018-04-17 23:33 ` Laura Abbott
2018-04-17 23:33 ` Laura Abbott
2018-04-17 23:40 ` Boris Ostrovsky
2018-04-17 23:40 ` Boris Ostrovsky
2018-04-17 7:16 ` Juergen Gross
2018-04-16 13:27 ` Boris Ostrovsky
-- strict thread matches above, loose matches on Subject: below --
2018-04-13 22:11 Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413221146.28476-1-labbott@redhat.com \
--to=labbott@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.