✗ Fi.CI.CHECKPATCH: warning for drm: Add generic fbdev emulation

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: drm: Add generic fbdev emulation
URL   : https://patchwork.freedesktop.org/series/41713/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
81446b0d0a5c drm: provide management functions for drm_file
60830bd79f28 drm/file: Don't set master on in-kernel clients
cc4b5605be11 drm/fb-helper: No need to cache rotation and sw_rotations
714bf7eb3f72 drm/fb-helper: Remove drm_fb_helper_debug_enter/leave()
a9fd09042c1e drm/fb-helper: dpms_legacy(): Only set on connectors in use
a3df7c91a4e7 drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()
-:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#84: FILE: drivers/gpu/drm/drm_atomic.c:2122:
+		new_conn_state = drm_atomic_get_connector_state(state,
+							    set->connectors[i]);

total: 0 errors, 0 warnings, 1 checks, 413 lines checked
2c5762e457a0 drm: Begin an API for in-kernel clients
-:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

-:199: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'modeset' - possible side-effects?
#199: FILE: include/drm/drm_client.h:41:
+#define drm_client_display_for_each_modeset(modeset, display) \
+	for (modeset = display->modesets; modeset->crtc; modeset++)

total: 0 errors, 1 warnings, 1 checks, 171 lines checked
71f15d3943b3 drm/fb-helper: Use struct drm_client_display
89961006fcc4 drm/fb-helper: Move modeset commit code to drm_client
-:132: WARNING:LONG_LINE: line over 100 characters
#132: FILE: drivers/gpu/drm/drm_client.c:224:
+		if (drm_client_display_panel_rotation(mode_set->connectors[0], primary, &rotation)) {

-:148: WARNING:LONG_LINE: line over 100 characters
#148: FILE: drivers/gpu/drm/drm_client.c:240:
+			struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, crtc);

-:251: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#251: FILE: drivers/gpu/drm/drm_client.c:343:
+			drm_object_property_set_value(&connector->base,
+				dev->mode_config.dpms_property, dpms_mode);

total: 0 errors, 2 warnings, 1 checks, 506 lines checked
719d6d0d7abf drm/connector: Add drm_connector_has_preferred_mode/pick_cmdline_mode()
-:218: WARNING:LONG_LINE: line over 100 characters
#218: FILE: drivers/gpu/drm/drm_fb_helper.c:1980:
+			modes[i] = drm_connector_has_preferred_mode(fb_helper_conn->connector, width, height);

total: 0 errors, 1 warnings, 0 checks, 263 lines checked
44ea371420ed drm/connector: Add connector array functions
2713f41fa8a7 drm/i915: Add drm_driver->initial_client_display callback
-:359: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#359: FILE: include/drm/drm_drv.h:575:
+	struct drm_client_display *(*initial_client_display)(struct drm_device *dev,
+					unsigned int width, unsigned int height);

total: 0 errors, 0 warnings, 1 checks, 309 lines checked
2ba3ab46560f drm/fb-helper: Remove struct drm_fb_helper_crtc
85e36ecc105f drm/fb-helper: Remove struct drm_fb_helper_connector
-:485: WARNING:LONG_LINE: line over 100 characters
#485: FILE: drivers/gpu/drm/drm_fb_helper.c:1735:
+				      connector->base.id, connector->tile_group ? connector->tile_group->id : 0);

-:494: WARNING:LONG_LINE: line over 100 characters
#494: FILE: drivers/gpu/drm/drm_fb_helper.c:1740:
+			modes[i] = list_first_entry_or_null(&connector->modes, struct drm_display_mode, head);

total: 0 errors, 2 warnings, 0 checks, 662 lines checked
96d053114bea drm/fb-helper: Move modeset config code to drm_client
b5e0fd91d06a drm: Make ioctls available for in-kernel clients
-:265: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#265: FILE: drivers/gpu/drm/drm_ioc32.c:888:
+	err = drm_ioctl_kernel(file, drm_mode_addfb2_ioctl, &req64,
 				DRM_CONTROL_ALLOW|DRM_UNLOCKED);

-:278: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#278: FILE: drivers/gpu/drm/drm_ioctl.c:638:
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB2, drm_mode_addfb2_ioctl, DRM_CONTROL_ALLOW|DRM_UNLOCKED),
 	                                                                             ^

-:279: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#279: FILE: drivers/gpu/drm/drm_ioctl.c:639:
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_RMFB, drm_mode_rmfb_ioctl, DRM_CONTROL_ALLOW|DRM_UNLOCKED),
 	                                                                         ^

total: 0 errors, 0 warnings, 3 checks, 250 lines checked
485cb25f026f drm/client: Bail out if there's a DRM master
ef429a8df150 drm/client: Make the display modes available to clients
c68e1bc590f2 drm/client: Finish the in-kernel client API
-:943: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#943: FILE: include/drm/drm_device.h:79:
+	struct mutex clientlist_mutex;

total: 0 errors, 0 warnings, 1 checks, 879 lines checked
9f9e987688eb drm/prime: Don't pin module on export for in-kernel clients
63ae31620111 drm/fb-helper: Add drm_fb_helper_fb_open/release()
312ecf074c7e drm/fb-helper: Add generic fbdev emulation
0d0077bf0537 drm: Add DRM device registered notifier
5cd701e1286b drm/client: Hack: Add bootsplash
-:39: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

-:94: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#94: FILE: drivers/gpu/drm/client/drm_bootsplash.c:36:
+static int drm_bootsplash_keyboard_notifier_call(struct notifier_block *blk,
+				  unsigned long code, void *_param)

total: 0 errors, 1 warnings, 1 checks, 311 lines checked
50d6c1c0bbaa drm/client: Hack: Add DRM VT console client
-:40: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

-:93: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#93: FILE: drivers/gpu/drm/client/drm_vtcon.c:40:
+	struct mutex lock;

-:541: WARNING:LONG_LINE: line over 100 characters
#541: FILE: drivers/gpu/drm/client/drm_vtcon.c:488:
+		memmove(drm_vtcon_vc->text_buf, drm_vtcon_vc->text_buf + vc->vc_cols, count * sizeof(u16));

total: 0 errors, 2 warnings, 1 checks, 804 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx