From: Jonathan Cameron <jic23@kernel.org>
To: Stefan Popa <stefan.popa@analog.com>
Cc: <Michael.Hennerich@analog.com>, <lars@metafoo.de>,
<knaack.h@gmx.de>, <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] iio:dac:ad5686: Style fixes no functional changes
Date: Sun, 15 Apr 2018 19:11:34 +0100 [thread overview]
Message-ID: <20180415191134.0bb81d86@archlinux> (raw)
In-Reply-To: <1523447511-13059-1-git-send-email-stefan.popa@analog.com>
On Wed, 11 Apr 2018 14:51:51 +0300
Stefan Popa <stefan.popa@analog.com> wrote:
> This patch fixes some indentation issues and does not modify the
> functionality of the driver.
>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
I'll try unwinding it this time, but please make absolutely
sure you don't reply to an existing series with a new series.
The patches are displayed in my email account, weirdly nested
and interleaved out of order.
Much nicer to have a new separate series!
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it,
Thanks,
Jonathan
> ---
> Changes v2:
> - Nothing changed, just follow the patch set version.
> Changes v3:
> - Nothing changed, just follow the patch set version.
>
> drivers/iio/dac/ad5686.c | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
> index 20254df..f7f975c 100644
> --- a/drivers/iio/dac/ad5686.c
> +++ b/drivers/iio/dac/ad5686.c
> @@ -24,7 +24,7 @@
> #define AD5686_ADDR(x) ((x) << 16)
> #define AD5686_CMD(x) ((x) << 20)
>
> -#define AD5686_ADDR_DAC(chan) (0x1 << (chan))
> +#define AD5686_ADDR_DAC(chan) (0x1 << (chan))
> #define AD5686_ADDR_ALL_DAC 0xF
>
> #define AD5686_CMD_NOOP 0x0
> @@ -137,7 +137,7 @@ static const char * const ad5686_powerdown_modes[] = {
> };
>
> static int ad5686_get_powerdown_mode(struct iio_dev *indio_dev,
> - const struct iio_chan_spec *chan)
> + const struct iio_chan_spec *chan)
> {
> struct ad5686_state *st = iio_priv(indio_dev);
>
> @@ -145,7 +145,8 @@ static int ad5686_get_powerdown_mode(struct iio_dev *indio_dev,
> }
>
> static int ad5686_set_powerdown_mode(struct iio_dev *indio_dev,
> - const struct iio_chan_spec *chan, unsigned int mode)
> + const struct iio_chan_spec *chan,
> + unsigned int mode)
> {
> struct ad5686_state *st = iio_priv(indio_dev);
>
> @@ -163,17 +164,19 @@ static const struct iio_enum ad5686_powerdown_mode_enum = {
> };
>
> static ssize_t ad5686_read_dac_powerdown(struct iio_dev *indio_dev,
> - uintptr_t private, const struct iio_chan_spec *chan, char *buf)
> + uintptr_t private, const struct iio_chan_spec *chan, char *buf)
> {
> struct ad5686_state *st = iio_priv(indio_dev);
>
> return sprintf(buf, "%d\n", !!(st->pwr_down_mask &
> - (0x3 << (chan->channel * 2))));
> + (0x3 << (chan->channel * 2))));
> }
>
> static ssize_t ad5686_write_dac_powerdown(struct iio_dev *indio_dev,
> - uintptr_t private, const struct iio_chan_spec *chan, const char *buf,
> - size_t len)
> + uintptr_t private,
> + const struct iio_chan_spec *chan,
> + const char *buf,
> + size_t len)
> {
> bool readin;
> int ret;
> @@ -221,10 +224,10 @@ static int ad5686_read_raw(struct iio_dev *indio_dev,
> }
>
> static int ad5686_write_raw(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan,
> - int val,
> - int val2,
> - long mask)
> + struct iio_chan_spec const *chan,
> + int val,
> + int val2,
> + long mask)
> {
> struct ad5686_state *st = iio_priv(indio_dev);
> int ret;
prev parent reply other threads:[~2018-04-15 18:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 13:55 [PATCH 1/3] iio:dac:ad5686: Style fixes no functional changes Stefan Popa
2018-03-30 13:55 ` Stefan Popa
2018-03-30 13:55 ` [PATCH 2/3] iio:dac:ad5686: Add AD5672R/AD5676/AD5676R/AD5684R/AD5685R/AD5686R support Stefan Popa
2018-03-30 13:55 ` Stefan Popa
2018-04-06 15:19 ` Jonathan Cameron
2018-04-06 15:19 ` Jonathan Cameron
2018-04-10 15:57 ` [PATCH v2 2/6] iio:dac:ad5686: Add support for various number of channels Stefan Popa
2018-04-11 11:52 ` [PATCH v3 3/7] " Stefan Popa
2018-04-15 18:16 ` Jonathan Cameron
2018-04-10 15:57 ` [PATCH v2 3/6] iio:dac:ad5686: Add support for AD5685R Stefan Popa
2018-04-11 11:52 ` [PATCH v3 4/7] " Stefan Popa
2018-04-15 18:20 ` Jonathan Cameron
2018-04-10 15:57 ` [PATCH v2 4/6] iio:dac:ad5686: Add AD5672R/76/76R/84R/86R support Stefan Popa
2018-04-11 11:53 ` [PATCH v3 5/7] " Stefan Popa
2018-04-15 18:23 ` Jonathan Cameron
2018-04-10 15:56 ` [PATCH v2 1/6] iio:dac:ad5686: Style fixes no functional changes Stefan Popa
2018-04-11 11:51 ` [PATCH v3 1/7] " Stefan Popa
2018-04-15 18:11 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180415191134.0bb81d86@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.