All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] alsa-lib: bump to version 1.1.6
Date: Sun, 15 Apr 2018 21:37:40 +0200	[thread overview]
Message-ID: <20180415213740.1afeebf2@windsurf.numericable.fr> (raw)
In-Reply-To: <20180413072825.14512-1-joerg.krause@embedded.rocks>

Hello,

On Fri, 13 Apr 2018 09:28:24 +0200, J?rg Krause wrote:
> Regenerate patches using git as patch 0002 didn't applied and the others were
> fuzzy.
> 
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>

I've applied, but I had to fix a few things in the patches. See below.

> diff --git a/package/alsa-lib/0001-no-mmu.patch b/package/alsa-lib/0001-no-mmu.patch
> index 2ae0f67158..0114e29d64 100644
> --- a/package/alsa-lib/0001-no-mmu.patch
> +++ b/package/alsa-lib/0001-no-mmu.patch
> @@ -1,14 +1,27 @@
> +From fac9e178f0d221c33efa579f54f6456156570088 Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?J=C3=B6rg=20Krause?= <joerg.krause@embedded.rocks>

First, it's better to keep the original authorship. I.e me for patch
0001, Sonic Zhang for patch 0002, and Thomas DS for patch 0003. You can
do this by using --author="..."

> +Date: Fri, 13 Apr 2018 09:02:37 +0200
> +Subject: [PATCH 1/3] no mmu

I guess you've chosen those titles so that the name of the patch file
generated by git format-patch remains the same. But I don't think
that's really a requirement (that it stays the same) and a better
commit title is more important I believe. Therefore, I've changed the
title to "Don't use fork(= on noMMU platforms", which was already in
the commit log.

Also, you should use "git format-patch -N" when generating patch series
that go in packages, to avoid the 1/3, 2/3 and 3/3 numbering.

BTW, what about trying to submit those patches upstream ?

Anyway, as said above, I've applied to master after adjusting the
patches. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-04-15 19:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13  7:28 [Buildroot] [PATCH 1/2] alsa-lib: bump to version 1.1.6 Jörg Krause
2018-04-13  7:28 ` [Buildroot] [PATCH 2/2] alsa-utils: bump version to 1.1.6 Jörg Krause
2018-04-15 19:37   ` Thomas Petazzoni
2018-04-15 19:37 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180415213740.1afeebf2@windsurf.numericable.fr \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.