From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Alan Cox <alan@llwyncelyn.cymru>, Dan Williams <dcbw@redhat.com>,
Jiri Prchal <jiri.prchal@aksignal.cz>,
Jiri Slaby <jslaby@suse.cz>, Marcel Partap <mpartap@gmx.net>,
Merlijn Wajer <merlijn@wizzup.org>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Michael Scott <michael.scott@linaro.org>,
Peter Hurley <peter@hurleysoftware.com>,
Russ Gorby <russ.gorby@intel.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 1/2] tty: n_gsm: Fix long delays with control frame timeouts in ADM mode
Date: Mon, 16 Apr 2018 10:44:39 +0200 [thread overview]
Message-ID: <20180416084439.GA5489@amd> (raw)
In-Reply-To: <20180413002415.GC5700@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]
> Do you have phy-mapphone-mdm6600 loaded? That is still needed to
> configure all the boot mode pins for the modem so it is usable..
> The UART will then work also without ohci-platform, just the
> USB PHY is disabled without ohci-platform.
>
> I have these in my .config:
> CONFIG_SERIAL_8250_OMAP=y
> CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP=y
> CONFIG_PHY_MAPPHONE_MDM6600=m
> CONFIG_N_GSM=m
>
> And then the two patches from $subject thread. I just tried
> it with today's mainline kernel and it's still working for
> me.
>
> Maybe you're missing some related patch though if usingv4.16?
>
> 984c7706ff18 ("ARM: dts: omap4-droid4: Configure uart1 pins")
> e5b9fd7bdeb5 ("ARM: dts: omap4-droid4: Configure MDM6600 USB PHY")
> fdd192037fce ("ARM: dts: omap4-droid4: Fix USB PHY port naming")
> bca809d8183c ("ARM: omap2plus_defconfig: Enable MDM6600 USB PHY")
> 077e1cde78c3 ("ARM: omap2plus_defconfig: Enable 8250_OMAP"
>
> So maybe you're still using CONFIG_SERIAL_OMAP=y instead of
> CONFIG_SERIAL_8250_OMAP=y?
Ahha, so first I missed two of the patches, and second, I was not
patient enough. I was stopping my test after first or second
error. Now I get... so I guess it works for me.
Thanks!
For the series:
Tested-by: Pavel Machek <pavel@ucw.cz>
Pavel
user@devuan:/my/droid4-ngsm$ sudo ./droid4-ngsm
Starting ngsm..
Testing ngsm..
Could not open /dev/gsmtty1: Level 2 halted
Trying to start ngsm again: Level 2 halted
Starting ngsm..
Testing ngsm..
Could not open /dev/gsmtty1: Level 2 halted
Trying to start ngsm again: Level 2 halted
Starting ngsm..
Testing ngsm..
Could not open /dev/gsmtty1: Level 2 halted
Trying to start ngsm again: Level 2 halted
Starting ngsm..
Testing ngsm..
Could not open /dev/gsmtty1: Level 2 halted
Trying to start ngsm again: Level 2 halted
Starting ngsm..
Testing ngsm..
1> U0000AT+CFUN?
1<
Enable speaker phone..
2> U0001AT+EACC=3,0
2<
2> U0002AT+CMUT=0
2<
2> U0003AT+NREC=1
2<
2> U0004AT+CLVL=6
2<
Started ngsm, press Ctrl-C to exit when done
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-04-16 8:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 17:19 [PATCH 1/2] tty: n_gsm: Fix long delays with control frame timeouts in ADM mode Tony Lindgren
2018-04-07 17:19 ` Tony Lindgren
2018-04-07 17:19 ` [PATCH 2/2] tty: n_gsm: Fix DLCI handling for ADM mode if debug & 2 is not set Tony Lindgren
2018-04-07 17:19 ` Tony Lindgren
2018-04-08 9:02 ` [PATCH 1/2] tty: n_gsm: Fix long delays with control frame timeouts in ADM mode Pavel Machek
2018-04-08 16:50 ` Tony Lindgren
2018-04-08 19:06 ` Pavel Machek
2018-04-08 23:57 ` Tony Lindgren
2018-04-09 10:54 ` Pavel Machek
2018-04-09 13:42 ` Tony Lindgren
2018-04-10 11:09 ` Pavel Machek
2018-04-10 13:43 ` Tony Lindgren
2018-04-12 21:24 ` Pavel Machek
2018-04-13 0:24 ` Tony Lindgren
2018-04-16 8:44 ` Pavel Machek [this message]
2018-04-16 14:47 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416084439.GA5489@amd \
--to=pavel@ucw.cz \
--cc=alan@llwyncelyn.cymru \
--cc=dcbw@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiri.prchal@aksignal.cz \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=michael.scott@linaro.org \
--cc=michael@amarulasolutions.com \
--cc=mpartap@gmx.net \
--cc=peter@hurleysoftware.com \
--cc=russ.gorby@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.