From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [3/3] x86/MCE/AMD: Get address from already initialized block From: Johannes Hirte Message-Id: <20180416115624.GA1543@probook> Date: Mon, 16 Apr 2018 13:56:25 +0200 To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, bp@suse.de, tony.luck@intel.com, x86@kernel.org List-ID: T24gMjAxOCBBcHIgMTQsIEpvaGFubmVzIEhpcnRlIHdyb3RlOgo+IE9uIDIwMTggRmViIDAxLCBZ YXplbiBHaGFubmFtIHdyb3RlOgo+ID4gRnJvbTogWWF6ZW4gR2hhbm5hbSA8eWF6ZW4uZ2hhbm5h bUBhbWQuY29tPgo+ID4gCj4gPiBUaGUgYmxvY2sgYWRkcmVzcyBpcyBzYXZlZCBhZnRlciB0aGUg YmxvY2sgaXMgaW5pdGlhbGl6ZWQgd2hlbgo+ID4gdGhyZXNob2xkX2luaXRfZGV2aWNlKCkgaXMg Y2FsbGVkLgo+ID4gCj4gPiBVc2UgdGhlIHNhdmVkIGJsb2NrIGFkZHJlc3MsIGlmIGF2YWlsYWJs ZSwgcmF0aGVyIHRoYW4gdHJ5aW5nIHRvCj4gPiByZWRpc2NvdmVyIGl0Lgo+ID4gCj4gPiBXZSBj YW4gYXZvaWQgc29tZSAqb25fY3B1KCkgY2FsbHMgaW4gdGhlIGluaXQgcGF0aCB0aGF0IHdpbGwg Y2F1c2UgYQo+ID4gY2FsbCB0cmFjZSB3aGVuIHJlc3VtaW5nIGZyb20gc3VzcGVuZC4KPiA+IAo+ ID4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIDQuMTQueAo+ID4gU2lnbmVkLW9mZi1i eTogWWF6ZW4gR2hhbm5hbSA8eWF6ZW4uZ2hhbm5hbUBhbWQuY29tPgo+ID4gLS0tCj4gPiAgYXJj aC94ODYva2VybmVsL2NwdS9tY2hlY2svbWNlX2FtZC5jIHwgMTUgKysrKysrKysrKysrKysrCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBh L2FyY2gveDg2L2tlcm5lbC9jcHUvbWNoZWNrL21jZV9hbWQuYyBiL2FyY2gveDg2L2tlcm5lbC9j cHUvbWNoZWNrL21jZV9hbWQuYwo+ID4gaW5kZXggYmY1M2I0NTQ5YTE3Li44YzRmOGYzMGM3Nzkg MTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9tY2VfYW1kLmMKPiA+ ICsrKyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvbWNoZWNrL21jZV9hbWQuYwo+ID4gQEAgLTQzNiw2 ICs0MzYsMjEgQEAgc3RhdGljIHUzMiBnZXRfYmxvY2tfYWRkcmVzcyh1bnNpZ25lZCBpbnQgY3B1 LCB1MzIgY3VycmVudF9hZGRyLCB1MzIgbG93LCB1MzIgaGkKPiA+ICB7Cj4gPiAgCXUzMiBhZGRy ID0gMCwgb2Zmc2V0ID0gMDsKPiA+ICAKPiA+ICsJaWYgKChiYW5rID49IG1jYV9jZmcuYmFua3Mp IHx8IChibG9jayA+PSBOUl9CTE9DS1MpKQo+ID4gKwkJcmV0dXJuIGFkZHI7Cj4gPiArCj4gPiAr CS8qIEdldCBhZGRyZXNzIGZyb20gYWxyZWFkeSBpbml0aWFsaXplZCBibG9jay4gKi8KPiA+ICsJ aWYgKHBlcl9jcHUodGhyZXNob2xkX2JhbmtzLCBjcHUpKSB7Cj4gPiArCQlzdHJ1Y3QgdGhyZXNo b2xkX2JhbmsgKmJhbmtwID0gcGVyX2NwdSh0aHJlc2hvbGRfYmFua3MsIGNwdSlbYmFua107Cj4g PiArCj4gPiArCQlpZiAoYmFua3AgJiYgYmFua3AtPmJsb2Nrcykgewo+ID4gKwkJCXN0cnVjdCB0 aHJlc2hvbGRfYmxvY2sgKmJsb2NrcCA9ICZiYW5rcC0+YmxvY2tzW2Jsb2NrXTsKPiA+ICsKPiA+ ICsJCQlpZiAoYmxvY2twKQo+ID4gKwkJCQlyZXR1cm4gYmxvY2twLT5hZGRyZXNzOwo+ID4gKwkJ fQo+ID4gKwl9Cj4gPiArCj4gPiAgCWlmIChtY2VfZmxhZ3Muc21jYSkgewo+ID4gIAkJaWYgKHNt Y2FfZ2V0X2JhbmtfdHlwZShiYW5rKSA9PSBTTUNBX1JFU0VSVkVEKQo+ID4gIAkJCXJldHVybiBh ZGRyOwo+ID4gLS0gCj4gPiAyLjE0LjEKPiAKPiBJIGhhdmUgYSBLQVNBTjogc2xhYi1vdXQtb2Yt Ym91bmRzLCBhbmQgZ2l0IGJpc2VjdCBwb2ludHMgbWUgdG8gdGhpcwo+IGNoYW5nZToKPiAKPiBB cHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ID09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQo+IEFwciAxMyAwMDo0MDoz MiBwcm9ib29rIGtlcm5lbDogQlVHOiBLQVNBTjogc2xhYi1vdXQtb2YtYm91bmRzIGluIGdldF9i bG9ja19hZGRyZXNzLmlzcmEuMysweDFlOS8weDUyMAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29r IGtlcm5lbDogUmVhZCBvZiBzaXplIDQgYXQgYWRkciBmZmZmODgwM2YxNjVkZGY0IGJ5IHRhc2sg c3dhcHBlci8wLzEKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6IAo+IEFwciAxMyAw MDo0MDozMiBwcm9ib29rIGtlcm5lbDogQ1BVOiAxIFBJRDogMSBDb21tOiBzd2FwcGVyLzAgTm90 IHRhaW50ZWQgNC4xNi4wLTEwNzU3LWc0Y2E4YmE0Y2NmZjkgIzUzMgo+IEFwciAxMyAwMDo0MDoz MiBwcm9ib29rIGtlcm5lbDogSGFyZHdhcmUgbmFtZTogSFAgSFAgUHJvQm9vayA2NDUgRzIvODBG RSwgQklPUyBONzcgVmVyLiAwMS4xMiAxMi8xOS8yMDE3Cj4gQXByIDEzIDAwOjQwOjMyIHByb2Jv b2sga2VybmVsOiBDYWxsIFRyYWNlOgo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDog IGR1bXBfc3RhY2srMHg1Yi8weDhiCj4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAg PyBnZXRfYmxvY2tfYWRkcmVzcy5pc3JhLjMrMHgxZTkvMHg1MjAKPiBBcHIgMTMgMDA6NDA6MzIg cHJvYm9vayBrZXJuZWw6ICBwcmludF9hZGRyZXNzX2Rlc2NyaXB0aW9uKzB4NjUvMHgyNzAKPiBB cHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IGdldF9ibG9ja19hZGRyZXNzLmlzcmEu MysweDFlOS8weDUyMAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogIGthc2FuX3Jl cG9ydCsweDIzMi8weDM1MAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogIGdldF9i bG9ja19hZGRyZXNzLmlzcmEuMysweDFlOS8weDUyMAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29r IGtlcm5lbDogID8ga29iamVjdF9pbml0X2FuZF9hZGQrMHhkZS8weDEzMAo+IEFwciAxMyAwMDo0 MDozMiBwcm9ib29rIGtlcm5lbDogID8gZ2V0X25hbWUrMHgzOTAvMHgzOTAKPiBBcHIgMTMgMDA6 NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IGthc2FuX3VucG9pc29uX3NoYWRvdysweDMwLzB4NDAK PiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IGthc2FuX2ttYWxsb2MrMHhhMC8w eGQwCj4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAgYWxsb2NhdGVfdGhyZXNob2xk X2Jsb2NrcysweDEyYy8weGM2MAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogID8g a29iamVjdF9hZGRfaW50ZXJuYWwrMHg4MDAvMHg4MDAKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9v ayBrZXJuZWw6ICA/IGdldF9ibG9ja19hZGRyZXNzLmlzcmEuMysweDUyMC8weDUyMAo+IEFwciAx MyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogID8ga2FzYW5fa21hbGxvYysweGEwLzB4ZDAKPiBB cHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICBtY2VfdGhyZXNob2xkX2NyZWF0ZV9kZXZp Y2UrMHgzNWIvMHg5OTAKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IGluaXRf c3BlY2lhbF9pbm9kZSsweDFkMC8weDIzMAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5l bDogIHRocmVzaG9sZF9pbml0X2RldmljZSsweDk4LzB4YTcKPiBBcHIgMTMgMDA6NDA6MzIgcHJv Ym9vayBrZXJuZWw6ICA/IG1jaGVja192ZW5kb3JfaW5pdF9zZXZlcml0eSsweDQzLzB4NDMKPiBB cHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICBkb19vbmVfaW5pdGNhbGwrMHg3Ni8weDMw Ywo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogID8gdHJhY2VfZXZlbnRfcmF3X2V2 ZW50X2luaXRjYWxsX2ZpbmlzaCsweDE5MC8weDE5MAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29r IGtlcm5lbDogID8ga2FzYW5fdW5wb2lzb25fc2hhZG93KzB4Yi8weDQwCj4gQXByIDEzIDAwOjQw OjMyIHByb2Jvb2sga2VybmVsOiAgPyBrYXNhbl91bnBvaXNvbl9zaGFkb3crMHgzMC8weDQwCj4g QXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAga2VybmVsX2luaXRfZnJlZWFibGUrMHgz ZDYvMHg0NzEKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IHJlc3RfaW5pdCsw eGYwLzB4ZjAKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICBrZXJuZWxfaW5pdCsw eGEvMHgxMjAKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IHJlc3RfaW5pdCsw eGYwLzB4ZjAKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICByZXRfZnJvbV9mb3Jr KzB4MjIvMHg0MAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDoKPiBBcHIgMTMgMDA6 NDA6MzIgcHJvYm9vayBrZXJuZWw6IEFsbG9jYXRlZCBieSB0YXNrIDE6Cj4gQXByIDEzIDAwOjQw OjMyIHByb2Jvb2sga2VybmVsOiAga2FzYW5fa21hbGxvYysweGEwLzB4ZDAKPiBBcHIgMTMgMDA6 NDA6MzIgcHJvYm9vayBrZXJuZWw6ICBrbWVtX2NhY2hlX2FsbG9jX3RyYWNlKzB4ZjMvMHgxZjAK PiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICBhbGxvY2F0ZV90aHJlc2hvbGRfYmxv Y2tzKzB4MWJjLzB4YzYwCj4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAgbWNlX3Ro cmVzaG9sZF9jcmVhdGVfZGV2aWNlKzB4MzViLzB4OTkwCj4gQXByIDEzIDAwOjQwOjMyIHByb2Jv b2sga2VybmVsOiAgdGhyZXNob2xkX2luaXRfZGV2aWNlKzB4OTgvMHhhNwo+IEFwciAxMyAwMDo0 MDozMiBwcm9ib29rIGtlcm5lbDogIGRvX29uZV9pbml0Y2FsbCsweDc2LzB4MzBjCj4gQXByIDEz IDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAga2VybmVsX2luaXRfZnJlZWFibGUrMHgzZDYvMHg0 NzEKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICBrZXJuZWxfaW5pdCsweGEvMHgx MjAKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICByZXRfZnJvbV9mb3JrKzB4MjIv MHg0MAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogCj4gQXByIDEzIDAwOjQwOjMy IHByb2Jvb2sga2VybmVsOiBGcmVlZCBieSB0YXNrIDA6Cj4gQXByIDEzIDAwOjQwOjMyIHByb2Jv b2sga2VybmVsOiAoc3RhY2sgaXMgbm90IGF2YWlsYWJsZSkKPiBBcHIgMTMgMDA6NDA6MzIgcHJv Ym9vayBrZXJuZWw6IAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogVGhlIGJ1Z2d5 IGFkZHJlc3MgYmVsb25ncyB0byB0aGUgb2JqZWN0IGF0IGZmZmY4ODAzZjE2NWRkODAKPiAgd2hp Y2ggYmVsb25ncyB0byB0aGUgY2FjaGUga21hbGxvYy0xMjggb2Ygc2l6ZSAxMjgKPiBBcHIgMTMg MDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6IFRoZSBidWdneSBhZGRyZXNzIGlzIGxvY2F0ZWQgMTE2 IGJ5dGVzIGluc2lkZSBvZgo+ICAxMjgtYnl0ZSByZWdpb24gW2ZmZmY4ODAzZjE2NWRkODAsIGZm ZmY4ODAzZjE2NWRlMDApCj4gIEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogVGhlIGJ1 Z2d5IGFkZHJlc3MgYmVsb25ncyB0byB0aGUgcGFnZToKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9v ayBrZXJuZWw6IHBhZ2U6ZmZmZmVhMDAwZmM1OTc0MCBjb3VudDoxIG1hcGNvdW50OjAgbWFwcGlu ZzowMDAwMDAwMDAwMDAwMDAwIGluZGV4OjB4MAo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtl cm5lbDogZmxhZ3M6IDB4MjAwMDAwMDAwMDAwMDEwMChzbGFiKQo+IEFwciAxMyAwMDo0MDozMiBw cm9ib29rIGtlcm5lbDogcmF3OiAyMDAwMDAwMDAwMDAwMTAwIDAwMDAwMDAwMDAwMDAwMDAgMDAw MDAwMDAwMDAwMDAwMCAwMDAwMDAwMTgwMTUwMDE1Cj4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sg a2VybmVsOiByYXc6IGRlYWQwMDAwMDAwMDAxMDAgZGVhZDAwMDAwMDAwMDIwMCBmZmZmODgwM2Yz NDAzMzQwIDAwMDAwMDAwMDAwMDAwMDAKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6 IHBhZ2UgZHVtcGVkIGJlY2F1c2U6IGthc2FuOiBiYWQgYWNjZXNzIGRldGVjdGVkCj4gQXByIDEz IDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJu ZWw6IE1lbW9yeSBzdGF0ZSBhcm91bmQgdGhlIGJ1Z2d5IGFkZHJlc3M6Cj4gQXByIDEzIDAwOjQw OjMyIHByb2Jvb2sga2VybmVsOiAgZmZmZjg4MDNmMTY1ZGM4MDogZmMgZmMgZmMgZmMgZmMgZmMg ZmMgZmMgMDAgMDAgMDAgMDAgMDAgMDAgMDAgMDAKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBr ZXJuZWw6ICBmZmZmODgwM2YxNjVkZDAwOiAwMCAwMCAwMCAwMCAwMCAwMCAwMCBmYyBmYyBmYyBm YyBmYyBmYyBmYyBmYyBmYwo+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogPmZmZmY4 ODAzZjE2NWRkODA6IDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIGZjIGZj IGZjCj4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgo+IEFwciAxMyAwMDo0 MDozMiBwcm9ib29rIGtlcm5lbDogIGZmZmY4ODAzZjE2NWRlMDA6IGZjIGZjIGZjIGZjIGZjIGZj IGZjIGZjIGZjIGZjIGZjIGZjIGZjIGZjIGZjIGZjCj4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sg a2VybmVsOiAgZmZmZjg4MDNmMTY1ZGU4MDogZmMgZmMgZmMgZmMgZmMgZmMgZmMgZmMgZmMgZmMg ZmMgZmMgZmMgZmMgZmMgZmMKPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ID09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQo+IAoKUHV0dGluZyB0aGUgd2hvbGUgY2hhY2hpbmcgcGFydCB1bmRlciB0aGUKCmlmICht Y2VfZmxhZ3Muc21jYSkgeyAKCnNvbHZlZCB0aGUgaXNzdWUgb24gbXkgQ2Fycml6by4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754603AbeDPL4k (ORCPT ); Mon, 16 Apr 2018 07:56:40 -0400 Received: from freki.datenkhaos.de ([81.7.17.101]:52964 "EHLO freki.datenkhaos.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754156AbeDPL4j (ORCPT ); Mon, 16 Apr 2018 07:56:39 -0400 Date: Mon, 16 Apr 2018 13:56:25 +0200 From: Johannes Hirte To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, bp@suse.de, tony.luck@intel.com, x86@kernel.org Subject: Re: [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block Message-ID: <20180416115624.GA1543@probook> References: <20180201184813.82253-1-Yazen.Ghannam@amd.com> <20180201184813.82253-3-Yazen.Ghannam@amd.com> <20180414004230.GA2033@probook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180414004230.GA2033@probook> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018 Apr 14, Johannes Hirte wrote: > On 2018 Feb 01, Yazen Ghannam wrote: > > From: Yazen Ghannam > > > > The block address is saved after the block is initialized when > > threshold_init_device() is called. > > > > Use the saved block address, if available, rather than trying to > > rediscover it. > > > > We can avoid some *on_cpu() calls in the init path that will cause a > > call trace when resuming from suspend. > > > > Cc: # 4.14.x > > Signed-off-by: Yazen Ghannam > > --- > > arch/x86/kernel/cpu/mcheck/mce_amd.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c > > index bf53b4549a17..8c4f8f30c779 100644 > > --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c > > +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c > > @@ -436,6 +436,21 @@ static u32 get_block_address(unsigned int cpu, u32 current_addr, u32 low, u32 hi > > { > > u32 addr = 0, offset = 0; > > > > + if ((bank >= mca_cfg.banks) || (block >= NR_BLOCKS)) > > + return addr; > > + > > + /* Get address from already initialized block. */ > > + if (per_cpu(threshold_banks, cpu)) { > > + struct threshold_bank *bankp = per_cpu(threshold_banks, cpu)[bank]; > > + > > + if (bankp && bankp->blocks) { > > + struct threshold_block *blockp = &bankp->blocks[block]; > > + > > + if (blockp) > > + return blockp->address; > > + } > > + } > > + > > if (mce_flags.smca) { > > if (smca_get_bank_type(bank) == SMCA_RESERVED) > > return addr; > > -- > > 2.14.1 > > I have a KASAN: slab-out-of-bounds, and git bisect points me to this > change: > > Apr 13 00:40:32 probook kernel: ================================================================== > Apr 13 00:40:32 probook kernel: BUG: KASAN: slab-out-of-bounds in get_block_address.isra.3+0x1e9/0x520 > Apr 13 00:40:32 probook kernel: Read of size 4 at addr ffff8803f165ddf4 by task swapper/0/1 > Apr 13 00:40:32 probook kernel: > Apr 13 00:40:32 probook kernel: CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.16.0-10757-g4ca8ba4ccff9 #532 > Apr 13 00:40:32 probook kernel: Hardware name: HP HP ProBook 645 G2/80FE, BIOS N77 Ver. 01.12 12/19/2017 > Apr 13 00:40:32 probook kernel: Call Trace: > Apr 13 00:40:32 probook kernel: dump_stack+0x5b/0x8b > Apr 13 00:40:32 probook kernel: ? get_block_address.isra.3+0x1e9/0x520 > Apr 13 00:40:32 probook kernel: print_address_description+0x65/0x270 > Apr 13 00:40:32 probook kernel: ? get_block_address.isra.3+0x1e9/0x520 > Apr 13 00:40:32 probook kernel: kasan_report+0x232/0x350 > Apr 13 00:40:32 probook kernel: get_block_address.isra.3+0x1e9/0x520 > Apr 13 00:40:32 probook kernel: ? kobject_init_and_add+0xde/0x130 > Apr 13 00:40:32 probook kernel: ? get_name+0x390/0x390 > Apr 13 00:40:32 probook kernel: ? kasan_unpoison_shadow+0x30/0x40 > Apr 13 00:40:32 probook kernel: ? kasan_kmalloc+0xa0/0xd0 > Apr 13 00:40:32 probook kernel: allocate_threshold_blocks+0x12c/0xc60 > Apr 13 00:40:32 probook kernel: ? kobject_add_internal+0x800/0x800 > Apr 13 00:40:32 probook kernel: ? get_block_address.isra.3+0x520/0x520 > Apr 13 00:40:32 probook kernel: ? kasan_kmalloc+0xa0/0xd0 > Apr 13 00:40:32 probook kernel: mce_threshold_create_device+0x35b/0x990 > Apr 13 00:40:32 probook kernel: ? init_special_inode+0x1d0/0x230 > Apr 13 00:40:32 probook kernel: threshold_init_device+0x98/0xa7 > Apr 13 00:40:32 probook kernel: ? mcheck_vendor_init_severity+0x43/0x43 > Apr 13 00:40:32 probook kernel: do_one_initcall+0x76/0x30c > Apr 13 00:40:32 probook kernel: ? trace_event_raw_event_initcall_finish+0x190/0x190 > Apr 13 00:40:32 probook kernel: ? kasan_unpoison_shadow+0xb/0x40 > Apr 13 00:40:32 probook kernel: ? kasan_unpoison_shadow+0x30/0x40 > Apr 13 00:40:32 probook kernel: kernel_init_freeable+0x3d6/0x471 > Apr 13 00:40:32 probook kernel: ? rest_init+0xf0/0xf0 > Apr 13 00:40:32 probook kernel: kernel_init+0xa/0x120 > Apr 13 00:40:32 probook kernel: ? rest_init+0xf0/0xf0 > Apr 13 00:40:32 probook kernel: ret_from_fork+0x22/0x40 > Apr 13 00:40:32 probook kernel: > Apr 13 00:40:32 probook kernel: Allocated by task 1: > Apr 13 00:40:32 probook kernel: kasan_kmalloc+0xa0/0xd0 > Apr 13 00:40:32 probook kernel: kmem_cache_alloc_trace+0xf3/0x1f0 > Apr 13 00:40:32 probook kernel: allocate_threshold_blocks+0x1bc/0xc60 > Apr 13 00:40:32 probook kernel: mce_threshold_create_device+0x35b/0x990 > Apr 13 00:40:32 probook kernel: threshold_init_device+0x98/0xa7 > Apr 13 00:40:32 probook kernel: do_one_initcall+0x76/0x30c > Apr 13 00:40:32 probook kernel: kernel_init_freeable+0x3d6/0x471 > Apr 13 00:40:32 probook kernel: kernel_init+0xa/0x120 > Apr 13 00:40:32 probook kernel: ret_from_fork+0x22/0x40 > Apr 13 00:40:32 probook kernel: > Apr 13 00:40:32 probook kernel: Freed by task 0: > Apr 13 00:40:32 probook kernel: (stack is not available) > Apr 13 00:40:32 probook kernel: > Apr 13 00:40:32 probook kernel: The buggy address belongs to the object at ffff8803f165dd80 > which belongs to the cache kmalloc-128 of size 128 > Apr 13 00:40:32 probook kernel: The buggy address is located 116 bytes inside of > 128-byte region [ffff8803f165dd80, ffff8803f165de00) > Apr 13 00:40:32 probook kernel: The buggy address belongs to the page: > Apr 13 00:40:32 probook kernel: page:ffffea000fc59740 count:1 mapcount:0 mapping:0000000000000000 index:0x0 > Apr 13 00:40:32 probook kernel: flags: 0x2000000000000100(slab) > Apr 13 00:40:32 probook kernel: raw: 2000000000000100 0000000000000000 0000000000000000 0000000180150015 > Apr 13 00:40:32 probook kernel: raw: dead000000000100 dead000000000200 ffff8803f3403340 0000000000000000 > Apr 13 00:40:32 probook kernel: page dumped because: kasan: bad access detected > Apr 13 00:40:32 probook kernel: > Apr 13 00:40:32 probook kernel: Memory state around the buggy address: > Apr 13 00:40:32 probook kernel: ffff8803f165dc80: fc fc fc fc fc fc fc fc 00 00 00 00 00 00 00 00 > Apr 13 00:40:32 probook kernel: ffff8803f165dd00: 00 00 00 00 00 00 00 fc fc fc fc fc fc fc fc fc > Apr 13 00:40:32 probook kernel: >ffff8803f165dd80: 00 00 00 00 00 00 00 00 00 00 00 00 00 fc fc fc > Apr 13 00:40:32 probook kernel: ^ > Apr 13 00:40:32 probook kernel: ffff8803f165de00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc > Apr 13 00:40:32 probook kernel: ffff8803f165de80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc > Apr 13 00:40:32 probook kernel: ================================================================== > Putting the whole chaching part under the if (mce_flags.smca) { solved the issue on my Carrizo. -- Regards, Johannes