From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] micropython: bump version to v1.9.3
Date: Mon, 16 Apr 2018 16:01:44 +0200 [thread overview]
Message-ID: <20180416160144.08709147@windsurf.numericable.fr> (raw)
In-Reply-To: <1523885614.4244.5.camel@flir.com>
Hello Marteen,
On Mon, 16 Apr 2018 13:28:47 +0000, Blomme, Maarten wrote:
> (With correct formatting now)
Unfortunately no, the formatting is still not correct, because you
didn't send with git send-email.
> define MICROPYTHON_BUILD_CMDS
> -$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/unix \
> +$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/mpy-cross
> +$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/ports/unix \
> $(MICROPYTHON_MAKE_OPTS) \
> CROSS_COMPILE=$(TARGET_CROSS) \
> CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS)
> endef
The lines in this variable are indented in the current code, but are
not in your patch. Hence the patch is broken.
There's a reason why everybody uses git send-email: because it does the
right thing :-)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-16 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 13:28 [Buildroot] [PATCH 1/1] micropython: bump version to v1.9.3 Blomme, Maarten
2018-04-16 14:01 ` Thomas Petazzoni [this message]
2018-04-16 15:44 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2018-04-16 8:09 Blomme, Maarten
2018-04-16 12:22 ` Thomas Petazzoni
2018-04-16 13:30 ` Blomme, Maarten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416160144.08709147@windsurf.numericable.fr \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.