From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:48846 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbeDQOTN (ORCPT ); Tue, 17 Apr 2018 10:19:13 -0400 Date: Tue, 17 Apr 2018 16:19:07 +0200 From: Greg KH To: Paolo Bonzini Cc: peng.hao2@zte.com.cn, stable@vger.kernel.org Subject: Re: WTF: patch "[PATCH] kvm: x86: fix a compile warning" was seriously submitted to be applied to the 4.16-stable tree? Message-ID: <20180417141907.GA6537@kroah.com> References: <1523967586946@kroah.com> <33d6621f-ef78-cd1c-662c-3ea13884f7b9@redhat.com> <20180417125459.GA5245@kroah.com> <32d1e7bc-f424-7dcd-3bd6-c516147fe5d2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32d1e7bc-f424-7dcd-3bd6-c516147fe5d2@redhat.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Apr 17, 2018 at 04:10:41PM +0200, Paolo Bonzini wrote: > On 17/04/2018 14:54, Greg KH wrote: > >> There are people compiling with -Werror. But really, I sometimes wonder > >> if stable-kernel-rules.rst should be perused in the same way as the GNU > >> coding standards]. Most patches that are "auto-selected" these days are > >> (at least for KVM) exactly the "This could be a problem..." type of thing > >> that is singled out as _not_ stable-worthy. > > Are you sure -Werror shows this? And it's not just a sparse "warning"? > > This should be -Wimplicit, which is enabled by -Wall. ah, yet-another-W-option that should never be enabled :) thanks, greg k-h