From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [net-next V10 PATCH 00/16] XDP redirect memory return API Date: Tue, 17 Apr 2018 16:39:30 +0200 Message-ID: <20180417163930.5aa24de9@redhat.com> References: <152396988259.12633.11175312729378665019.stgit@firesoul> <20180417.100750.62384164907693513.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: alexei.starovoitov@gmail.com, netdev@vger.kernel.org, bjorn.topel@intel.com, magnus.karlsson@intel.com, eugenia@mellanox.com, jasowang@redhat.com, john.fastabend@gmail.com, eranbe@mellanox.com, saeedm@mellanox.com, galp@mellanox.com, borkmann@iogearbox.net, tariqt@mellanox.com, brouer@redhat.com To: David Miller Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44502 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752691AbeDQOjg (ORCPT ); Tue, 17 Apr 2018 10:39:36 -0400 In-Reply-To: <20180417.100750.62384164907693513.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 17 Apr 2018 10:07:50 -0400 (EDT) David Miller wrote: > From: Alexei Starovoitov > Date: Tue, 17 Apr 2018 06:53:33 -0700 > > > looks like you forgot to include extra patch to fixup xdp_adjust_head() > > helper. Otherwise reused xdp_frame in the top of that packet is leaking > > kernel pointers into bpf program. > > Could you please respin with that change included? > > Just in time, I was about to push this back out. :) > > Jesper, please respin with Alexei's requested changes. Your guys are torturing me! -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer