Re: [PATCH 1/2] xfs: validate cached inodes are free when allocated

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Wed, Apr 18, 2018 at 09:57:31AM +1000, Dave Chinner wrote:
> On Tue, Apr 17, 2018 at 11:00:30AM +0200, Carlos Maiolino wrote:
> > >  fs/xfs/xfs_icache.c | 73 +++++++++++++++++++++++++++++++++++------------------
> > >  1 file changed, 48 insertions(+), 25 deletions(-)
> > > 
> > > diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> > > index 98b7a4ae15e4..fb37ada55710 100644
> > > --- a/fs/xfs/xfs_icache.c
> > > +++ b/fs/xfs/xfs_icache.c
> > > @@ -309,6 +309,46 @@ xfs_reinit_inode(
> > >  	return error;
> > >  }
> > >  
> > > +/*
> > > + * If we are allocating a new inode, then check what was returned is
> > > + * actually a free, empty inode. If we are not allocating an inode,
> > > + * the check we didn't find a free inode.
> > 
> > I know it's been like that for a while, but maybe it's a good time to fix this
> > typo? "then check we didn't find..." ?
> > 
> > Fixing the old typo or not, the patch looks good:
> > 
> > Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> 
> Darrick, do want me to resend with the typo fix, or can you do it on
> the way into your tree?

I'll do it on the way into the tree.

--D

> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html