From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiwei Bie Subject: Re: [RFC v2] virtio: support packed ring Date: Wed, 18 Apr 2018 09:17:57 +0800 Message-ID: <20180418011757.ldeju5zh3e4366m5@debian> References: <20180401141216.8969-1-tiwei.bie@intel.com> <20180413071529.f4esh654dakodf4f@debian> <8dee7d62-ac0b-54ba-6bec-4bc4a6fb34e9@redhat.com> <20180417025133.7t7exmizgolr565z@debian> <20180417151654-mutt-send-email-mst@kernel.org> <20180417124716.wsypd5zl4n4galrz@debian> <20180417170354-mutt-send-email-mst@kernel.org> <20180417145626.y5vei4y6irrdw7ky@debian> <20180417184810-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180417184810-mutt-send-email-mst@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, wexu@redhat.com List-Id: virtualization@lists.linuxfoundation.org T24gVHVlLCBBcHIgMTcsIDIwMTggYXQgMDY6NTQ6NTFQTSArMDMwMCwgTWljaGFlbCBTLiBUc2ly a2luIHdyb3RlOgo+IE9uIFR1ZSwgQXByIDE3LCAyMDE4IGF0IDEwOjU2OjI2UE0gKzA4MDAsIFRp d2VpIEJpZSB3cm90ZToKPiA+IE9uIFR1ZSwgQXByIDE3LCAyMDE4IGF0IDA1OjA0OjU5UE0gKzAz MDAsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPiA+ID4gT24gVHVlLCBBcHIgMTcsIDIwMTgg YXQgMDg6NDc6MTZQTSArMDgwMCwgVGl3ZWkgQmllIHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgQXBy IDE3LCAyMDE4IGF0IDAzOjE3OjQxUE0gKzAzMDAsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToK PiA+ID4gPiA+IE9uIFR1ZSwgQXByIDE3LCAyMDE4IGF0IDEwOjUxOjMzQU0gKzA4MDAsIFRpd2Vp IEJpZSB3cm90ZToKPiA+ID4gPiA+ID4gT24gVHVlLCBBcHIgMTcsIDIwMTggYXQgMTA6MTE6NThB TSArMDgwMCwgSmFzb24gV2FuZyB3cm90ZToKPiA+ID4gPiA+ID4gPiBPbiAyMDE45bm0MDTmnIgx M+aXpSAxNToxNSwgVGl3ZWkgQmllIHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gT24gRnJpLCBBcHIg MTMsIDIwMTggYXQgMTI6MzA6MjRQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90ZToKPiA+ID4gPiA+ ID4gPiA+ID4gT24gMjAxOOW5tDA05pyIMDHml6UgMjI6MTIsIFRpd2VpIEJpZSB3cm90ZToKPiA+ ID4gPiA+ID4gWy4uLl0KPiA+ID4gPiA+ID4gPiA+ID4gPiArc3RhdGljIGludCBkZXRhY2hfYnVm X3BhY2tlZChzdHJ1Y3QgdnJpbmdfdmlydHF1ZXVlICp2cSwgdW5zaWduZWQgaW50IGhlYWQsCj4g PiA+ID4gPiA+ID4gPiA+ID4gKwkJCSAgICAgIHZvaWQgKipjdHgpCj4gPiA+ID4gPiA+ID4gPiA+ ID4gK3sKPiA+ID4gPiA+ID4gPiA+ID4gPiArCXN0cnVjdCB2cmluZ19wYWNrZWRfZGVzYyAqZGVz YzsKPiA+ID4gPiA+ID4gPiA+ID4gPiArCXVuc2lnbmVkIGludCBpLCBqOwo+ID4gPiA+ID4gPiA+ ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gPiArCS8qIENsZWFyIGRhdGEgcHRyLiAqLwo+ID4g PiA+ID4gPiA+ID4gPiA+ICsJdnEtPmRlc2Nfc3RhdGVbaGVhZF0uZGF0YSA9IE5VTEw7Cj4gPiA+ ID4gPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gPiA+ICsJaSA9IGhlYWQ7Cj4gPiA+ID4g PiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gPiA+ICsJZm9yIChqID0gMDsgaiA8IHZxLT5k ZXNjX3N0YXRlW2hlYWRdLm51bTsgaisrKSB7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKwkJZGVzYyA9 ICZ2cS0+dnJpbmdfcGFja2VkLmRlc2NbaV07Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKwkJdnJpbmdf dW5tYXBfb25lX3BhY2tlZCh2cSwgZGVzYyk7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKwkJZGVzYy0+ ZmxhZ3MgPSAweDA7Cj4gPiA+ID4gPiA+ID4gPiA+IExvb2tzIGxpa2UgdGhpcyBpcyB1bm5lY2Vz c2FyeS4KPiA+ID4gPiA+ID4gPiA+IEl0J3Mgc2FmZXIgdG8gemVybyBpdC4gSWYgd2UgZG9uJ3Qg emVybyBpdCwgYWZ0ZXIgd2UKPiA+ID4gPiA+ID4gPiA+IGNhbGwgdmlydHF1ZXVlX2RldGFjaF91 bnVzZWRfYnVmX3BhY2tlZCgpIHdoaWNoIGNhbGxzCj4gPiA+ID4gPiA+ID4gPiB0aGlzIGZ1bmN0 aW9uLCB0aGUgZGVzYyBpcyBzdGlsbCBhdmFpbGFibGUgdG8gdGhlCj4gPiA+ID4gPiA+ID4gPiBk ZXZpY2UuCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gV2VsbCBkZXRhY2hfdW51c2VkX2J1 Zl9wYWNrZWQoKSBzaG91bGQgYmUgY2FsbGVkIGFmdGVyIGRldmljZSBpcyBzdG9wcGVkLAo+ID4g PiA+ID4gPiA+IG90aGVyd2lzZSBldmVuIGlmIHlvdSB0cnkgdG8gY2xlYXIsIHRoZXJlIHdpbGwg c3RpbGwgYmUgYSB3aW5kb3cgdGhhdCBkZXZpY2UKPiA+ID4gPiA+ID4gPiBtYXkgdXNlIGl0Lgo+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gVGhpcyBpcyBub3QgYWJvdXQgd2hldGhlciB0aGUgZGV2 aWNlIGhhcyBiZWVuIHN0b3BwZWQgb3IKPiA+ID4gPiA+ID4gbm90LiBXZSBkb24ndCBoYXZlIG90 aGVyIHBsYWNlcyB0byByZS1pbml0aWFsaXplIHRoZSByaW5nCj4gPiA+ID4gPiA+IGRlc2NyaXB0 b3JzIGFuZCB3cmFwX2NvdW50ZXIuIFNvIHRoZXkgbmVlZCB0byBiZSBzZXQgdG8KPiA+ID4gPiA+ ID4gdGhlIGNvcnJlY3QgdmFsdWVzIHdoZW4gZG9pbmcgZGV0YWNoX3VudXNlZF9idWYuCj4gPiA+ ID4gPiA+IAo+ID4gPiA+ID4gPiBCZXN0IHJlZ2FyZHMsCj4gPiA+ID4gPiA+IFRpd2VpIEJpZQo+ ID4gPiA+ID4gCj4gPiA+ID4gPiBmaW5kIHZxcyBpcyB0aGUgdGltZSB0byBkbyBpdC4KPiA+ID4g PiAKPiA+ID4gPiBUaGUgLmZpbmRfdnFzKCkgd2lsbCBjYWxsIC5zZXR1cF92cSgpIHdoaWNoIHdp bGwgZXZlbnR1YWxseQo+ID4gPiA+IGNhbGwgdnJpbmdfY3JlYXRlX3ZpcnRxdWV1ZSgpLiBJdCdz IGEgZGlmZmVyZW50IGNhc2UuIEhlcmUKPiA+ID4gPiB3ZSdyZSB0YWxraW5nIGFib3V0IHJlLWlu aXRpYWxpemluZyB0aGUgZGVzY3MgYW5kIHVwZGF0aW5nCj4gPiA+ID4gdGhlIHdyYXAgY291bnRl ciB3aGVuIGRldGFjaGluZyB0aGUgdW51c2VkIGRlc2NzIChJbiB0aGlzCj4gPiA+ID4gY2FzZSwg c3BsaXQgcmluZyBqdXN0IG5lZWRzIHRvIGRlY3JlYXNlIHZyaW5nLmF2YWlsLT5pZHgpLgo+ID4g PiA+IAo+ID4gPiA+IEJlc3QgcmVnYXJkcywKPiA+ID4gPiBUaXdlaSBCaWUKPiA+ID4gCj4gPiA+ IFRoZXJlJ3Mgbm8gcmVxdWlyZW1lbnQgdGhhdCAgdmlydHF1ZXVlX2RldGFjaF91bnVzZWRfYnVm IHJlLWluaXRpYWxpemVzCj4gPiA+IHRoZSBkZXNjcy4gSXQgaGFwcGVucyBvbiBjbGVhbnVwIHBh dGgganVzdCBiZWZvcmUgZHJpdmVycyBkZWxldGUgdGhlCj4gPiA+IHZxcy4KPiA+IAo+ID4gQ29v bCwgSSB3YXNuJ3QgYXdhcmUgb2YgaXQuIEkgc2F3IHNwbGl0IHJpbmcgZGVjcmVhc2UKPiA+IHZy aW5nLmF2YWlsLT5pZHggYWZ0ZXIgZGV0YWNoaW5nIGFuIHVudXNlZCBkZXNjLCBzbyBJCj4gPiB0 aG91Z2h0IGRldGFjaGluZyB1bnVzZWQgZGVzYyBhbHNvIG5lZWRzIHRvIG1ha2Ugc3VyZQo+ID4g dGhhdCB0aGUgcmluZyBzdGF0ZSB3aWxsIGJlIHVwZGF0ZWQgY29ycmVzcG9uZGluZ2x5Lgo+IAo+ IAo+IEhtbS4gWW91IGFyZSByaWdodC4gU2VlbXMgdG8gYmUgb3V0IGNvbnNvbGUgZHJpdmVyIGJl aW5nIG91dCBvZiBzcGVjLgo+IFdpbGwgaGF2ZSB0byBsb29rIGF0IGhvdyB0byBmaXggdGhhdCA6 KAo+IAo+IEl0IHdhcyBkb25lIGhlcmU6Cj4gCj4gQ29tbWl0IGIzMjU4ZmYxZDYwODZiZDJiOWVl YjU1Njg0NGE4NjhhZDdkNDliYzgKPiBBdXRob3I6IEFtaXQgU2hhaCA8YW1pdC5zaGFoQHJlZGhh dC5jb20+Cj4gRGF0ZTogICBXZWQgTWFyIDE2IDE5OjEyOjEwIDIwMTEgKzA1MzAKPiAKPiAgICAg dmlydGlvOiBEZWNyZW1lbnQgYXZhaWwgaWR4IG9uIGJ1ZmZlciBkZXRhY2gKPiAgICAgCj4gICAg IFdoZW4gZGV0YWNoaW5nIGEgYnVmZmVyIGZyb20gYSB2cSwgdGhlIGF2YWlsLmlkeCB2YWx1ZSBz aG91bGQgYmUKPiAgICAgZGVjcmVtZW50ZWQgYXMgd2VsbC4KPiAgICAgCj4gICAgIFRoaXMgd2Fz IG5vdGljZWQgYnkgaG90LXVucGx1Z2dpbmcgYSB2aXJ0aW8gY29uc29sZSBwb3J0IGFuZCB0aGVu Cj4gICAgIHBsdWdnaW5nIGluIGEgbmV3IG9uZSBvbiB0aGUgc2FtZSBudW1iZXIgKHJlLXVzaW5n IHRoZSB2cXMgd2hpY2ggd2VyZQo+ICAgICBqdXN0ICdkaXNvd25lZCcpLiAgcWVtdSByZXBvcnRl ZAo+ICAgICAKPiAgICAgICAgJ0d1ZXN0IG1vdmVkIHVzZWQgaW5kZXggZnJvbSAwIHRvIDI1NicK PiAgICAgCj4gICAgIHdoZW4gYW55IElPIHdhcyBhdHRlbXB0ZWQgb24gdGhlIG5ldyBwb3J0Lgo+ ICAgICAKPiAgICAgQ0M6IHN0YWJsZUBrZXJuZWwub3JnCj4gICAgIFJlcG9ydGVkLWJ5OiBqdXpo YW5nIDxqdXpoYW5nQHJlZGhhdC5jb20+Cj4gICAgIFNpZ25lZC1vZmYtYnk6IEFtaXQgU2hhaCA8 YW1pdC5zaGFoQHJlZGhhdC5jb20+Cj4gICAgIFNpZ25lZC1vZmYtYnk6IFJ1c3R5IFJ1c3NlbGwg PHJ1c3R5QHJ1c3Rjb3JwLmNvbS5hdT4KPiAKPiBUaGUgc3BlYyBpcyBxdWl0ZSBleHBsaWNpdCB0 aG91Z2g6Cj4gCUEgZHJpdmVyIE1VU1QgTk9UIGRlY3JlbWVudCB0aGUgYXZhaWxhYmxlIGlkeCBv biBhIGxpdmUgdmlydHF1ZXVlIChpZS4gdGhlcmUgaXMgbm8gd2F5IHRvIOKAnHVuZXhwb3Nl4oCd Cj4gCWJ1ZmZlcnMpLgo+IAoKSG1tLi4gR290IGl0LiBUaGFua3MhCgpCZXN0IHJlZ2FyZHMsClRp d2VpIEJpZQoKCj4gCj4gCj4gCj4gCj4gPiBJZiB0aGVyZSBpcyBubyBzdWNoIHJlcXVpcmVtZW50 LCBkbyB5b3UgdGhpbmsgaXQncyBPSwo+ID4gdG8gcmVtb3ZlIGJlbG93IHR3byBsaW5lczoKPiA+ IAo+ID4gdnEtPmF2YWlsX2lkeF9zaGFkb3ctLTsKPiA+IHZxLT52cmluZy5hdmFpbC0+aWR4ID0g Y3B1X3RvX3ZpcnRpbzE2KF92cS0+dmRldiwgdnEtPmF2YWlsX2lkeF9zaGFkb3cpOwo+ID4gCj4g PiBmcm9tIHZpcnRxdWV1ZV9kZXRhY2hfdW51c2VkX2J1ZigpLCBhbmQgd2UgY291bGQgaGF2ZQo+ ID4gb25lIGdlbmVyaWMgZnVuY3Rpb24gdG8gaGFuZGxlIGJvdGggcmluZ3M6Cj4gPiAKPiA+IHZv aWQgKnZpcnRxdWV1ZV9kZXRhY2hfdW51c2VkX2J1ZihzdHJ1Y3QgdmlydHF1ZXVlICpfdnEpCj4g PiB7Cj4gPiAJc3RydWN0IHZyaW5nX3ZpcnRxdWV1ZSAqdnEgPSB0b192dnEoX3ZxKTsKPiA+IAl1 bnNpZ25lZCBpbnQgbnVtLCBpOwo+ID4gCXZvaWQgKmJ1ZjsKPiA+IAo+ID4gCVNUQVJUX1VTRSh2 cSk7Cj4gPiAKPiA+IAludW0gPSB2cS0+cGFja2VkID8gdnEtPnZyaW5nX3BhY2tlZC5udW0gOiB2 cS0+dnJpbmcubnVtOwo+ID4gCj4gPiAJZm9yIChpID0gMDsgaSA8IG51bTsgaSsrKSB7Cj4gPiAJ CWlmICghdnEtPmRlc2Nfc3RhdGVbaV0uZGF0YSkKPiA+IAkJCWNvbnRpbnVlOwo+ID4gCQkvKiBk ZXRhY2hfYnVmIGNsZWFycyBkYXRhLCBzbyBncmFiIGl0IG5vdy4gKi8KPiA+IAkJYnVmID0gdnEt PmRlc2Nfc3RhdGVbaV0uZGF0YTsKPiA+IAkJZGV0YWNoX2J1Zih2cSwgaSwgTlVMTCk7Cj4gPiAJ CUVORF9VU0UodnEpOwo+ID4gCQlyZXR1cm4gYnVmOwo+ID4gCX0KPiA+IAkvKiBUaGF0IHNob3Vs ZCBoYXZlIGZyZWVkIGV2ZXJ5dGhpbmcuICovCj4gPiAJQlVHX09OKHZxLT52cS5udW1fZnJlZSAh PSBudW0pOwo+ID4gCj4gPiAJRU5EX1VTRSh2cSk7Cj4gPiAJcmV0dXJuIE5VTEw7Cj4gPiB9Cj4g PiAKPiA+IEJlc3QgcmVnYXJkcywKPiA+IFRpd2VpIEJpZQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmly dHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51 eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753307AbeDRBUF (ORCPT ); Tue, 17 Apr 2018 21:20:05 -0400 Received: from mga06.intel.com ([134.134.136.31]:27721 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752679AbeDRBUD (ORCPT ); Tue, 17 Apr 2018 21:20:03 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="44125309" Date: Wed, 18 Apr 2018 09:17:57 +0800 From: Tiwei Bie To: "Michael S. Tsirkin" Cc: Jason Wang , wexu@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jfreimann@redhat.com Subject: Re: [RFC v2] virtio: support packed ring Message-ID: <20180418011757.ldeju5zh3e4366m5@debian> References: <20180401141216.8969-1-tiwei.bie@intel.com> <20180413071529.f4esh654dakodf4f@debian> <8dee7d62-ac0b-54ba-6bec-4bc4a6fb34e9@redhat.com> <20180417025133.7t7exmizgolr565z@debian> <20180417151654-mutt-send-email-mst@kernel.org> <20180417124716.wsypd5zl4n4galrz@debian> <20180417170354-mutt-send-email-mst@kernel.org> <20180417145626.y5vei4y6irrdw7ky@debian> <20180417184810-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180417184810-mutt-send-email-mst@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 17, 2018 at 06:54:51PM +0300, Michael S. Tsirkin wrote: > On Tue, Apr 17, 2018 at 10:56:26PM +0800, Tiwei Bie wrote: > > On Tue, Apr 17, 2018 at 05:04:59PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Apr 17, 2018 at 08:47:16PM +0800, Tiwei Bie wrote: > > > > On Tue, Apr 17, 2018 at 03:17:41PM +0300, Michael S. Tsirkin wrote: > > > > > On Tue, Apr 17, 2018 at 10:51:33AM +0800, Tiwei Bie wrote: > > > > > > On Tue, Apr 17, 2018 at 10:11:58AM +0800, Jason Wang wrote: > > > > > > > On 2018年04月13日 15:15, Tiwei Bie wrote: > > > > > > > > On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: > > > > > > > > > On 2018年04月01日 22:12, Tiwei Bie wrote: > > > > > > [...] > > > > > > > > > > +static int detach_buf_packed(struct vring_virtqueue *vq, unsigned int head, > > > > > > > > > > + void **ctx) > > > > > > > > > > +{ > > > > > > > > > > + struct vring_packed_desc *desc; > > > > > > > > > > + unsigned int i, j; > > > > > > > > > > + > > > > > > > > > > + /* Clear data ptr. */ > > > > > > > > > > + vq->desc_state[head].data = NULL; > > > > > > > > > > + > > > > > > > > > > + i = head; > > > > > > > > > > + > > > > > > > > > > + for (j = 0; j < vq->desc_state[head].num; j++) { > > > > > > > > > > + desc = &vq->vring_packed.desc[i]; > > > > > > > > > > + vring_unmap_one_packed(vq, desc); > > > > > > > > > > + desc->flags = 0x0; > > > > > > > > > Looks like this is unnecessary. > > > > > > > > It's safer to zero it. If we don't zero it, after we > > > > > > > > call virtqueue_detach_unused_buf_packed() which calls > > > > > > > > this function, the desc is still available to the > > > > > > > > device. > > > > > > > > > > > > > > Well detach_unused_buf_packed() should be called after device is stopped, > > > > > > > otherwise even if you try to clear, there will still be a window that device > > > > > > > may use it. > > > > > > > > > > > > This is not about whether the device has been stopped or > > > > > > not. We don't have other places to re-initialize the ring > > > > > > descriptors and wrap_counter. So they need to be set to > > > > > > the correct values when doing detach_unused_buf. > > > > > > > > > > > > Best regards, > > > > > > Tiwei Bie > > > > > > > > > > find vqs is the time to do it. > > > > > > > > The .find_vqs() will call .setup_vq() which will eventually > > > > call vring_create_virtqueue(). It's a different case. Here > > > > we're talking about re-initializing the descs and updating > > > > the wrap counter when detaching the unused descs (In this > > > > case, split ring just needs to decrease vring.avail->idx). > > > > > > > > Best regards, > > > > Tiwei Bie > > > > > > There's no requirement that virtqueue_detach_unused_buf re-initializes > > > the descs. It happens on cleanup path just before drivers delete the > > > vqs. > > > > Cool, I wasn't aware of it. I saw split ring decrease > > vring.avail->idx after detaching an unused desc, so I > > thought detaching unused desc also needs to make sure > > that the ring state will be updated correspondingly. > > > Hmm. You are right. Seems to be out console driver being out of spec. > Will have to look at how to fix that :( > > It was done here: > > Commit b3258ff1d6086bd2b9eeb556844a868ad7d49bc8 > Author: Amit Shah > Date: Wed Mar 16 19:12:10 2011 +0530 > > virtio: Decrement avail idx on buffer detach > > When detaching a buffer from a vq, the avail.idx value should be > decremented as well. > > This was noticed by hot-unplugging a virtio console port and then > plugging in a new one on the same number (re-using the vqs which were > just 'disowned'). qemu reported > > 'Guest moved used index from 0 to 256' > > when any IO was attempted on the new port. > > CC: stable@kernel.org > Reported-by: juzhang > Signed-off-by: Amit Shah > Signed-off-by: Rusty Russell > > The spec is quite explicit though: > A driver MUST NOT decrement the available idx on a live virtqueue (ie. there is no way to “unexpose” > buffers). > Hmm.. Got it. Thanks! Best regards, Tiwei Bie > > > > > > If there is no such requirement, do you think it's OK > > to remove below two lines: > > > > vq->avail_idx_shadow--; > > vq->vring.avail->idx = cpu_to_virtio16(_vq->vdev, vq->avail_idx_shadow); > > > > from virtqueue_detach_unused_buf(), and we could have > > one generic function to handle both rings: > > > > void *virtqueue_detach_unused_buf(struct virtqueue *_vq) > > { > > struct vring_virtqueue *vq = to_vvq(_vq); > > unsigned int num, i; > > void *buf; > > > > START_USE(vq); > > > > num = vq->packed ? vq->vring_packed.num : vq->vring.num; > > > > for (i = 0; i < num; i++) { > > if (!vq->desc_state[i].data) > > continue; > > /* detach_buf clears data, so grab it now. */ > > buf = vq->desc_state[i].data; > > detach_buf(vq, i, NULL); > > END_USE(vq); > > return buf; > > } > > /* That should have freed everything. */ > > BUG_ON(vq->vq.num_free != num); > > > > END_USE(vq); > > return NULL; > > } > > > > Best regards, > > Tiwei Bie