From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hangbin Liu Subject: Re: [PATCHv2 net-next] vxlan: add ttl inherit support Date: Wed, 18 Apr 2018 10:15:24 +0800 Message-ID: <20180418021524.GF20683@leo.usersys.redhat.com> References: <1523945488-27487-1-git-send-email-liuhangbin@gmail.com> <1523969574-3279-1-git-send-email-liuhangbin@gmail.com> <20180417.151627.1849186462841531455.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, jbenc@redhat.com, lucien.xin@gmail.com, sbrivio@redhat.com To: David Miller Return-path: Received: from mail-pg0-f45.google.com ([74.125.83.45]:34342 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752679AbeDRCPg (ORCPT ); Tue, 17 Apr 2018 22:15:36 -0400 Received: by mail-pg0-f45.google.com with SMTP id p10so122596pgn.1 for ; Tue, 17 Apr 2018 19:15:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180417.151627.1849186462841531455.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Apr 17, 2018 at 03:16:27PM -0400, David Miller wrote: > From: Hangbin Liu > Date: Tue, 17 Apr 2018 20:52:54 +0800 > > > Like tos inherit, ttl inherit should also means inherit the inner protocol's > > ttl values, which actually not implemented in vxlan yet. > > > > But we could not treat ttl == 0 as "use the inner TTL", because that would be > > used also when the "ttl" option is not specified and that would be a behavior > > change, and breaking real use cases. > > > > So add a different attribute IFLA_VXLAN_TTL_INHERIT when "ttl inherit" is > > specified. > > > > --- > > v2: As suggested by Stefano, clean up function ip_tunnel_get_ttl(). > > > > Suggested-by: Jiri Benc > > Signed-off-by: Hangbin Liu > > I already applied V1 of your patch. > > Furthermore, this commit message would cause your signoffs and other tags > to be removed due to the "---" deliminator. > > I generally encourage people to leave the change history text _in_ the > commit message anyways. It is useful information for the future. Thanks for the reminding. I will keep this in mind. Cheers Hangbin