From: "Nikita V. Shirokov" <tehnerd@tehnerd.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller " <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 02/11] bpf: make generic xdp compatible w/ bpf_xdp_adjust_tail
Date: Tue, 17 Apr 2018 21:48:30 -0700 [thread overview]
Message-ID: <20180418044830.GB17737@maindev> (raw)
In-Reply-To: <20180418144818.0bcba1f9@redhat.com>
On Wed, Apr 18, 2018 at 02:48:18PM +0200, Jesper Dangaard Brouer wrote:
> On Tue, 17 Apr 2018 21:29:42 -0700
> "Nikita V. Shirokov" <tehnerd@tehnerd.com> wrote:
>
> > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as
> > well (only "decrease" of pointer's location is going to be supported).
> > changing of this pointer will change packet's size.
> > for generic XDP we need to reflect this packet's length change by
> > adjusting skb's tail pointer
> >
> > Acked-by: Alexei Starovoitov <ast@kernel.org>
>
> You are missing your own Signed-off-by: line on all of the patches.
>
yeah, somehow lost it between v1 and v2 :) thanks !
> BTW, thank you for working on this! It have been on my todo-list for a
> while now!
>
> _After_ this patchset, I would like to see adding support for
> "increasing" the data_end location to create a larger packet. For that
> we should likely add a data_hard_end pointer. This, would also be
> helpful in cpu_map_build_skb() to know the data_hard_end, to determine
> the frame size (as some driver doesn't use PAGE_SIZE frames, ixgbe).
>
yeah, increasing the size would be nice to have, but will require more
thinking / rework on drivers side (as you pointed out it's not as easy
as "every driver have at least PAGE_SIZE of data available for xdp".).
will add to my TODO
>
> --
> Best regards,
> Jesper Dangaard Brouer
> MSc.CS, Principal Kernel Engineer at Red Hat
> LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-04-18 13:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 4:29 [PATCH bpf-next v2 00/11] introduction of bpf_xdp_adjust_tail Nikita V. Shirokov
2018-04-18 4:29 ` [PATCH bpf-next v2 01/11] bpf: adding bpf_xdp_adjust_tail helper Nikita V. Shirokov
2018-04-18 16:56 ` Alexei Starovoitov
2018-04-18 4:29 ` [PATCH bpf-next v2 02/11] bpf: make generic xdp compatible w/ bpf_xdp_adjust_tail Nikita V. Shirokov
2018-04-18 12:48 ` Jesper Dangaard Brouer
2018-04-18 4:48 ` Nikita V. Shirokov [this message]
2018-04-18 4:29 ` [PATCH bpf-next v2 03/11] bpf: make mlx4 " Nikita V. Shirokov
2018-04-18 10:53 ` Tariq Toukan
2018-04-18 4:29 ` [PATCH bpf-next v2 04/11] bpf: make bnxt " Nikita V. Shirokov
2018-04-18 4:29 ` [PATCH bpf-next v2 05/11] bpf: make cavium thunder " Nikita V. Shirokov
2018-04-18 4:29 ` [PATCH bpf-next v2 06/11] bpf: make netronome nfp " Nikita V. Shirokov
2018-04-18 4:29 ` [PATCH bpf-next v2 07/11] bpf: make tun " Nikita V. Shirokov
2018-04-18 4:29 ` [PATCH bpf-next v2 08/11] bpf: make virtio " Nikita V. Shirokov
2018-04-18 4:29 ` [PATCH bpf-next v2 09/11] bpf: making bpf_prog_test run aware of possible data_end ptr change Nikita V. Shirokov
2018-04-18 4:29 ` [PATCH bpf-next v2 10/11] bpf: adding tests for bpf_xdp_adjust_tail Nikita V. Shirokov
2018-04-18 4:29 ` [PATCH bpf-next v2 11/11] bpf: add bpf_xdp_adjust_tail sample prog Nikita V. Shirokov
2018-04-18 12:37 ` [PATCH bpf-next v2 00/11] introduction of bpf_xdp_adjust_tail Daniel Borkmann
2018-04-18 4:44 ` Nikita V. Shirokov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418044830.GB17737@maindev \
--to=tehnerd@tehnerd.com \
--cc=ast@kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.