From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH 0/4] Fixes for coverity issues in fbarray Date: Wed, 18 Apr 2018 10:51:39 +0200 Message-ID: <20180418085139.GN4957@6wind.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, thomas@monjalon.net To: Anatoly Burakov Return-path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 6CD586CBB for ; Wed, 18 Apr 2018 10:51:54 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id d19-v6so2578839wre.1 for ; Wed, 18 Apr 2018 01:51:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 17, 2018 at 04:44:04PM +0100, Anatoly Burakov wrote: > This patchset fixes a number of Coverity issues introduced > in recent DPDK memory hotplug patchset. > > Coverity issues fixed: > - 272564 - error condition not checked > - 272579 - dereference before null check > - 272586 - error condition not checked > > There are two additional issues reported by coverity: > - 272598 - error condition not checked > - 272599 - error condition not checked > > However, they are fixed by a separate patch [1]. > > [1] http://dpdk.org/dev/patchwork/patch/38091/ > > Anatoly Burakov (4): > fbarray: use strlcpy instead of snprintf > fbarray: add check for failed file descriptor open > fbarray: fix potential null-dereference > fbarray: handle negative return Given that I recently addressed a similar issue in fbarray as well: Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND