From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Yang Shi <yang.shi@linux.alibaba.com>,
adobriyan@gmail.com, willy@infradead.org, mguzik@redhat.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [v4 PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct
Date: Wed, 18 Apr 2018 12:02:17 +0300 [thread overview]
Message-ID: <20180418090217.GG19578@uranus.lan> (raw)
In-Reply-To: <20180418080555.GR17484@dhcp22.suse.cz>
On Wed, Apr 18, 2018 at 10:05:55AM +0200, Michal Hocko wrote:
>
> Yes, looks good to me. As mentioned in other emails prctl_set_mm_map
> really deserves a comment explaining why we are doing the down_read
>
> What about something like the following?
> "
> arg_lock protects concurent updates but we still need mmap_sem for read
> to exclude races with do_brk.
> "
> Acked-by: Michal Hocko <mhocko@suse.com>
Yes, thanks! Andrew, could you slightly update the changelog please?
next prev parent reply other threads:[~2018-04-18 9:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 18:24 [v4 PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct Yang Shi
2018-04-15 20:49 ` Cyrill Gorcunov
2018-04-17 18:29 ` Andrew Morton
2018-04-17 20:39 ` Cyrill Gorcunov
2018-04-18 8:00 ` Michal Hocko
2018-04-17 20:52 ` Yang Shi
2018-04-18 8:05 ` Michal Hocko
2018-04-18 9:02 ` Cyrill Gorcunov [this message]
2018-04-18 9:03 ` Michal Hocko
2018-04-18 9:40 ` Cyrill Gorcunov
2018-04-18 18:18 ` Yang Shi
2018-04-18 10:11 ` Kirill Tkhai
2018-04-18 18:48 ` Yang Shi
2018-04-18 22:59 ` Kirill Tkhai
2018-04-18 22:59 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418090217.GG19578@uranus.lan \
--to=gorcunov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mguzik@redhat.com \
--cc=mhocko@kernel.org \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.