From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@bootlin.com (Boris Brezillon) Date: Wed, 18 Apr 2018 09:16:58 +0200 Subject: [PATCH v2 2/6] dt-bindings: display: atmel: optional video-interface of endpoints In-Reply-To: <20180417131052.16336-3-peda@axentia.se> References: <20180417131052.16336-1-peda@axentia.se> <20180417131052.16336-3-peda@axentia.se> Message-ID: <20180418091658.690e3d5e@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Peter, On Tue, 17 Apr 2018 15:10:48 +0200 Peter Rosin wrote: > With bus-type/bus-width properties in the endpoint nodes, the video- > interface of the connection can be specified for cases where the > heuristic fails to select the correct output mode. This can happen > e.g. if not all RGB pins are routed on the PCB; the driver has no > way of knowing this, and needs to be told explicitly. > > This is critical for the devices that have the "conflicting output > formats" issue (SAM9N12, SAM9X5, SAMA5D3), since the most significant > RGB bits move around depending on the selected output mode. For > devices that do not have the "conflicting output formats" issue > (SAMA5D2, SAMA5D4), this is completely irrelevant. > > Signed-off-by: Peter Rosin > --- > Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > index 82f2acb3d374..244b48869eb4 100644 > --- a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > +++ b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > @@ -15,6 +15,14 @@ Required children nodes: > to external devices using the OF graph reprensentation (see ../graph.txt). > At least one port node is required. > > +Optional properties in grandchild nodes: > + Any endpoint grandchild node may specify a desired video interface > + according to ../../media/video-interfaces.txt, specifically > + - bus-type: must be <0>. > + - bus-width: recognized values are <12>, <16>, <18> and <24>, and > + override any output mode selection hueristic, forcing "rgb444", > + "rgb565", "rgb666" and "rgb888" respectively. > + Can you add an example or update the existing one to show how this should be defined? > Example: > > hlcdc: hlcdc at f0030000 { Thanks, Boris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 2/6] dt-bindings: display: atmel: optional video-interface of endpoints Date: Wed, 18 Apr 2018 09:16:58 +0200 Message-ID: <20180418091658.690e3d5e@bbrezillon> References: <20180417131052.16336-1-peda@axentia.se> <20180417131052.16336-3-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180417131052.16336-3-peda@axentia.se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Rosin Cc: Mark Rutland , Boris Brezillon , Alexandre Belloni , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Nicolas Ferre , Rob Herring , Laurent Pinchart , Daniel Vetter , Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgUGV0ZXIsCgpPbiBUdWUsIDE3IEFwciAyMDE4IDE1OjEwOjQ4ICswMjAwClBldGVyIFJvc2lu IDxwZWRhQGF4ZW50aWEuc2U+IHdyb3RlOgoKPiBXaXRoIGJ1cy10eXBlL2J1cy13aWR0aCBwcm9w ZXJ0aWVzIGluIHRoZSBlbmRwb2ludCBub2RlcywgdGhlIHZpZGVvLQo+IGludGVyZmFjZSBvZiB0 aGUgY29ubmVjdGlvbiBjYW4gYmUgc3BlY2lmaWVkIGZvciBjYXNlcyB3aGVyZSB0aGUKPiBoZXVy aXN0aWMgZmFpbHMgdG8gc2VsZWN0IHRoZSBjb3JyZWN0IG91dHB1dCBtb2RlLiBUaGlzIGNhbiBo YXBwZW4KPiBlLmcuIGlmIG5vdCBhbGwgUkdCIHBpbnMgYXJlIHJvdXRlZCBvbiB0aGUgUENCOyB0 aGUgZHJpdmVyIGhhcyBubwo+IHdheSBvZiBrbm93aW5nIHRoaXMsIGFuZCBuZWVkcyB0byBiZSB0 b2xkIGV4cGxpY2l0bHkuCj4gCj4gVGhpcyBpcyBjcml0aWNhbCBmb3IgdGhlIGRldmljZXMgdGhh dCBoYXZlIHRoZSAiY29uZmxpY3Rpbmcgb3V0cHV0Cj4gZm9ybWF0cyIgaXNzdWUgKFNBTTlOMTIs IFNBTTlYNSwgU0FNQTVEMyksIHNpbmNlIHRoZSBtb3N0IHNpZ25pZmljYW50Cj4gUkdCIGJpdHMg bW92ZSBhcm91bmQgZGVwZW5kaW5nIG9uIHRoZSBzZWxlY3RlZCBvdXRwdXQgbW9kZS4gRm9yCj4g ZGV2aWNlcyB0aGF0IGRvIG5vdCBoYXZlIHRoZSAiY29uZmxpY3Rpbmcgb3V0cHV0IGZvcm1hdHMi IGlzc3VlCj4gKFNBTUE1RDIsIFNBTUE1RDQpLCB0aGlzIGlzIGNvbXBsZXRlbHkgaXJyZWxldmFu dC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBSb3NpbiA8cGVkYUBheGVudGlhLnNlPgo+IC0t LQo+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9hdG1lbC9obGNk Yy1kYy50eHQgfCA4ICsrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKykK PiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3Bs YXkvYXRtZWwvaGxjZGMtZGMudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2Rpc3BsYXkvYXRtZWwvaGxjZGMtZGMudHh0Cj4gaW5kZXggODJmMmFjYjNkMzc0Li4yNDRiNDg4 NjllYjQgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rp c3BsYXkvYXRtZWwvaGxjZGMtZGMudHh0Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2Rpc3BsYXkvYXRtZWwvaGxjZGMtZGMudHh0Cj4gQEAgLTE1LDYgKzE1LDE0IEBA IFJlcXVpcmVkIGNoaWxkcmVuIG5vZGVzOgo+ICAgdG8gZXh0ZXJuYWwgZGV2aWNlcyB1c2luZyB0 aGUgT0YgZ3JhcGggcmVwcmVuc2VudGF0aW9uIChzZWUgLi4vZ3JhcGgudHh0KS4KPiAgIEF0IGxl YXN0IG9uZSBwb3J0IG5vZGUgaXMgcmVxdWlyZWQuCj4gIAo+ICtPcHRpb25hbCBwcm9wZXJ0aWVz IGluIGdyYW5kY2hpbGQgbm9kZXM6Cj4gKyBBbnkgZW5kcG9pbnQgZ3JhbmRjaGlsZCBub2RlIG1h eSBzcGVjaWZ5IGEgZGVzaXJlZCB2aWRlbyBpbnRlcmZhY2UKPiArIGFjY29yZGluZyB0byAuLi8u Li9tZWRpYS92aWRlby1pbnRlcmZhY2VzLnR4dCwgc3BlY2lmaWNhbGx5Cj4gKyAtIGJ1cy10eXBl OiBtdXN0IGJlIDwwPi4KPiArIC0gYnVzLXdpZHRoOiByZWNvZ25pemVkIHZhbHVlcyBhcmUgPDEy PiwgPDE2PiwgPDE4PiBhbmQgPDI0PiwgYW5kCj4gKyAgIG92ZXJyaWRlIGFueSBvdXRwdXQgbW9k ZSBzZWxlY3Rpb24gaHVlcmlzdGljLCBmb3JjaW5nICJyZ2I0NDQiLAo+ICsgICAicmdiNTY1Iiwg InJnYjY2NiIgYW5kICJyZ2I4ODgiIHJlc3BlY3RpdmVseS4KPiArCgpDYW4geW91IGFkZCBhbiBl eGFtcGxlIG9yIHVwZGF0ZSB0aGUgZXhpc3Rpbmcgb25lIHRvIHNob3cgaG93IHRoaXMKc2hvdWxk IGJlIGRlZmluZWQ/Cgo+ICBFeGFtcGxlOgo+ICAKPiAgCWhsY2RjOiBobGNkY0BmMDAzMDAwMCB7 CgoKVGhhbmtzLAoKQm9yaXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753549AbeDRHRP (ORCPT ); Wed, 18 Apr 2018 03:17:15 -0400 Received: from mail.bootlin.com ([62.4.15.54]:53270 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753346AbeDRHRM (ORCPT ); Wed, 18 Apr 2018 03:17:12 -0400 Date: Wed, 18 Apr 2018 09:16:58 +0200 From: Boris Brezillon To: Peter Rosin Cc: linux-kernel@vger.kernel.org, David Airlie , Rob Herring , Mark Rutland , Nicolas Ferre , Alexandre Belloni , Boris Brezillon , Daniel Vetter , Gustavo Padovan , Sean Paul , Laurent Pinchart , Russell King - ARM Linux , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/6] dt-bindings: display: atmel: optional video-interface of endpoints Message-ID: <20180418091658.690e3d5e@bbrezillon> In-Reply-To: <20180417131052.16336-3-peda@axentia.se> References: <20180417131052.16336-1-peda@axentia.se> <20180417131052.16336-3-peda@axentia.se> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Tue, 17 Apr 2018 15:10:48 +0200 Peter Rosin wrote: > With bus-type/bus-width properties in the endpoint nodes, the video- > interface of the connection can be specified for cases where the > heuristic fails to select the correct output mode. This can happen > e.g. if not all RGB pins are routed on the PCB; the driver has no > way of knowing this, and needs to be told explicitly. > > This is critical for the devices that have the "conflicting output > formats" issue (SAM9N12, SAM9X5, SAMA5D3), since the most significant > RGB bits move around depending on the selected output mode. For > devices that do not have the "conflicting output formats" issue > (SAMA5D2, SAMA5D4), this is completely irrelevant. > > Signed-off-by: Peter Rosin > --- > Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > index 82f2acb3d374..244b48869eb4 100644 > --- a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > +++ b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > @@ -15,6 +15,14 @@ Required children nodes: > to external devices using the OF graph reprensentation (see ../graph.txt). > At least one port node is required. > > +Optional properties in grandchild nodes: > + Any endpoint grandchild node may specify a desired video interface > + according to ../../media/video-interfaces.txt, specifically > + - bus-type: must be <0>. > + - bus-width: recognized values are <12>, <16>, <18> and <24>, and > + override any output mode selection hueristic, forcing "rgb444", > + "rgb565", "rgb666" and "rgb888" respectively. > + Can you add an example or update the existing one to show how this should be defined? > Example: > > hlcdc: hlcdc@f0030000 { Thanks, Boris