All of lore.kernel.org
 help / color / mirror / Atom feed
From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH] nvme: make NVME_SC_UNWRITTEN_BLOCK a thin-provisioned error
Date: Wed, 18 Apr 2018 12:33:17 +0200	[thread overview]
Message-ID: <20180418123317.24da7d3e@pentland.suse.de> (raw)
In-Reply-To: <20180418101835.GA15833@lst.de>

On Wed, 18 Apr 2018 12:18:35 +0200
Christoph Hellwig <hch@lst.de> wrote:

> On Wed, Apr 18, 2018@09:27:23AM +0200, Hannes Reinecke wrote:
> > According to the spec NVME_SC_UNWRITTEN_BLOCK signals
> > 'an attempt to read from an LBA range containing a deallocated
> > or unwritten logical block'.
> > So this is not so much about the medium being faulty, but
> > rather should be classified as a thin-provisioning error
> > and should be mapped onto ENOSPC.  
> 
> Use up your available space for the commit log, please :)
> 
> Otherwise this looks fine, although we are unlikely to ever hit it
> given that Linux never sets the DULBE bit, and setting that bit
> would break all the partition table and fs probing we have.

Ah. So that's related to the DULBE bit; good to know.
(Maybe it could be mentioned in the spec together with the definition
in status code.)

So we're having two issues here; the one is the misclassification of
the status code, and the other one is the array sending us this error
even though we didn't enable DULBE.
I'll let them know.

Cheers,

Hannes

  reply	other threads:[~2018-04-18 10:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  7:27 [PATCH] nvme: make NVME_SC_UNWRITTEN_BLOCK a thin-provisioned error Hannes Reinecke
2018-04-18 10:18 ` Christoph Hellwig
2018-04-18 10:33   ` Hannes Reinecke [this message]
2018-04-18 10:35     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418123317.24da7d3e@pentland.suse.de \
    --to=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.